Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#61 2020-01-21 13:57:57

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,250
Website GitHub

Re: themes on 4.8beta

Yeah, we probably don’t need the strike through. It gives a confusing message, imo. Like: are the live assets in use any more at all or have they been replaced by my latest action?

With the dev assets / themes always at the bottom (when needed) indicating that they’re “waiting” to be pushed up to replace what’s currently live, I think that’s enough of a clue.

EDIT: I’ve removed the strikethrough. Is that better?

Last edited by Bloke (2020-01-21 14:05:39)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#62 2020-01-21 14:21:58

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: themes on 4.8beta

Bloke wrote #321245:

EDIT: I’ve removed the strikethrough. Is that better?

That is better for me thanks, I’ll await any other feedback.

Offline

#63 2020-01-22 00:29:51

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,058
Website

Re: themes on 4.8beta

philwareham wrote #321246:

That is better for me thanks, I’ll await any other feedback.

Yeah, the strike-through / <del /> was not ideal for this. OTOH, maybe the non-active-theme-in-developer-mode could be greyed out or something, to put more (visual) emphasis on the active one. IOW, indicating it as secondary text.

But we don’t have a class / style to indicate such a secondary text that could look greyed out or some such. .secondary-text maybe? (could look like footnote text).

That could also be used for the “Article URL pattern” column to indicate the default pattern (currently using the .disabled class, which is not ideal from a semantic point of view).

Edit / PS – Example (for the Skin column only atm)

Last edited by phiw13 (2020-01-22 00:51:22)


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#64 2020-01-22 07:13:45

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: themes on 4.8beta

Agreed Philippe, good idea. I’ll add that extra class later today. We should then be ready for beta2 release I think.

Offline

#65 2020-01-22 10:15:10

etc
Developer
Registered: 2010-11-11
Posts: 5,028
Website GitHub

Re: themes on 4.8beta

phiw13 wrote #321252:

Yeah, the strike-through / <del /> was not ideal for this. OTOH, maybe the non-active-theme-in-developer-mode could be greyed out or something, to put more (visual) emphasis on the active one. IOW, indicating it as secondary text.

That was the idea, and strike-through looked more adapted than greying-out for colour-blind people to me. But styling (be it del or .some-class) is themes authors affair.

Offline

#66 2020-01-22 10:28:30

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,058
Website

Re: themes on 4.8beta

philwareham wrote #321253:

Agreed Philippe, good idea. I’ll add that extra class later today. We should then be ready for beta2 release I think.

Yes ! for beta 2.

etc wrote #321256:

That was the idea, and strike-through looked more adapted than greying-out for colour-blind people to me. But styling (be it del or .some-class) is themes authors affair.

Yeah, .some-class is not ideal for users relying on assistive technology (it is meaningless), but there is nothing in HTML that would provide some adequate meaning. And <del /> is not great at all. One could always style the text-decoration with a faint colour with text-decoration-color if the theme author wants / feels


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#67 2020-01-22 14:28:21

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: themes on 4.8beta

OK, .secondary-text style is now in the aforementioned text entries instead of .disabled. Once this is verified as OK I’m happy to move to beta2 release. Cheers all.

Offline

#68 2020-01-22 16:17:19

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,007
Website GitHub Mastodon Twitter

Re: themes on 4.8beta

philwareham wrote #321262:

OK, .secondary-text style is now in the aforementioned text entries instead of .disabled. Once this is verified as OK I’m happy to move to beta2 release. Cheers all.

Ready to test:)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#69 2020-01-22 17:01:25

etc
Developer
Registered: 2010-11-11
Posts: 5,028
Website GitHub

Re: themes on 4.8beta

philwareham wrote #321262:

OK, .secondary-text style is now in the aforementioned text entries instead of .disabled.

For URL patterns .disabled actually means ‘empty’ or ‘default’, I just have not found a more appropriate class.

Offline

#70 2020-01-22 17:52:56

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,007
Website GitHub Mastodon Twitter

Re: themes on 4.8beta

etc wrote #321276:

For URL patterns .disabled actually means ‘empty’ or ‘default’, I just have not found a more appropriate class.

What about .default?


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#71 2020-01-22 18:01:29

etc
Developer
Registered: 2010-11-11
Posts: 5,028
Website GitHub

Re: themes on 4.8beta

colak wrote #321278:

What about .default?

It’s better semantically, but is it in ‘Hive’ css? I haven’t introduced any new classes, just used the existing ones (.disabled being the closest to what we needed).

Offline

#72 2020-01-22 18:54:39

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: themes on 4.8beta

It’s fine as secondary – it’s only a visual class, there is no semantics involved or assistive attributes used.

Offline

Board footer

Powered by FluxBB