Textpattern CMS support forum

You are not logged in. Register | Login | Help

#11 2019-08-24 07:32:42

jakob
Admin
From: Germany
Registered: 2005-01-20
Posts: 3,547
Website

Re: Are Textile'd images broken on the forum for anyone else?

Gocom wrote #319116:

Ding, ding ding. Those Parser::setImage(bool $enabled) appear to be wrong way around. Images appear to be TRUE for new users, and FALSE for everyone else. All of that is written blind, so it’s the least you could expect.

Thanks Jukka. We’ve obviously got so used to you being spot on!

If I’ve understood you correctly, it looks like true and false in lines 1752 and 1756 of src/setup/patches/feature-textpattern-forum.patch need to be switched.

Perhaps someone with the appropriate access/commit rights can amend that (Phil, Stef, Pete?). Note also Jukka’s comment on reapplying the patch and amending the signatures … you know better than me what’s involved.


TXP Builders – finely-crafted code, design and txp

Offline

#12 2019-08-24 14:38:52

gaekwad
Admin
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 2,590

Re: Are Textile'd images broken on the forum for anyone else?

Excellent sleuthing, bravo! Thanks very much, jakob and Gocom.

Taking Jukka’s comment into account, I’ve opened github.com/textpattern/textpattern-forum/issues/310 — forum scaffold is typically Phil’s domain, so I’ll wait to see what the best approach (read: beyond my pay grade, even on UK Bank Holiday weekend rates).

Offline

#13 2019-09-23 10:05:21

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,775
Website

Re: Are Textile'd images broken on the forum for anyone else?

Images are still not working for me. Did anyone have a chance to look into this? Ta!


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#14 2019-09-23 10:07:50

gaekwad
Admin
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 2,590

Re: Are Textile'd images broken on the forum for anyone else?

Without sounding like a stalker, it looks Phil is back online, judging by his GitHub commits so far today.

Offline

#15 2019-09-26 09:46:47

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,198
Website

Re: Are Textile'd images broken on the forum for anyone else?

Hi all, sorry for the silence – been very busy last few weeks. Give the images a try again now – hopefully it is fixed based on Jukka and Jakob’s suggestions.

Offline

#16 2019-09-26 09:47:51

gaekwad
Admin
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 2,590

Re: Are Textile'd images broken on the forum for anyone else?

Sorted. Thanks, Phil!

Offline

#17 2019-09-26 09:59:35

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,775
Website

Re: Are Textile'd images broken on the forum for anyone else?

Nice one, thanks for fixing it.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#18 2019-09-26 10:48:42

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 7,334
Website

Re: Are Textile'd images broken on the forum for anyone else?

works as expected from here.


Yiannis
——————————
neme.org | hblack.net | LABS | State Machines | Respbublika! | NeMe @ github

Offline

Board footer

Powered by FluxBB