Feedback to: Textpattern CMS 4.7.2 Released

etc · 2018-12-27 17:48:58

GugUser wrote #315773:

I had tried that before I asked in the forum, but as strange as that is, there was no effect.

Now I will try out jacob’s suggestion.

Have you updated the corresponding language on the Language tab? Just out of curiosity though, jacob’s suggestion is much cleaner.

GugUser · 2018-12-27 17:50:44

jakob wrote #315772:

Textile has a method (also detailed here) for custom quotes and Textpattern does use it as well.

In these parts I made the changes in earlier versions, but that doesn’t work anymore.

What you probably need to do is switch to your language, and then on the Admin › Languages panel, paste the following into the textpack box to override the standard settings.

#language de-de…@

It’s the equivalent strings to these lines in the respective language’s .ini file.

Great, it’s simple and it works.

Thank you, jakob.

GugUser · 2018-12-27 17:56:06

etc wrote #315775:

Have you updated the corresponding language on the Language tab? Just out of curiosity though, jacob’s suggestion is much cleaner.

Yes, jakob’s suggestion is clean, without having to change core files. I like it.

jakob · 2018-12-27 18:04:03

I think Oleg’s suggestion would work just as well, but the ini file needs changing before installing Textpattern. It may make sense to create a de-ch.ini file with an appropriate own language code at the top to avoid the quotes being overwritten by subsequent updates (right, Oleg?).

GugUser · 2018-12-27 18:10:59

This is a controversial discussion because not all people likes these quotes «». There is also the other alternative for German »«. The question would be, how could this be solved so that everyone can choose which version they want?

etc · 2018-12-27 18:27:25

jakob wrote #315780:

the ini file needs changing before installing Textpattern.

AFAIK, any change in .ini files made after the language install should be detected.

It may make sense to create a de-ch.ini file with an appropriate own language code at the top to avoid the quotes being overwritten by subsequent updates (right, Oleg?).

That could work but, to be honest, I have never really delved into language management.

Bloke · 2018-12-27 21:37:13

GugUser wrote #315781:

This is a controversial discussion because not all people likes these quotes «». There is also the other alternative for German »«. The question would be, how could this be solved so that everyone can choose which version they want?

Is there any mileage in being able to override strings on a per-language (file) basis as GugUser suggests – either in config.php or as a single .ini file somewhere that can act as an override. e.g.:

[@de]
txt_quote_double_close = "«"
txt_quote_double_open = "»"
txt_quote_single_close = "‘"
txt_quote_single_open = "‚"
[@fr]
hidden="Caché"
...

The contents of this well-known file could be included just like we do plugin strings on-the-fly with the proviso that you can only override strings that are already present (so we know their group) and thus only in languages that are installed. Any strings or language identifiers that are not represented in the DB are ignored.

Would something like that be beneficial to catch corner cases like this, or is there some better mechanism? Perhaps a de-ch language file is necessary, but are the conventions an accepted standard?

jakob · 2018-12-28 11:25:03

All could work, but having it in config.php means it doesn’t run the risk of being overseen when updating to a newer version of textpattern.

Textpattern CMS

Textpattern CMS support forum

#41 2018-12-27 17:48:58

Re: Feedback to: Textpattern CMS 4.7.2 Released

GugUser wrote #315773:

#42 2018-12-27 17:50:44

Re: Feedback to: Textpattern CMS 4.7.2 Released

jakob wrote #315772:

#43 2018-12-27 17:56:06

Re: Feedback to: Textpattern CMS 4.7.2 Released

etc wrote #315775:

#44 2018-12-27 18:04:03

Re: Feedback to: Textpattern CMS 4.7.2 Released

#45 2018-12-27 18:10:59

Re: Feedback to: Textpattern CMS 4.7.2 Released

#46 2018-12-27 18:27:25

Re: Feedback to: Textpattern CMS 4.7.2 Released

jakob wrote #315780:

#47 2018-12-27 21:37:13

Re: Feedback to: Textpattern CMS 4.7.2 Released

GugUser wrote #315781:

#48 2018-12-28 11:25:03

Re: Feedback to: Textpattern CMS 4.7.2 Released

Board footer