Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Short-tags and shortcodes
Bloke wrote #310557:
Even if I make my shortcode Form name
figureI still need theyieldattribute if I want to pass in attributes. Otherwise it complainsUnknown tag attribute: idetc.
A form called figure can be invoked as shortcode <txp::figure />, but a form called my figure can not, that’s what I meant.
Internally, <txp::shortcode /> is just an alias of <txp:output_form yield form="shortcode" />. The yield attribute means “store extra attributes as values of <txp:yield /> tags inside the form and don’t complain”. Should this be the default behavior of <txp:output_form />? Currently, without yield attribute it issues a Unknown tag attribute warning (whatever form name), but it would be a very minor backwards incompatibility to drop it and use yield mode by default.
Offline
Re: Short-tags and shortcodes
Any discrepencies were likely my fault in reorganzing/editing docs, which is exactly why I wanted people to review the changes.
Offline
Re: Short-tags and shortcodes
etc wrote #310559:
The
yieldattribute means “store extra attributes as values of<txp:yield />tags inside the form and don’t complain”. Should this be the default behavior of<txp:output_form />?
Since the functionality to add arbitrary attributes to <txp:output_form> wasn’t available in prior versions, I don’t see any problem with this, and it’s one less attribute for people to have to add by hand.
What b/c issues could arise? I can’t think of any. Presumably we could still use yield="att1, att2, ..." to explicitly name attributes that we want to allow if any corner cases cropped up?
Last edited by Bloke (2018-04-02 11:04:26)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
Re: Short-tags and shortcodes
Destry wrote #310560:
Any discrepencies were likely my fault in reorganzing/editing docs, which is exactly why I wanted people to review the changes.
I’m to blame too for still changing things in beta, but we’ll nail it.
Bloke wrote #310561:
What b/c issues could arise? I can’t think of any. Presumably we could still use
yield="att1, att2, ..."to explicitly name attributes that we want to allow if any corner cases cropped up?
It’s mostly “where’s my warning gone” :-) Ok, I will modify it this way. Sorry for constant doc rewrites it yields.
Offline
Re: Short-tags and shortcodes
etc wrote #310563:
It’s mostly “where’s my warning gone” :-)
Haha! Don’t think anyone would complain about that. Might be a slight issue if someone uses Ignore me.<txp:output_form name="figure" /> instead of form="figure", right? But that should still complain if the mandatory attribute’s missing.
Sorry for constant doc rewrites it yields.
No worries. A better user experience is the ultimate goal.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline