Parts of backend not functioning after update

etc · 2017-12-19 12:33:07

Bloke wrote #308355:

Loop by hand with a DirectoryIterator or FilesystemIterator.

+1

datorhaexa · 2017-12-19 12:33:54

Bloke wrote #308356:

It’s only a warning. Will disappear when you put the site in Live mode.

Yes, warning I should have said. :-)

Bloke · 2017-12-19 12:34:40

etc wrote #308357:

+1

Let’s do that then. If you have ten mins today, please feel free to replace any glob() calls with that. If not, I’ll tackle it (probably tonight if I can).

datorhaexa · 2017-12-19 12:36:28

I seem to be the unsuspecting tester.

Bloke · 2017-12-19 12:45:21

datorhaexa wrote #308360:

I seem to be the unsuspecting tester.

We have a lot of those ;-) That’s what makes Txp so rock solid.

etc · 2017-12-19 12:47:45

Bloke wrote #308359:

Let’s do that then. If you have ten mins today, please feel free to replace any glob() calls with that. If not, I’ll tackle it (probably tonight if I can).

It does not seem to filter by a mask, so we can also just do two or three glob() calls, or even glob everything and filter manually for lang directory.

datorhaexa wrote #308360:

I seem to be the unsuspecting tester.

You’ll be if you install 4.7. And welcome home btw :-)

Bloke · 2017-12-19 12:57:36

etc wrote #308362:

It does not seem to filter by a mask

Nope. So either mechanism you mentioned works for me, whichever is most efficient/neatest.

etc · 2017-12-19 13:37:54

Done it in Lang.php (4.7), but not (yet) in setup, since we have spoken of removing themes directory from there anyway? If so, only one directory has to be scanned, hence no need fo GLOB_BRACE.

Bloke · 2017-12-19 14:05:59

etc wrote #308364:

Done it in Lang.php (4.7)

Awesome! Great solution to fall back on an iterator if GLOB_BRACE isn’t available.

but not (yet) in setup, since we have spoken of removing themes directory from there anyway?

I can’t remember actually, but I think we decided to only ship public themes in the setup directory and not with the main 4.7 themes directory. This is so that we don’t potentially overwrite anyone’s sites, as there’d be no simple way to ‘sync’ the file system with the DB on upgrade (short of forcing an export, which seems a bit risky for anyone who’s running 4.7.0-dev and has started playing with themes already).

Can’t recall for sure, but I think that was the outcome. So we should be able to do the same trick in setup.

EDIT: Might even be some code reduction to be had here, when Themes is merged, as we could possibly use the Theme API to handle content loading. Probably should check the Themes does this glob fallback too.

Last edited by Bloke (2017-12-19 14:08:42)

etc · 2017-12-19 16:08:16

Bloke wrote #308365:

I can’t remember actually, but I think we decided to only ship public themes in the setup directory and not with the main 4.7 themes directory. This is so that we don’t potentially overwrite anyone’s sites, as there’d be no simple way to ‘sync’ the file system with the DB on upgrade (short of forcing an export, which seems a bit risky for anyone who’s running 4.7.0-dev and has started playing with themes already).

These brave people must love the risk if they are running dev, so no worries. :-) But AFAIR Phil wanted (well…) to ship a very basic public theme too, to play with. And if both (basic and default) are put in setup, one of them will be deleted with setup, without any chance to be played with.

philwareham · 2017-12-19 16:33:21

etc wrote #308366:

But AFAIR Phil wanted (well…) to ship a very basic public theme too, to play with.

Not wishing to gatecrash Ralitza’s original topic with other discussions – but no I just wanted the default theme to be in the public themes folder not setup. If and when people upgrade to 4.7.x or 4.8 or whatever we can just put in the upgrade instructions that if you’ve called your own theme ‘default’ then don’t overwrite it with the upgrade file (or better still don’t call it default in the first place).

Primary reason for this was that users could then edit and play with that theme as a flat file, instead of it being lost (apart from being in database) when setup ends.

etc · 2017-12-19 17:01:38

philwareham wrote #308367:

I just wanted the default theme to be in the public themes folder not setup. … Primary reason for this was that users could then edit and play with that theme as a flat file, instead of it being lost (apart from being in database) when setup ends.

Then it shouldn’t be called default, imo. But I leave it with themes maestros.

Bloke · 2017-12-19 17:05:16

etc wrote #308368:

Then it shouldn’t be called default, imo.

I think that was my recommendation too. There’s a thread about this somewhere (maybe GitHub, maybe here?) where we came to a conclusion.

EDIT: Found it.

Last edited by Bloke (2017-12-19 17:11:08)

philwareham · 2017-12-19 17:22:59

Bloke wrote #308369:

EDIT: Found it.

Right. I seem to have flip-flopped between wanting the default in the setup folder and theme folder and I still don’t know what the final decision was that we all agreed on. Anyway let’s continue this discussion on GitHub once the theme branch is merged.

Textpattern CMS support forum

#16 2017-12-19 12:33:07

Re: Parts of backend not functioning after update

Bloke wrote #308355:

#17 2017-12-19 12:33:54

Re: Parts of backend not functioning after update

Bloke wrote #308356:

#18 2017-12-19 12:34:40

Re: Parts of backend not functioning after update

etc wrote #308357:

#19 2017-12-19 12:36:28

Re: Parts of backend not functioning after update

#20 2017-12-19 12:45:21

Re: Parts of backend not functioning after update

datorhaexa wrote #308360:

#21 2017-12-19 12:47:45

Re: Parts of backend not functioning after update

Bloke wrote #308359:

datorhaexa wrote #308360:

#22 2017-12-19 12:57:36

Re: Parts of backend not functioning after update

etc wrote #308362:

#23 2017-12-19 13:37:54

Re: Parts of backend not functioning after update

#24 2017-12-19 14:05:59

Re: Parts of backend not functioning after update

etc wrote #308364:

#25 2017-12-19 16:08:16

Re: Parts of backend not functioning after update

Bloke wrote #308365:

#26 2017-12-19 16:33:21

Re: Parts of backend not functioning after update

etc wrote #308366:

#27 2017-12-19 17:01:38

Re: Parts of backend not functioning after update

philwareham wrote #308367:

#28 2017-12-19 17:05:16

Re: Parts of backend not functioning after update

etc wrote #308368:

#29 2017-12-19 17:22:59

Re: Parts of backend not functioning after update

Bloke wrote #308369:

Board footer