Textpattern CMS support forum

You are not logged in. Register | Login | Help

#41 2017-08-20 16:19:14

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,199
Website

Re: Save without losing my place?

Yes that is ok, both div and span have no semantic value so it’s ok to have empty containers of either of those.

Offline

#42 2017-08-20 23:36:46

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,723
Website

Re: Save without losing my place?

etc wrote #306685:

I mean undo after save (your point 2). Don’t know if it’s a FF or jQuery bug, but if I replace the surrounding <span class="author"> with <div class="author"> in article_partial_author, it works again. Phil, is it ok this way?

FWIW, that never worked on Firefox Mac (txp4.6 and a 4.7-dev from before the commit you allude to. Patching an up-to-date 4.7-dev the way you suggest doesn’t make it work.

(Undo after saving does work in all situations with Safari and Opera (Blink)).

PS – <div /> is marginally “better“ in this case given its default rendering as a block.

Offline

#43 2017-08-21 08:22:58

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,199
Website

Re: Save without losing my place?

OK, the latest commit changes that span to a div. Let us know if that solves the issue.

Offline

#44 2017-08-21 11:22:20

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,207

Re: Save without losing my place?

phiw13 wrote #306677:

  • it fails if (after typing) I use the mouse and press the Save button then either press the undo keyboard shortcut or use the Edit menu (textarea looses focus).

I think that’s the typical (MacOS) behaviour in every application: Only the field that has focus is the one whose contents you can undo/redo. It should undo/redo again when the field in question re-gains focus.


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#45 2017-08-21 11:59:01

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,723
Website

Re: Save without losing my place?

uli wrote #306694:

I think that’s the typical (MacOS) behaviour in every application: Only the field that has focus is the one whose contents you can undo/redo. It should undo/redo again when the field in question re-gains focus.

Nope, not in this case – Safari and Opera (Blink I assume Chrome does the same) can undo the whole time (all 3 different bullet points in my list, but particularly point 2). In Safari at least, the Undo stack applies to window context.

Offline

#46 2017-08-21 12:04:39

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,723
Website

Re: Save without losing my place?

philwareham wrote #306692:

OK, the latest commit changes that span to a div. Let us know if that solves the issue.

When creating a new article and saving, the author block is not displayed (it works fine when editing a older article, coming from the Articles panel.

I think you forgot one part: you need to change the selector line on line 428

Offline

#47 2017-08-21 12:25:54

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,199
Website

Re: Save without losing my place?

phiw13 wrote #306696:

I think you forgot one part: you need to change the selector line on line 428

Ah, OK, thanks. Just amended that.

Offline

#48 2017-08-22 07:38:21

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,723
Website

Re: Save without losing my place?

philwareham wrote #306697:

Ah, OK, thanks. Just amended that.

Right that fixes the issue I was fluffing above.

No idea if that makes Olegs undo problem work though (it doesn’t seem to work on win 10 / Firefox 55 here, but what-do-i-know I’m not a Windows user)

Offline

#49 2017-08-22 20:39:46

etc
Developer
Registered: 2010-11-11
Posts: 3,368
Website

Re: Save without losing my place?

Works for me now, thanks! When it was span, the context menu (right click on a textarea) missed Undo option after article save. A strange case.

Offline

Board footer

Powered by FluxBB