Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Save without losing my place?
Just a quick note that the latest 4.7dev has a floating ‘Save’ button in Hive themes, and no autosize in Classic theme. This should negate any problems with having to scroll up/down the page to save an article mid-edit.
Offline
Re: Save without losing my place?
It looks like some layout problem was introduced in a recent commit: the browser (FF53 W7) looses Undo option (in Body and Excerpt) on async article save.
Offline
Re: Save without losing my place?
etc wrote #306676:
It looks like some layout problem was introduced in a recent commit: the browser (FF53 W7) looses
Undooption (in Body and Excerpt) on async article save.
You mean you cannot undo what you just typed after saving the article ?
If so, that works fine here with Safari 10 and Firefox 55 and 52ESR.
EDIT: hold on, I should amend that.
- it works fine if I use the
rah_knotsextension, then the keyboard shortcut (cmd+z) to undo or use theedit menu > undoor the context menu (thetextareais the element with focus). - it fails if (after typing) I use the mouse and press the
Savebutton then either press the undo keyboard shortcut or use the Edit menu (textarealooses focus). - it works when, after saving and pressing the
Savebutton, I use the context menu inside the textarea (textarearegains focus as I click in it).
No idea if this is the normal Firefox behaviour or not, or if anything changed recently as I actually never use Firefox except for testing purposes.
Last edited by phiw13 (2017-08-20 00:44:53)
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: Save without losing my place?
I mean undo after save (your point 2). Don’t know if it’s a FF or jQuery bug, but if I replace the surrounding <span class="author"> with <div class="author"> in article_partial_author, it works again. Phil, is it ok this way?
Offline
Re: Save without losing my place?
Yes that is ok, both div and span have no semantic value so it’s ok to have empty containers of either of those.
Offline
Re: Save without losing my place?
etc wrote #306685:
I mean undo after save (your point 2). Don’t know if it’s a FF or jQuery bug, but if I replace the surrounding
<span class="author">with<div class="author">inarticle_partial_author, it works again. Phil, is it ok this way?
FWIW, that never worked on Firefox Mac (txp4.6 and a 4.7-dev from before the commit you allude to. Patching an up-to-date 4.7-dev the way you suggest doesn’t make it work.
(Undo after saving does work in all situations with Safari and Opera (Blink)).
PS – <div /> is marginally “better“ in this case given its default rendering as a block.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: Save without losing my place?
OK, the latest commit changes that span to a div. Let us know if that solves the issue.
Offline
#44 2017-08-21 11:22:20
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,306
Re: Save without losing my place?
phiw13 wrote #306677:
- it fails if (after typing) I use the mouse and press the
Savebutton then either press the undo keyboard shortcut or use the Edit menu (textarealooses focus).
I think that’s the typical (MacOS) behaviour in every application: Only the field that has focus is the one whose contents you can undo/redo. It should undo/redo again when the field in question re-gains focus.
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
Re: Save without losing my place?
uli wrote #306694:
I think that’s the typical (MacOS) behaviour in every application: Only the field that has focus is the one whose contents you can undo/redo. It should undo/redo again when the field in question re-gains focus.
Nope, not in this case – Safari and Opera (Blink I assume Chrome does the same) can undo the whole time (all 3 different bullet points in my list, but particularly point 2). In Safari at least, the Undo stack applies to window context.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: Save without losing my place?
philwareham wrote #306692:
OK, the latest commit changes that
spanto adiv. Let us know if that solves the issue.
When creating a new article and saving, the author block is not displayed (it works fine when editing a older article, coming from the Articles panel.
I think you forgot one part: you need to change the selector line on line 428
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: Save without losing my place?
phiw13 wrote #306696:
I think you forgot one part: you need to change the
selectorline on line 428
Ah, OK, thanks. Just amended that.
Offline
Re: Save without losing my place?
philwareham wrote #306697:
Ah, OK, thanks. Just amended that.
Right that fixes the issue I was fluffing above.
No idea if that makes Olegs undo problem work though (it doesn’t seem to work on win 10 / Firefox 55 here, but what-do-i-know I’m not a Windows user)
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline