Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#1177 2017-07-03 11:38:06
- jpdupont
- Member
- Registered: 2004-10-01
- Posts: 752
Re: glz_custom_fields
Happy to note that Blocke and makss follow and/or provide maintenance to this essential plugin before its integration into the core! Thank you !!!
Offline
#1178 2017-07-03 12:07:12
Re: glz_custom_fields
Please can you put topic tags of ‘textpattern’ and ‘textpattern-plugin’ on the GitHub repo to aid discoverability. Also maybe turn on the issues tab?
I’ll see if I can improve the HTML structure of this plugin in due course, so it sites better in 4.6/4.7.
Offline
#1179 2017-07-03 12:14:35
Re: glz_custom_fields
Bloke wrote #306148:
Thanks for the report. I’ve fixed it but haven’t released it as a new version yet.
OK, I‘ll give it a test tomorrow morning (it is getting late here)
Meanwhile,I had made some changes to the HTML structure for the plugin to match TXP 4.6+: Download, If you plan to release an update, can as well integrate it.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
#1180 2017-07-03 23:20:45
Re: glz_custom_fields
step 1
Installed but not activated, then patch (2 instances, per comment and comment). Save.
Activate.
Navigate to the Write panel (as I need to navigate away from the Plugins panel anyway to allow access to the Extensions menu).
There I’m greeted with a bunch of errors:
User_Error "Unknown column 'custom_11' in 'field list'"
in /Users/XXX/Sites/_txp47/textpattern/lib/txplib_db.php at line 409.
adminErrorHandler()
User_Error "Table 'txp-47.custom_fields' doesn't exist"
in /Users/XXX/Sites/_txp47/textpattern/lib/txplib_db.php at line 409.
adminErrorHandler()the latter repeated multiple times… Full log below.
Out of curiosity, I go to the Extensions panel, try creating a new custom field (text input).
User_Error "Column count doesn't match value count at row 1"
in /Users/XXX/Sites/_txp47/textpattern/lib/txplib_db.php at line 409.No go…
A couple of thoughts: it is possible that when I uninstalled the plugin before starting this test, I didn’t clean up the DB completely, or is it possible that the plugin’s lifecycle thingie is not working correctly?
Step 2.
OK, because I can. Throw away the whole DB associated with this “site” (it is a throwaway thing that only exists for this kind of testing) and start over. Set up process, etc. Login, install + patch plugin, activate, … Same story as above.
PS – regarding the changes I made to the plugin for layout compatibility with TXP 46+: First mentioned here (that download contains changes to the stylesheet), the diff mentioned in my comment above has some additional fixes (using hu and maybe some more, don’t remember).
Full log of what appears on the Write panel:
User_Error "Unknown column 'custom_11' in 'field list'"
in /Users/XXX/Sites/_txp47/textpattern/lib/txplib_db.php at line 409.
adminErrorHandler()
textpattern/lib/txplib_db.php:409 trigger_error()
textpattern/lib/txplib_db.php:1076 safe_query()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:290 getRow()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:80 glz_article_custom_fields()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:1042 glz_custom_fields_MySQL()
glz_custom_fields_replace()
textpattern/lib/txplib_misc.php:1948 call_user_func_array()
callback_event()
textpattern/lib/txplib_misc.php:2143 call_user_func_array()
User_Error "Table 'txp-47.custom_fields' doesn't exist"
in /Users/XXX/Sites/_txp47/textpattern/lib/txplib_db.php at line 409.
adminErrorHandler()
textpattern/lib/txplib_db.php:409 trigger_error()
textpattern/lib/txplib_db.php:1105 safe_query()
textpattern/lib/txplib_db.php:1220 getRows()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:186 getThings()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:72 glz_values_custom_field()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:1053 glz_custom_fields_MySQL()
glz_custom_fields_replace()
textpattern/lib/txplib_misc.php:1948 call_user_func_array()
callback_event()
User_Error "Table 'txp-47.custom_fields' doesn't exist"
in /Users/XXX/Sites/_txp47/textpattern/lib/txplib_db.php at line 409.
adminErrorHandler()
textpattern/lib/txplib_db.php:409 trigger_error()
textpattern/lib/txplib_db.php:1105 safe_query()
textpattern/lib/txplib_db.php:1220 getRows()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:186 getThings()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:72 glz_values_custom_field()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:1053 glz_custom_fields_MySQL()
glz_custom_fields_replace()
textpattern/lib/txplib_misc.php:1948 call_user_func_array()
callback_event()
User_Error "Table 'txp-47.custom_fields' doesn't exist"
in /Users/XXX/Sites/_txp47/textpattern/lib/txplib_db.php at line 409.
adminErrorHandler()
textpattern/lib/txplib_db.php:409 trigger_error()
textpattern/lib/txplib_db.php:1105 safe_query()
textpattern/lib/txplib_db.php:1220 getRows()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:186 getThings()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:72 glz_values_custom_field()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:1053 glz_custom_fields_MySQL()
glz_custom_fields_replace()
textpattern/lib/txplib_misc.php:1948 call_user_func_array()
callback_event()
User_Error "Table 'txp-47.custom_fields' doesn't exist"
in /Users/XXX/Sites/_txp47/textpattern/lib/txplib_db.php at line 409.
adminErrorHandler()
textpattern/lib/txplib_db.php:409 trigger_error()
textpattern/lib/txplib_db.php:1105 safe_query()
textpattern/lib/txplib_db.php:1220 getRows()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:186 getThings()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:72 glz_values_custom_field()
textpattern/lib/txplib_misc.php(1835) : eval()'d code:1053 glz_custom_fields_MySQL()
glz_custom_fields_replace()
textpattern/lib/txplib_misc.php:1948 call_user_func_array()
callback_event()Last edited by phiw13 (2017-07-03 23:26:19)
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
#1181 2017-07-04 09:11:39
Re: glz_custom_fields
Ummm, I screwed up the fix. Dropped a quote by accident ? That’ll teach me to commit without testing.
Do things improve if you use a version that doesn’t have syntax errors in the SQL call?
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Online
#1182 2017-07-04 09:15:10
Re: glz_custom_fields
Bloke wrote #306174:
Ummm, I screwed up the fix. Dropped a quote by accident ? That’ll teach me to commit without testing.
Do things improve if you use a version that doesn’t have syntax errors in the SQL call?
Nope :-( I had seen makss comment and made sure the quote was there.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
#1183 2017-07-04 09:44:09
Re: glz_custom_fields
Dammit, I’ll have to investigate this. Could be a lifecycle issue. I’ll need to set up a test environment, popualte it with CFs and content, then upgrade the plugin and catch the fallout.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Online
#1184 2017-07-23 08:20:32
Re: glz_custom_fields
Just an additional note related to this plugin, when using txp 4.7-dev. I was trying to use “smd_where_used” plugin today. smd_where_used gave me the following error:
User_Error "Unknown column 'custom_11' in 'where clause'"
in /Users/xxxx/Sites/yyyy/textpattern/lib/txplib_db.php at line 409.Turns out there where still some remnants of those custom_11 (and higher) fields, despite having completely uninstalled the plugin (and checked through the DB…). smd_where_used had at one point indexed the whole thing, and remembered those fields. I found it with the help of SequelPro, in the txp_prefs table, the smd_wu_article_fields field.
(sidenote: does uninstalling a plugin such as smd_where_used clear out the prefs for that plugin from the DB? I tried it and that did not happen on my TXP4.7-dev. IOW, the plugin prefs remained listed in the DB).
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
#1185 2017-07-23 18:47:30
Re: glz_custom_fields
phiw13 wrote #306393:
sidenote: does uninstalling a plugin such as
smd_where_usedclear out the prefs for that plugin from the DB?
Probably not. I should look into doing that.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Online
#1186 2017-07-23 22:35:36
Re: glz_custom_fields
Bloke wrote #306403:
Probably not. I should look into doing that.
Yeah, that would be neat :-) (I uninstalled then reinstalled to see if it fixed my problem, when that failed I dived directly in the DB).
TA.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
#1187 2017-07-26 11:24:10
Re: glz_custom_fields
Bloke wrote #303945:
Try version 1.5.0-beta.1. Should fix any MySQL/4.6.2 issues. Please let me know otherwise.
Trying that version on a new install of 4.6.2, any precautions i should take? Thank you in advance!
A hole turned upside down is a dome, when there’s also gravity.
Offline
#1188 2017-07-26 11:50:50
Re: glz_custom_fields
jayrope wrote #306460:
Trying that version on a new install of 4.6.2, any precautions i should take? Thank you in advance!
Unless you roll in the changes made since that beta was released (at the very least this one), then you may have problems with key lengths. The prefs_id and ‘disabled’ fields issues probably won’t affect you, as they’re 4.7.0-dev things.
If it’s a new install, should be fine. If it’s an upgrade… backup, backup, backup.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Online