Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#2401 2017-01-31 15:33:05
Re: MLP - The Multi-Lingual Publishing Pack
spiridon wrote #303764:
I will fix the problems you have discovered. But in the case of a new release it would be nice to notify me in advance so I had time to check and adapt the plugin.
Awesome, thank you! Consider it done.
I fixed a few more minor issues last night (see my 4.6 branch) and was about to fix a glaring oversight in _l10n_sync_table_definitions (basically, if a new column is discovered it’s currently appended to the rendition table, but it needs to be added AFTER a particular column). But your approach of using Views neatly sidesteps all of that.
I have a database dump of Kjeld’s site (see above post) with 750 articles in it, across three languages. I’m going to reset my demo environment to my version of MLP, load his data in and make sure everything’s “working” as best as it can. Then, at some point, I’ll try upgrading to your version of MLP and check all the Views get populated with the existing rendition data. It’ll be a great test because it represents a real site.
There is one more issue that I think is a core problem, but it seriously affects MLP. I’ll talk to you about that offline because you might be able to shed some light on it where Oleg and I have been unable to make traction.
which is the easiest way to contact you, in addition to the forum?
Drop me a line via my website contact form and I’ll get back to you that way. Thanks.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
#2402 2017-02-03 02:27:32
Re: MLP - The Multi-Lingual Publishing Pack
spiridon wrote #303766:
Thank you very much, Spiridon. Unfortunately, I had already upgraded by the time I posted my request for help. So the process in the link was not applicable anymore.
Thanks to indefatigable assistance from Bloke, the problems have now been solved.
• Old Photos of Japan – Japan in the 1850s~1960s (100% txp)
• MeijiShowa – Stock photos of Japan in the 1850s~1960s (100% txp)
• JapaneseStreets.com – Japanese street fashion (mostly txp)
Offline
#2403 2017-02-06 19:05:07
Re: MLP - The Multi-Lingual Publishing Pack
Per Bloke’s recommendation, I’m testing Spiridon’s fork on a testing replica of my site, but I’m getting a fatal error in Textpattern:
Cannot redeclare get_prefs() (previously declared in /var/www/public/textpattern/lib/txplib_misc.php:4723) in /var/www/public/textpattern/lib/txplib_db.php on line 644
I see that the function is indeed declared in both files, and I’m diffing the get_prefs() functions next, but I just wanted to check if this is a known issue with a known fix?
Last edited by johnstephens (2017-02-06 19:05:37)
Offline
#2404 2017-02-06 19:14:44
Re: MLP - The Multi-Lingual Publishing Pack
Should I delete the get_prefs() function in txplib_misc.php?
Edit: The answer to that would be “no”. The fatal error goes away, but then none of Textpattern’s admin panels load except for the Plugins panel.
Last edited by johnstephens (2017-02-06 19:23:21)
Offline
#2405 2017-02-06 22:36:29
Re: MLP - The Multi-Lingual Publishing Pack
johnstephens wrote #303857:
I see that the function is indeed declared in both files, and I’m diffing the
get_prefs()functions next, but I just wanted to check if this is a known issue with a known fix?
Are you using the v4.6.0.tables2views branch? That should have no get_prefs() function in txplib_db.php. The master branch is the old one that’s compatible (ahem, well, comparatively so) with 4.5.7, not 4.6.0+.
If you are trying the more recent branch then I’m not sure what’s going on. The txplib_db.php file there doesn’t appear to have that function in it.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
#2406 2017-02-07 01:03:22
Re: MLP - The Multi-Lingual Publishing Pack
Gah! I cloned master, not v4.6.0.tables2views. Will try again. Thank you!
Offline
#2407 2017-02-08 13:16:53
Re: MLP - The Multi-Lingual Publishing Pack
So I followed the steps for upgrading MLP and everything appears to be fine and dashing! Thanks!
But … one more problem with zem_contact. As soon as I installed the zem_contact_lang-mlp.php provided with the new version, clean URLs stopped working, and the site disappeared with the
Fatal error: Cannot redeclare zem_crl_enumerate_strings() (previously declared in /home/***/public_html/subdomain_textpattern/textpattern/lib/txplib_misc.php(1782) : eval()'d code:56) in /home/***/public_html/subdomain_textpattern/textpattern/lib/txplib_misc.php(1782) : eval()'d code on line 67
Any ideas?
Sth. strange I noted: on one installation of MLP, the help function of both plugins will show unformatted text …?
Offline
#2408 2017-02-08 15:36:57
Re: MLP - The Multi-Lingual Publishing Pack
Ups. I still don’t have a way to enter section titles for any but the default language, do I?
Offline
#2409 2017-02-09 22:12:23
Re: MLP - The Multi-Lingual Publishing Pack
I haven’t thoroughly tested every aspect of Spiridon’s fork (v4.6.0.tables2views branch), but by and large it seems to be working. I do see this error popping up when the site is in Debug mode:
General error Notice: Undefined index: l10n_l10n-url_default_lang_marker on line 472
_l10n_textpattern_comment_submit()
textpattern/lib/txplib_misc.php:1895 call_user_func_array()
textpattern/publish.php:548 callback_event()
index.php:105 textpattern()
Has this been reported and rebuffed already? What is the terror threat level relating to this notice?
Offline
#2410 2017-02-10 09:11:07
Re: MLP - The Multi-Lingual Publishing Pack
johnstephens wrote #303928:
Has this been reported and rebuffed already?
I fixed it in my 4.6.0 branch but I don’t think Spiridon has rolled that change in his. Maybe file an issue there and point him at my fix so he can apply the same? It’s not a deal-breaker and, as far as I can tell, the plugin will still function okay.
Thanks for testing Spiridon’s branch, btw. Brilliant news that it works well, as it’s definitely the way forward for MLP until core catches up and gets built-in language support.
Last edited by Bloke (2017-02-10 09:13:25)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
#2411 2017-02-16 18:48:32
Re: MLP - The Multi-Lingual Publishing Pack
Thank you, Stef! I fixed it in my local installation and the errors went away. But Spiridon’s repository doesn’t seem to have an “Issues” tab to file this.
Offline
#2412 2017-02-23 11:55:23
Re: MLP - The Multi-Lingual Publishing Pack
I am sorry. I fixed l10n.php in my branch v4.6.0.tables2views
Offline