Textpattern CMS support forum

You are not logged in. Register | Login | Help

#11 2016-08-09 13:13:14

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,215
Website

Re: “Collapse all” button on Pages / Forms / Write panels

Just a note that I’ve added aria-controls to the expand/collapse links now, for accessibility. That necessitates an extra div within the tag builder HTML structure too.

Offline

#12 2016-08-09 13:17:53

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,826
Website

Re: “Collapse all” button on Pages / Forms / Write panels

philwareham wrote #300564:

Just a note that I’ve added aria-controls to the expand/collapse links now, for accessibility. That necessitates an extra div within the tag builder HTML structure too.

No worries. I’ll see what I can do.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#13 2016-08-09 14:44:06

Destry
Moderator
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,291
Website

Re: “Collapse all” button on Pages / Forms / Write panels

philwareham wrote #300556:

How about this?

+1


Wordworkin’ for you.

Offline

#14 2016-08-09 21:01:30

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,826
Website

Re: “Collapse all” button on Pages / Forms / Write panels

Done on the Forms panel. Please test. Language strings expand_all and collapse_all will need adding. Next stop: Write panel.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#15 2016-08-09 21:07:02

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,826
Website

Re: “Collapse all” button on Pages / Forms / Write panels

Quick question about the Write panel: the Sort and display area is not collapsible. Having expand/collapse buttons at the top that do not affect this box might seem a little weird.

We have traditionally assumed the box is fundamentally important, hence its permanently-open nature, but in the interests of implementing this toggle feature, should the box be made collapsible, in keeping with the others?


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#16 2016-08-09 21:33:41

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,826
Website

Re: “Collapse all” button on Pages / Forms / Write panels

And done on the Write panel too, notwithstanding the issue mentioned in my previous post.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#17 2016-08-09 22:13:22

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,215
Website

Re: “Collapse all” button on Pages / Forms / Write panels

I guess the sort and display could be a collapsible too. I would suggest, if possible, that on a clean install that twisty is set to expanded initially.

Offline

#18 2016-08-09 23:40:37

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,753
Website

Re: “Collapse all” button on Pages / Forms / Write panels

Bloke wrote #300576:

And done on the Write panel too, notwithstanding the issue mentioned in my previous post.

Thanks! It works great on both panels. Happy editing with the option of less visual clutter and faster keyboard access all around; screen readers users should be happy as well :-)

Offline

#19 2016-08-09 23:46:11

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,753
Website

Re: “Collapse all” button on Pages / Forms / Write panels

philwareham wrote #300577:

I guess the sort and display could be a collapsible too. I would suggest, if possible, that on a clean install that twisty is set to expanded initially.

I would tend to agree. Ideally —but that would require a bit of complex logic I suspect — the sort and Display panel could be always expanded when starting a new article.

Offline

#20 2016-08-10 14:50:07

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,826
Website

Re: “Collapse all” button on Pages / Forms / Write panels

philwareham wrote #300577:

I guess the sort and display could be a collapsible too… on a clean install that twisty is set to expanded initially.

phiw13 wrote #300579:

the sort and Display panel could be always expanded when starting a new article.

Both good suggestions, neither particularly simple to implement, though phiw13’s is the easier of the two, albeit breaking the user’s selection and requiring an exception to the “is this visible or not?” logic.

Another possibility is to move the expand/collapse links below the Sort and display block. Would that look pants?


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

Board footer

Powered by FluxBB