Plugins broken in 4.6

uli · 2016-05-07 14:13:19

Edit: Aside from restructured admin HTML, there are some code changes in Textpattern 4.6 that might lead to misbehaving plugins. Some nice people (Bloke, ruud and michaelkpate) have set up forum posts in order to bring possible plugin issues to your attention and offer fixes for those. Here’s the list of these postings:

Tag registering 1 (basic examples)
Tag registering 2 (advanced examples)
NULLDATETIME
Converting plugins to mysqli

——————— ORIGINAL POST ———————

esq_sectionsort

Broken feature: Sorting of categories

Can be fixed with:

Find

#category_container .category-tree > .categorysort:first-child {

Replace by

#category_article_form > .categorysort:first-child,
#category_image_form > .categorysort:first-child,
#category_file_form > .categorysort:first-child,
#category_link_form > .categorysort:first-child {

________________________________________________________________________________________

Find

#category_container .category-tree p .handle {

Replace by

#category_article_form p .handle,
#category_image_form p .handle,
#category_file_form p .handle,
#category_link_form p .handle {

________________________________________________________________________________________

Find

$('#category_container .category-tree').each(function() {

Replace by

$('#category_article_form,
#category_image_form,
#category_file_form,
#category_link_form').each(function() {

________________________________________________________________________________________

Some cosmetics:

Find second instance of

set_message('Section order saved OK', 'success')

Replace by

set_message('Category order saved OK', 'success')

________________________________________________________________________________________

Find second instance of

set_message('Section order save failed', 'error');

Replace by

set_message('Category order save failed', 'error');

________________________________________________________________________________________

Remove

.css('table-layout', 'fixed')

(Keeps the section table from shrinking in 4.6 when toggling “Show details”.)

________________________________________________________________________________________

Find

$('#section_container thead tr').prepend('<th style="width: 30px;">Sort</th>').find('th').each(function() {

Replace by

$('.txp-list th').removeClass('asc').removeClass('desc');
$('#section_container thead tr').prepend('<th style="width: 30px;">Sort</th>').find('th').each(function() {

(Removes the classes for chosen table sorting column headers in the Sections panel. You can’t sort that table, when the plugin is installed.)

Edit: Added the last two cosmetic fixes.

Last edited by uli (2016-12-02 19:11:18)

uli · 2016-05-07 14:27:52

stm_article_order

Broken feature:
Completely broken

Can be fixed with:
Hopefully: some compatibility changes to adapt the plugin to Textpattern 4.6’s current jQuery version (v1.12.3). It works again as soon as Textpattern 4.5.7’s jQuery v1.8.3 is used in /textpattern/lib/txplib_head.php

~~If you know what changes need to be done, please post here. Thanks.~~ done

Last edited by uli (2016-12-02 19:10:16)

Bloke · 2016-05-09 09:57:46

[stm_article_order] If you know what changes need to be done, please post here.

The primary issue is that jQuery.browser no longer exists so browser detection is out. Trawl the code for any mention of jQuery.browser and remove / replace it. List of possible fixes are below. Note that ones marked with an asterisk may potentially break Opera, so require testing.

Lines 390 + 391: remove check for Opera*

x += el.offsetLeft + (el.currentStyle ?parseInt(el.currentStyle.borderLeftWidth)||0:0);
y += el.offsetTop + (el.currentStyle ?parseInt(el.currentStyle.borderTopWidth)||0:0);

Lines 619, 677, and 1056: remove reference to jQuery.browser.msie and use a different IE-specific check (does it support ActiveX)

if(window.ActiveXObject) {

Lines 752 + 753: remove reference to jQuery.browser.msie and Opera-specific test*

elm.dragCfg.oC.x = elm.offsetLeft + (window.ActiveXObject ? 0 : parentBorders.l);
elm.dragCfg.oC.y = elm.offsetTop + (window.ActiveXObject ? 0 : parentBorders.t);

That at least allows dragging again, but as I say, there are Opera-specific tests that have been removed, which may need to be addressed with some clever tests. With luck, the tests may not be required any more since Opera changed their rendering engine. Whether there’s anything more that needs fixing after that remains to be seen.

uli · 2016-05-09 13:48:45

Ah, Stef, thanks! That brought it back to life. During the weekend I’ve tried to follow some blog tips but only tore my hair, so I ended up dropping in the migrate plugin, for the cost of yet another 10kb. Much better now!

Need to align some changes with the stm_ao-migrate version now and see what happened with the GIF/PNG part that got lost somewhere (not contained in v0.3). And throw in again Claire/cbe’s change, and then it’s ready for some nice folks that want try the mangy beast, esp. on Opera.

jpdupont · 2016-06-03 16:56:16

What about Jukka plugins ?

rah_knots and
rah_post_versions

don’t works well.

rak_knots = save only on the write tab (not on page or form)
rah_post_version = many mysql errors.

uli · 2016-06-03 17:31:22

jpdupont wrote #299489:

rah_knots

That’s an easy “fix” (if it’s not that way by design):

Look for (2 x)

$('form .publish')

Replace by (2 x)

$('form .publish, #page-form .publish, #page-page .publish, #page-css .publish')

rah_post_versions

IIRC Jukka has announced to drop support for that plugin some years ago. Personally, I’ve regretted that and I still do. I hope someone wants to fix that plugin and make it available to the community.

jpdupont · 2016-06-04 07:48:48

@uli

I don’t know if it’s really correct but this modification seems to work :

$setid = safe_insert(
	'rah_post_versions_sets',
	"modified=now(),
	changes=1,
	title='".doSlash($title)."',
	event='".doSlash($event)."',
	step='".doSlash($step)."',
	grid='".doSlash($grid)."'"
	);
	// $setid =  mysql_insert_id();

Move the $setid = before the safe_insert ... and comment the $setid = mysql_insert_id();

uli · 2016-06-04 15:26:40

Hi, Jean-Pol, that’s a good one, thanks! My most important fields are working (forms, pages, CSS). Except for article, which will become the most important one once the website is handed over to the clients. Did article save ever work in rah_post_versions after the move to AJAX saving? (Very likely I didn’t use it any more because of that but I really can’t remember.)

I’ve a vague feeling it might simply be the the ident code for article in the plugin preferences:

	case "article":
		$grid = rah_post_versions_id();
		$title = gps("Title");
	break;

But I’ve no idea what to change about that.

jpdupont · 2016-06-04 16:36:53

Yes.
maybee in this list article:edit, article:create, article:publish, article:save, because it seems the event is not fired for article.

GugUser · 2016-06-04 20:45:16

uli wrote #299519:

Did article save ever work in rah_post_versions after the move to AJAX saving?

No, only the first time when it was published.

Last edited by GugUser (2016-06-05 02:41:58)

GugUser · 2016-06-05 02:32:18

uli wrote #299491:

That’s an easy “fix” (if it’s not that way by design)

With your easy fix it works on my 4.6 beta installation.

Where could be published the new version?

Here the code:

# Name: rah_knots v0.2.1 
# Type: Admin plugin
# Command+Save editors
# Author: Jukka Svahn
# URL: http://rahforum.biz
# Recommended load order: 5

# .....................................................................
# This is a plugin for Textpattern CMS - http://textpattern.com/
# To install: textpattern > admin > plugins
# Paste the following text into the 'Install plugin' box:
# .....................................................................

YToxMTp7czo0OiJuYW1lIjtzOjk6InJhaF9rbm90cyI7czo2OiJhdXRob3IiO3M6MTE6Ikp1
a2thIFN2YWhuIjtzOjEwOiJhdXRob3JfdXJpIjtzOjE5OiJodHRwOi8vcmFoZm9ydW0uYml6
IjtzOjc6InZlcnNpb24iO3M6NToiMC4yLjEiO3M6MTE6ImRlc2NyaXB0aW9uIjtzOjIwOiJD
b21tYW5kK1NhdmUgZWRpdG9ycyI7czo0OiJjb2RlIjtzOjIyNzQ6Ii8qKg0KICogcmFoX2tu
b3RzIHBsdWdpbiBmb3IgVGV4dHBhdHRlcm4gQ01TLg0KICoNCiAqIEBhdXRob3IgIEp1a2th
IFN2YWhuDQogKiBAY2hhbmdlZCBUZXh0cGF0dGVybiA0LjYgY29tcGF0aWJpbGl0eSBieSB1
bGkNCiAqIEBkYXRlICAgIDIwMTYtMDYtMDQNCiAqIEBsaWNlbnNlIEdOVSBHUEx2Mg0KICog
QGxpbmsgICAgaHR0cHM6Ly9naXRodWIuY29tL2dvY29tL3JhaF9rbm90cw0KICoNCiAqIENv
cHlyaWdodCAoQykgMjAxMiBKdWtrYSBTdmFobiBodHRwOi8vcmFoZm9ydW0uYml6DQogKiBM
aWNlbnNlZCB1bmRlciBHTlUgR2VucmFsIFB1YmxpYyBMaWNlbnNlIHZlcnNpb24gMg0KICog
aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzL2dwbC0yLjAuaHRtbA0KICovDQoNCgluZXcg
cmFoX2tub3RzKCk7DQoNCi8qKg0KICogVGhlIHBsdWdpbiBjbGFzcy4NCiAqLw0KDQpjbGFz
cyByYWhfa25vdHMNCnsNCgkvKioNCgkgKiBDb25zdHJ1Y3Rvci4NCgkgKi8NCg0KCXB1Ymxp
YyBmdW5jdGlvbiBfX2NvbnN0cnVjdCgpDQoJew0KCQlyZWdpc3Rlcl9jYWxsYmFjayhhcnJh
eSgkdGhpcywgJ3N0eWxlcycpLCAnYWRtaW5fc2lkZScsICdoZWFkX2VuZCcpOw0KCQlyZWdp
c3Rlcl9jYWxsYmFjayhhcnJheSgkdGhpcywgJ2phdmFzY3JpcHQnKSwgJ2FkbWluX3NpZGUn
LCAnaGVhZF9lbmQnKTsNCgl9DQoNCgkvKioNCgkgKiBTdHlsZXMuDQoJICovDQoNCglwdWJs
aWMgZnVuY3Rpb24gc3R5bGVzKCkNCgl7DQoJCWVjaG8gPDw8RU9GDQoJCQk8c3R5bGUgdHlw
ZT0idGV4dC9jc3MiPg0KCQkJCS5yYWhfa25vdHNfdGlwDQoJCQkJew0KCQkJCQl2aXNpYmls
aXR5OiBoaWRkZW47DQoJCQkJfQ0KCQkJPC9zdHlsZT4NCkVPRjsNCgl9DQoNCgkvKioNCgkg
KiBJbml0aWFsaXplcyB0aGUgSmF2YVNjcmlwdC4NCgkgKi8NCg0KCXB1YmxpYyBmdW5jdGlv
biBqYXZhc2NyaXB0KCkNCgl7DQoJCSRqcyA9IDw8PEVPRg0KCQkJKGZ1bmN0aW9uKCkgew0K
CQkJCSQoZG9jdW1lbnQpLnJlYWR5KGZ1bmN0aW9uKCkgew0KCQkJCQl2YXIgdGlwVGV4dCA9
ICdDVFJMK1MnOw0KDQoJCQkJCWlmIChuYXZpZ2F0b3IudXNlckFnZW50LmluZGV4T2YoJ01h
YyBPUyBYJykgIT09IC0xKQ0KCQkJCQl7DQoJCQkJCQl0aXBUZXh0ID0gJyYjODk4NDsrUyc7
DQoJCQkJCX0NCg0KCQkJCQkkKCdmb3JtIC5wdWJsaXNoLCAjcGFnZS1mb3JtIC5wdWJsaXNo
LCAjcGFnZS1wYWdlIC5wdWJsaXNoLCAjcGFnZS1jc3MgLnB1Ymxpc2gnKQ0KCQkJCQkJLmFm
dGVyKCcgPHNtYWxsIGNsYXNzPSJyYWhfa25vdHNfdGlwIGluZm9ybWF0aW9uIj4nK3RpcFRl
eHQrJzwvc21hbGw+ICcpDQoJCQkJCQkuaG92ZXIoDQoJCQkJCQkJZnVuY3Rpb24oKSB7DQoJ
CQkJCQkJCSQodGhpcykuc2libGluZ3MoJy5yYWhfa25vdHNfdGlwJykNCgkJCQkJCQkJCS5j
c3MoJ29wYWNpdHknLCAwKQ0KCQkJCQkJCQkJLmNzcygndmlzaWJpbGl0eScsICd2aXNpYmxl
JykNCgkJCQkJCQkJCS5mYWRlVG8oNjAwLCAxKTsNCgkJCQkJCQl9LA0KCQkJCQkJCWZ1bmN0
aW9uKCkgew0KCQkJCQkJCQkkKHRoaXMpLnNpYmxpbmdzKCcucmFoX2tub3RzX3RpcCcpDQoJ
CQkJCQkJCQkuZmFkZVRvKDMwMCwgMCwgZnVuY3Rpb24oKSB7DQoJCQkJCQkJCQkJJCh0aGlz
KS5jc3MoJ3Zpc2liaWxpdHknLCAnaGlkZGVuJyk7DQoJCQkJCQkJCQl9KTsNCgkJCQkJCQl9
DQoJCQkJCQkpDQoJCQkJCQkuY2xpY2soZnVuY3Rpb24oKSB7DQoJCQkJCQkJJCh0aGlzKS5z
aWJsaW5ncygnLnJhaF9rbm90c190aXAnKQ0KCQkJCQkJCQkuY3NzKCdvcGFjaXR5JywgMCkN
CgkJCQkJCQkJLmNzcygndmlzaWJpbGl0eScsICdoaWRkZW4nKTsNCgkJCQkJCX0pOw0KCQkJ
CX0pOw0KDQoJCQkJJCh3aW5kb3cpLmtleWRvd24oZnVuY3Rpb24oZSkgew0KCQkJCQlpZiAo
ZS53aGljaCA9PT0gMTkgfHwgKFN0cmluZy5mcm9tQ2hhckNvZGUoZS53aGljaCkudG9Mb3dl
ckNhc2UoKSA9PT0gJ3MnICYmIChlLm1ldGFLZXkgfHwgZS5jdHJsS2V5KSkpDQoJCQkJCXsN
CgkJCQkJCXZhciBvYmogPSAkKCdmb3JtIC5wdWJsaXNoLCAjcGFnZS1mb3JtIC5wdWJsaXNo
LCAjcGFnZS1wYWdlIC5wdWJsaXNoLCAjcGFnZS1jc3MgLnB1Ymxpc2gnKTsNCgkJCQkJCWlm
IChvYmoubGVuZ3RoKQ0KCQkJCQkJew0KCQkJCQkJCWUucHJldmVudERlZmF1bHQoKTsNCgkJ
CQkJCQlvYmouZXEoMCkuY2xpY2soKTsNCgkJCQkJCX0NCgkJCQkJfQ0KCQkJCX0pOw0KCQkJ
fSkoKTsNCkVPRjsNCg0KCQllY2hvIHNjcmlwdF9qcygkanMpOw0KCX0NCn0NCiI7czo0OiJ0
eXBlIjtzOjE6IjMiO3M6NToib3JkZXIiO3M6MToiNSI7czo1OiJmbGFncyI7czoxOiIwIjtz
OjQ6ImhlbHAiO3M6MTA3MDoiPGgxPnJhaF9rbm90czwvaDE+CgoJPHA+PGEgaHJlZj0iaHR0
cDovL3R3aXR0ZXIuY29tL2dvY29tIiByZWw9Im5vZm9sbG93Ij5Ud2l0dGVyPC9hPiB8IDxh
IGhyZWY9Imh0dHBzOi8vZ2l0aHViLmNvbS9nb2NvbS9yYWhfa25vdHMiIHJlbD0ibm9mb2xs
b3ciPkdpdEh1YjwvYT4gfCA8YSBocmVmPSJodHRwOi8vcmFoZm9ydW0uYml6L2RvbmF0ZS9y
YWhfa25vdHMiIHJlbD0ibm9mb2xsb3ciPkRvbmF0ZTwvYT48L3A+CgoJPHA+U2F2ZSA8YSBo
cmVmPSJodHRwOi8vdGV4dHBhdHRlcm4uY29tIiByZWw9Im5vZm9sbG93Ij5UZXh0cGF0dGVy
biBDTVMmIzgyMTY7PC9hPiBlZGl0b3JzIHdpdGggdHdvIGZhbWlsaWFyIGtleWJvYXJkIHNo
b3J0Y3V0cywgQ29tbWFuZCtTIGFuZCBDVFJMK1MuPC9wPgoKCTxoMj5Ub29sc2hlZCBub3Rp
Y2U8L2gyPgoKCTxwPlRoaXMgaXMgYSB0b29sc2hlZCBwcm9qZWN0LiBFeHBlcmltZW50YWwg
YW5kIG5vdCBwYXJ0IG9mIHRoZSBtYWluIHN1cHBvcnRlZCBwcm9kdWN0IGxpbmUgb2YgUmFo
LiBOb3QgeWV0IGF0IGxlYXN0LiBQbGVhc2UgdXNlIGF0IHlvdXIgb3duIHJpc2suPC9wPgoK
CTxoMj5DaGFuZ2Vsb2c8L2gyPgoKCTxoMz5WZXJzaW9uIDAuMi4xICYjODIxMTsgMjAxNi8w
Ni8wNDwvaDM+CgoJPHVsPgoJCTxsaT5GaXhlZDogQ29tcGF0aWJpbGl0eSBmb3IgVGV4dHBh
dHRlcm4gNC42IGJ5IDxzdHJvbmc+dWxpPC9zdHJvbmc+PC9saT4KCTwvdWw+CgoJPGgzPlZl
cnNpb24gMC4yICYjODIxMTsgMjAxMi8xMS8wNDwvaDM+CgoJPHVsPgoJCTxsaT5GaXhlZDog
VGhlIHRpcCBsYWJlbCB3b3JrcyB3aXRoIG11bHRpcGxlIHNpYmxpbmdzLjwvbGk+CgkJPGxp
PkNoYW5nZWQ6IFJlc2VydmUgc3BhY2UgZm9yIHRoZSB0aXAgbGFiZWwgaW5zdGVhZCBvZiBv
dmVybGF5aW5nIGNvbnRlbnQuPC9saT4KCQk8bGk+Q2hhbmdlZDogSGlkZSB0aGUgdGlwIGxh
YmVsIG9uIGJ1dHRvbiBjbGljay48L2xpPgoJPC91bD4KCgk8aDM+VmVyc2lvbiAwLjEgJiM4
MjExOyAyMDEyLzA4LzMwPC9oMz4KCgk8dWw+CgkJPGxpPkluaXRpYWwgcmVsZWFzZS48L2xp
PgoJPC91bD4iO3M6MzoibWQ1IjtzOjMyOiIyOTU2MTA5OThmZDhhNzgwZDMwZTJmNzU2NmEw
Zjk2OCI7fQ==

Last edited by GugUser (2016-06-19 19:01:34)

GugUser · 2016-06-05 02:35:50

uli wrote #299034:

Ah, Stef, thanks! That brought it back to life. During the weekend I’ve tried to follow some blog tips but only tore my hair, so I ended up dropping in the migrate plugin, for the cost of yet another 10kb. Much better now!

Need to align some changes with the stm_ao-migrate version now and see what happened with the GIF/PNG part that got lost somewhere (not contained in v0.3). And throw in again Claire/cbe’s change, and then it’s ready for some nice folks that want try the mangy beast, esp. on Opera.

Do you work on this?

Textpattern CMS

Textpattern CMS support forum

#1 2016-05-07 14:13:19