The 'Compensate for persistent connection mod_deflate bug?' preference

gaekwad · 2016-04-14 14:39:33

I’ve been tweaking some of the pophelp docs and something crossed my mind:

Compensate for persistent connection mod_deflate bug?

It’s in Preferences. I’ve never touched it in 100+ Textpattern installs. I dug deeper and found that the original appears to be an obscure bug from ~2005 – info here – and I’m not sure if it’s still relevant.

With the absence of any more useful info, how relevant is this for Textpattern over a decade after the bug was reported? I have the burden of knowledge, but to me this implies Textpattern is perhaps still harking back a decade – which doesn’t seem appropriate.

Is anyone able to test to see if this is still an issue with supported Apache versions?

If it’s long-since fixed, I propose the preference option be remove from 4.7 and the workaround code removed from a version after that.

Bloke · 2016-04-14 15:23:44

Never used it. I presume the bug is long since eradicated.

Is this the same bug? Comments as recent as 2015 say this particular issue is still around, but I’m not convinced it’s the same thing. If not, I’d say we ditch the pref.

gaekwad · 2016-04-14 16:13:11

I don’t think it’s the same thing, no mention of binary leakage in that SO thread.

I say I don’t think it’s the same thing as it’s all a bit…vague overall.

philwareham · 2016-04-14 16:20:29

it is discussed a bit here – it was obscure even at the time from what I can gather there, we should get rid of this pref IMHO.

Bloke · 2016-04-15 08:25:15

If nobody else chimes in with a reason to keep it by Sunday, let’s ditch it. Only a handful of lines of code to remove and one to add in _to_4.6.0.php to remove the pref for upgraders. Easy win.

gaekwad · 2016-04-18 13:15:50

Bloke wrote #298627:

If nobody else chimes in with a reason to keep it by Sunday, let’s ditch it.

Today’s Monday. Let’s ditch it.

Bloke · 2016-04-18 13:48:30

gaekwad wrote #298658:

Today’s Monday. Let’s ditch it.

Byyeeeeeeeeee.

Textpattern CMS

Textpattern CMS support forum

#1 2016-04-14 14:39:33