Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2015-11-13 21:41:06

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,306

Re: Admin layout update patch

philwareham wrote #296591:

OK, I think I’ve fixed that page width problem now.

phiw13’s fixes also made my two observations from earlier today irrelevant.


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#14 2015-11-13 22:07:45

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: Admin layout update patch

Actually Uli that is still relevant – prefs heading will be moved in due course to prevent breakage with long wording.

Offline

#15 2015-11-14 00:19:46

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,188
Website

Re: Admin layout update patch

philwareham wrote #296591:

OK, I think I’ve fixed that page width problem now. Thanks for the report and tips.

OK, using width: 100% is another solution indeed.

Unrelated, but did you test your sticky footer code IE 11 and older? As is, it won’t work (Philip Walton recommends using height instead of min-height), but even with that set, I had tons of issues in IE 11 last time I used that code on an different project (the flexible box (.txp-body here collapsed…).

For my Sandspace admin theme (where I can’t use height, and some additional issue IIRC, been a long while since I implemented that), is just hide the whole thing from IE 11:

@supports (display: flex) {
  body { display: flex; )
  /* etc */
 }

no need to bother with prefixes as [1] IE 10/11 won’t see that code and [2] Safari 8 won’t see it either. No sticky footer for them.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#16 2015-11-14 00:25:00

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,188
Website

Re: Admin layout update patch

While I’m around, a minor request:

On the refurbished “Edit Images” panel, could you add a .txp-save class on the p surround the “Save” button — that would be consistent with the Write, Pages, Forms panels. TIA (no hurry, if you’re bored at some point).

(bit sad that the textarea becomes so smallish on larger screens, BTW)


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#17 2015-11-14 08:33:22

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: Admin layout update patch

phiw13 wrote #296601:

On the refurbished “Edit Images” panel, could you add a .txp-save class on the p surround the “Save” button…

Done, thanks.

(bit sad that the textarea becomes so smallish on larger screens, BTW)

Do you mean the textarea height? If so, I am testing out JavaScript that expands the height to fit the amount of content within.

Unrelated, but did you test your sticky footer code IE 11 and older?

No, I’ve not tested in IE10/IE11 for a while, I will do when I get a chance.

Offline

#18 2015-11-14 08:41:25

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,188
Website

Re: Admin layout update patch

philwareham wrote #296607:

Do you mean the textarea height? If so, I am testing out JavaScript that expands the height to fit the amount of content within.

I mean the overall size. On other edit panels you’ve got those pretty large textareas, whereas on the Image edit panel, the textarea sits in a narrowish column (and it is one place where more text might be expected. For Sandspace theme, I’m thinking to change the width of both columns (65% – 35% instead of 75%-25%).

I’m not freaky about those JS thingies.

Thanks for the .txp-save class.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#19 2015-11-14 08:59:46

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: Admin layout update patch

It’s the same size as meta description textarea on write panel, I don’t foresee users writing massive captions for images really.

Offline

#20 2015-11-14 10:13:14

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: Admin layout update patch

One more thing: I get a blank page (with the txp-footer only) when I click the Create new article button under the Articles tab. It takes me to: http://localhost:8888/txp_master/textpattern/index.php?event=article&step=article_edit


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#21 2015-11-14 11:18:18

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,188
Website

Re: Admin layout update patch

philwareham wrote #296609:

It’s the same size as meta description textarea on write panel, I don’t foresee users writing massive captions for images really.

We’ll have agree to disagree there. my authors frequently have 30 ~ 40 words captions (mostly graphs and figures). But I won’t derail this thread further.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#22 2015-11-14 11:45:31

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,564
Website GitHub Mastodon

Re: Admin layout update patch

NicolasGraph wrote #296610:

One more thing: I get a blank page (with the txp-footer only) when I click the Create new article button under the Articles tab.

Thanks for the report – fixed now.

Offline

#23 2015-11-14 12:29:17

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,909
Website

Re: Admin layout update patch

philwareham wrote #296609:

It’s the same size as meta description textarea on write panel, I don’t foresee users writing massive captions for images really.

For what it’s worth, I’m working on an historical piece (nearly a small book now), which relies on many images, and each image, due to their historical nature, can easily have multiple lines of descriptive text, plus image credits information. It would be a mistake to think nobody writes more than a few words for captions. It just depends on the genre of article.

Offline

#24 2015-11-14 17:14:01

moon blake
Member
From: near Hannover, Germany
Registered: 2009-07-16
Posts: 76

Re: Admin layout update patch

It would be a mistake to think nobody writes more than a few words for captions. It just depends on the genre of article.

+1

Offline

Board footer

Powered by FluxBB