Admin layout update patch

philwareham · 2015-11-13 08:31:55

The major part of admin layout update is a few days away from potentially being merged into the 4.6dev master. We will need some testers to just check there is no major blocking bug that prevents that happening.

See issue here.

There are still some fixes I need to make (such as the prefs list being screwed up at the moment) but if anyone wants to test work so far, you can download from here.

Post any major issues below. Thanks!

NicolasGraph · 2015-11-13 10:00:11

philwareham wrote #296569:

The major part of admin layout update is a few days away from potentially being merged into the 4.6dev master. We will need some testers to just check there is no major blocking bug that prevents that happening…

Thanks Phil!
I downloaded the theme but it seems there are still many things you’re working on, isn’t it?
Let us know when it will be ready to test, i’ll try to help.

philwareham · 2015-11-13 13:12:25

You need to do a clean full install or update from that branch, not just download the theme. That won’t work.

NicolasGraph · 2015-11-13 13:45:36

philwareham wrote #296575:

You need to do a clean full install or update from that branch, not just download the theme. That won’t work.

Oh, yes, that’s what I did in fact but I get several strange things like strange alignements and content width when switching between differents article preview mode (write / HTML / preview), or inputs which are not contained in the screen width on a medium screen (during a plugin install for exemple), etc.

There is also a bug on the prefs list, but it’s probably what you were talking previously…

philwareham · 2015-11-13 13:49:47

What browser and what theme? Only Hive theme is supported in this branch, no other themes as yet.

NicolasGraph · 2015-11-13 14:00:33

philwareham wrote #296578:

What browser and what theme? Only Hive theme is supported in this branch, no other themes as yet.

Yes, it’s Hive. Same problems on FF 42.0 and Chrome 46.0.2490.86 (64-bit). Seems ok on Safari 9.0.1.

Edit: Prefs list bug is also on Safari.

Last edited by NicolasGraph (2015-11-13 14:01:12)

NicolasGraph · 2015-11-13 14:09:38

In fact, comparing to Safari, I get a general content width problem on FF and Chrome.
Do you need screenshots?

phiw13 · 2015-11-13 14:25:48

NicolasGraph wrote #296580:

In fact, comparing to Safari, I get a general content width problem on FF and Chrome.

Ah yes, one of the interesting side effects of flexbox. The reason is here:

.txp-body { margin: 0 auto; }

Firefox shrinks the width of that element to it’s minimum content width, and centres the box. Safari 9 does’t yet implement auto margins correctly per the latest version of the spec. I don’t blame them, the spec has changed sooo much over the past year. I think Edge 12 also implements that part correctly now.

a tentative fix, just by looking at the Firefox inspector:

.txp-body { margin: 0; /* this will kill the shrink to min-content */ }
@media (min-width:116em) { .txp-body { width:116em; } }

philwareham · 2015-11-13 14:41:18

OK, I will investigate. Bloody flexbox ;) Added this issue to the list.

philwareham · 2015-11-13 20:25:47

OK, I think I’ve fixed that page width problem now. Thanks for the report and tips.

NicolasGraph · 2015-11-13 21:06:32

philwareham wrote #296591:

OK, I think I’ve fixed that page width problem now. Thanks for the report and tips.

Yes, that works for me… Thank you for the prompt fix!

NicolasGraph · 2015-11-13 21:16:07

Just another thing while I’m thinking about it (not a bug): shouldn’t the Create thumbnail button be after the inputs and the checkbox used to set its parameters? The first thumbnail creation I did, I clicked the final Send button after entering the thumbnails parameters.

Last edited by NicolasGraph (2015-11-14 10:15:31)

Textpattern CMS

Textpattern CMS support forum

#1 2015-11-13 08:31:55