Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2015-09-10 12:30:31

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,909
Website

Re: http vs. https

I’m asking for reasons of CSF, which is an open community site that relies on sponsors or free tech, whenever possible. No out of pocket expenses on any of the leading crew. So, regardless of how cheap it may be, I’d prefer a gracious alternative. It’s not a huge priority at the moment. By the time Let’s Encrypt comes around, that should be fine and provide the right kind of “stupid-easiness” I need.

Offline

#14 2015-09-10 13:26:28

GugUser
Member
From: Quito (Ecuador)
Registered: 2007-12-16
Posts: 1,473

Re: http vs. https

gaekwad wrote #294627:

I understand that bug was identified, fixed, and committed – but it didn’t make it into the 4.5 branch before 4.5.7.

(…)

I found it – r4681 – it was added to 4.x branch. It was fine-tuned by r5075 and both commits appear to have made it GitHub intact.

Thanks for the details. The fixes were made in late 2012 by Jukka, but, as it seems, they have not been integrated into 4.5.7. In my 4.5.7 package, in the txp_log.php file (LastChangedRevision: 4062), there is the older code from line 191:

if ($log_refer)
{
	$log_refer = 'http://'.$log_refer;
	$log_refer = '<a href="'.txpspecialchars($log_refer).'" target="_blank">'.txpspecialchars(soft_wrap($log_refer, 30)).'</a>';
}

Not the fixed code from r5075:

if ($log_refer)
{
	$log_refer = href(txpspecialchars(soft_wrap(preg_replace('#^http://#', '', $log_refer), 30)), txpspecialchars($log_refer), ' target="_blank"');
}

Strange.

Offline

#15 2015-09-10 14:40:52

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,259
GitHub

Re: http vs. https

GugUser wrote #294657:

The fixes were made in late 2012 by Jukka, but, as it seems, they have not been integrated into 4.5.7.

Yes. That is correct. The commits were made to the 4.x branch when Textpattern lived at Google Code, and were not committed to 4.5 which is where Textpattern 4.5.7 was built from. Why not committed to 4.5? I do not know.

Offline

#16 2015-09-10 15:23:40

ruud
Developer Emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 5,068
Website

Re: http vs. https

I guess we’ll have to wait for 4.6 for that.

Offline

#17 2015-09-10 18:42:00

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,448
Website GitHub

Re: http vs. https

gaekwad wrote #294673:

Why not committed to 4.5? I do not know.

Oversight / lack of focus / gnome army attack.*

* delete as applicable.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#18 2015-09-15 05:02:58

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

Re: http vs. https

Fresh and recommended by the Electronic Frontier Foundation free https certificates


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#19 2015-09-15 06:26:16

jstubbs
Member
From: Hong Kong
Registered: 2004-12-13
Posts: 2,395
Website

Re: http vs. https

colak wrote #294811:

Fresh and recommended by the Electronic Frontier Foundation free https certificates

You are a bit late Yiannis!

Destry wrote #294591:

Lets Encrypt

Offline

#20 2015-09-15 06:58:26

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

Re: http vs. https

jstubbs wrote #294815:

You are a bit late Yiannis!

As always:)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

Board footer

Powered by FluxBB