Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#16 2015-07-05 23:43:33

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 12,497
Website GitHub

Re: Visitor logs, Host field

ruud wrote #292604:

Characters inserted by the soft_wrap() function to make the hostname wrap

OK, thanks for the clarification. Is this desirable any more, given the more fluid nature of the admin-side these days? I could just remove the soft_wrap() and then the need to swap the columns round is lessened somewhat.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Hire Txp Builders – finely-crafted code, design and Txp

Offline

#17 2015-07-06 01:19:22

phiw13
Plugin Author
From: South-Western Japan
Registered: 2004-02-27
Posts: 3,669
Website

Re: Visitor logs, Host field

Bloke wrote #292608:

OK, thanks for the clarification. Is this desirable any more, given the more fluid nature of the admin-side these days? I could just remove the soft_wrap() and then the need to swap the columns round is lessened somewhat.

I don’t think so. For my own theme (Sandspace) I have both columns set to white-space: nowrap anyway (both for TXP 4.5.x and 4.6dev). Don’t remember it ever caused me problems — not that I often look at logs anyway.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
phiw13 on Codeberg

Offline

#18 2015-07-06 08:21:44

ruud
Developer Emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 5,068
Website

Re: Visitor logs, Host field

Bloke wrote #292608:

OK, thanks for the clarification. Is this desirable any more, given the more fluid nature of the admin-side these days? I could just remove the soft_wrap() and then the need to swap the columns round is lessened somewhat.

See the screenshot Bert posted. You’d get horizontal scrollbars due to the long URL without soft_wrap. I’d vote for showing the IPnr always and only showing the hostname when viewing the details, but keep soft_wrap there.

Offline

#19 2015-07-06 09:45:16

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 12,497
Website GitHub

Re: Visitor logs, Host field

Swapped columns. Thanks everyone.

Now, do we hide the Visitor Logs menu when logs are off in prefs, or leave it available so logs can be viewed after they’ve been turned off? Hmmm…


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Hire Txp Builders – finely-crafted code, design and Txp

Offline

#20 2015-07-06 09:50:43

hcgtv
Archived Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: Visitor logs, Host field

Bloke wrote #292631:

Now, do we hide the Visitor Logs menu when logs are off in prefs, or leave it available so logs can be viewed after they’ve been turned off? Hmmm…

Logs get cleaned out when you visit the logs page, if you turn off logging, and you hide the drop down menu for the Visitor logs, how does the log file get purged of expired entries?

Offline

#21 2015-07-06 10:04:21

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 12,497
Website GitHub

Re: Visitor logs, Host field

hcgtv wrote #292632:

Logs get cleaned out when you visit the logs page, if you turn off logging, and you hide the drop down menu for the Visitor logs, how does the log file get purged of expired entries?

Another good point. Best leave it available in the menu. I’ll do that.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Hire Txp Builders – finely-crafted code, design and Txp

Offline

#22 2015-07-06 10:33:39

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 12,497
Website GitHub

Re: Visitor logs, Host field

Bloke wrote #292633:

Another good point. Best leave it available in the menu. I’ll do that.

Hmmm, hang on. It seems that if you turn off Logging, the logs are truncated so there’s no need to visit the panel again to purge them.

I was just toying with the idea of leaving the panel available, even if you turn logging off, as long as there’s a value set for Logs expire after how many days. That would give you a chance to check out your logs until they expire, even after you stop logging hits. Under this scenario, if you wanted to remove the menu entry entirely you’d need to both:

  1. Turn off logging.
  2. Set log expiry to 0 days.

At the moment in 4.6-dev, the logs are purged as soon as you turn off logging so checking the expiry time is pointless.

It may have purged logs in prior versions too, I’m not sure. Is that desired behaviour? Or a tad unexpected?


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Hire Txp Builders – finely-crafted code, design and Txp

Offline

#23 2015-07-06 16:35:26

Destry
Member
From: Haut-Rhin
Registered: 2004-08-04
Posts: 4,912
Website

Re: Visitor logs, Host field

What makes sense to me is if there’s a preference to turn logs off (thus hide the tab/link/panel too), it purges any existing logs at the same time.

If ever you want to turn them on again, the tab/panel comes back and whatever your last value was for “number of days to log” restarts.

Rinse and repeat.

Offline

#24 2015-07-06 16:37:13

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,784
GitHub

Re: Visitor logs, Host field

Destry wrote #292653:

What makes sense to me is if there’s a preference to turn logs off (thus hide the tab/link/panel too), it purges any existing logs at the same time.

If ever you want to turn them on again, the tab/panel comes back and whatever your last value was for “number of days to log” restarts.

+1.

Offline

#25 2015-07-07 02:45:29

phiw13
Plugin Author
From: South-Western Japan
Registered: 2004-02-27
Posts: 3,669
Website

Re: Visitor logs, Host field

Bloke wrote #292638:

Is that desired behaviour?

Yes. Turn off logging = delete in my mind.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
phiw13 on Codeberg

Offline

#26 2015-07-07 05:34:06

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,394
Website GitHub Mastodon Twitter

Re: Visitor logs, Host field

phiw13 wrote #292700:

Yes. Turn off logging = delete in my mind.

+1


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#27 2015-07-07 09:09:17

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 12,497
Website GitHub

Re: Visitor logs, Host field

Destry wrote #292653:

What makes sense to me is if there’s a preference to turn logs off (thus hide the tab/link/panel too), it purges any existing logs at the same time.

In which case, that’s what it does already. Best ever bug resolution in history: no action required.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Hire Txp Builders – finely-crafted code, design and Txp

Offline

#28 2015-07-07 10:18:20

gaekwad
Server grease monkey
From: People's Republic of Cornwall
Registered: 2005-11-19
Posts: 4,784
GitHub

Re: Visitor logs, Host field

Bloke wrote #292720:

Best ever bug resolution in history: no action required.

Undocumented feature.

Offline

Board footer

Powered by FluxBB