Nested ternary operators

trenc · 2014-11-13 15:16:06

I hate it … really.

I’m writing a new plugin and I want to borrow some code from the core but not without some beautifying.

I found this damn nested ternary:

$cond = is_array($cf_contents) ? in_array($term, $cf_contents) : ((strpos($cf_contents, $term) !== false) ? true : false);

Can anybody unravel this. Am I correct with this translation:

$cond = false;
if (is_array($cf_contents))
{
	if (in_array($term, $cf_contents))
	{
		$cond = true;
	}
}
else
{
	if (strpos($cf_contents, $term) !== false)
	{
		$cond = true;
	}
}

Bloke · 2014-11-13 16:45:01

Ughhh, that’s damn ugly. I hope I didn’t write that line in a moment of madness…

Anyway, your translation looks good to me. I might borrow it back for the core ;-)

trenc · 2014-11-13 17:22:04

Naa … I doubt it Stef. It’s in if_custom_field tag lib. And seems old, very old. There are even code statements without brackets, brrb.

But you’re welcome to use it, if it’s correct.

ruud · 2014-11-15 09:01:51

trenc wrote #285722:

I found this damn nested ternary:

$cond = is_array($cf_contents) ? in_array($term, $cf_contents) : ((strpos($cf_contents, $term) !== false) ? true : false);

It can be written even more beautiful ;)

$cond = is_array($cf_contents) ? in_array($term, $cf_contents) : !is_bool(strpos($cf_contents, $term));

etc · 2014-11-15 11:18:17

ruud wrote #285784:

It can be written even more beautiful ;)

Yeah, great, the ugliest part was

(strpos($cf_contents, $term) !== false) ? true : false

Textpattern CMS

Textpattern CMS support forum

#1 2014-11-13 15:16:06