PR #448 on GitHub

gaekwad · 2014-10-20 14:14:09

github.com/textpattern/textpattern/pull/448

Hi devs.
I’d be grateful for some feedback or a merge/decline on the above, please. I have a few more PRs that I’m working on that, for some reason, insist in being merged into this PR. I’m sticking to one commit per PR because it’s clearer and, I assume, easier to manage from a merge point of view.

Thanks very much.

Bloke · 2014-10-20 15:37:26

Feedback posted. Sorry about the multiple after-market edits to the post. Hit tab by mistake at one point without noticing and my next space character submitted the form in a part-finished state. Ugh.

gaekwad · 2014-10-20 17:01:51

Cheers, Stef – thanks.

ruud · 2014-10-21 06:55:45

VARCHAR ( 45 ) doesn’t save space compared to VARCHAR ( 255 ). Both use 1 byte (length, 3 bytes if utf8) + the actual length of the content stored. You could use CHAR ( 45 ), but then you waste space when storing IPv4 adresses.

Bloke · 2014-10-21 07:59:25

ruud wrote #284998:

VARCHAR ( 45 ) doesn’t save space compared to VARCHAR ( 255 ).

Quite true, I’d forgotten that. Perhaps it’s just my mild OCD gene that makes me want to have all fields that hold the same type of data to have the same width.

Textpattern CMS

Textpattern CMS support forum

#1 2014-10-20 14:14:09

PR #448 on GitHub

#2 2014-10-20 15:37:26

Re: PR #448 on GitHub

#3 2014-10-20 17:01:51

Re: PR #448 on GitHub

#4 2014-10-21 06:55:45

Re: PR #448 on GitHub

#5 2014-10-21 07:59:25

Re: PR #448 on GitHub

ruud wrote #284998:

Board footer