Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Pages: 1
Popup tag
Just sifting through some of the documentation doing rewriting, came across this in the txp:popup tag attributes:
Attribute: type
Values: s (section), c (category).
Default: c.
Shouldn’t they be changed to actually be section and category? Seems to be the pattern used elsewhere? I’ve never actually used this tag myself but should be consistent.
Offline
Re: Popup tag
philwareham wrote #284309:
I’ve never actually used this tag myself but should be consistent.
I don’t think this anyone ever used it. That was a “feature” in Movable Type that had a little traction a decade ago.
I can’t find a link but a lot of people thought it was bad for SEO and other reasons.
Offline
Re: Popup tag
Phil, this might be of some use – it’s not 100% complete, but might be handy as on overview:
docs.google.com/spreadsheet/ccc?key=0AttMnit590uEdHQ1QVdXdjBhaEtscDgyNE55WU5UNnc&usp=sharing
Offline
Re: Popup tag
philwareham wrote #284309:
Shouldn’t they be changed to actually be
sectionandcategory?
Yeah, probably. We could deprecate the older values and leave them lurking for a while. Or just, shock horror, deprecate the entire tag. Does anyone use it any more? Seems like a throwback to the 1990s web. Does it have any valid application these days? Speak up, anyone, if so.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
Offline
Re: Popup tag
gaekwad wrote #284337:
it’s not 100% complete, but might be handy as on overview
Saaaay, that’s a nice list. Reminds me, I should revisit the comments debacle and actually do something about it one day.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
Re: Popup tag
Keywords tag should stay, it has multiple uses. Popup tag should probably go, I mean, how does it work anyway? Just opens a blank window or some javascript thing? either way it’s not something we should support.
Offline
Re: Popup tag
philwareham wrote #284345:
Keywords tag should stay, it has multiple uses.
Agreed. I’m just saying its intended use is not entirely relevant; I’m all for MacGyver-ing it for other uses.
Offline
Re: Popup tag
philwareham wrote #284345:
Keywords tag should stay
Yep, I use it for actual keywords because I’m retro. But have also been known to smodge it for other uses such as linking articles via topics.
Popup tag should probably go
I just looked at the code. It’s not what I thought it was, sorry. It actually creates a section/category dropdown list inside a form. So, potentially useful, just crappily-named.
It does a few horrible things like auto-submitting the form onchange. That should probably be a tag attribute for accessibility’s sake, but then we’d need a way to inject a submit button too and then things get more complicated. It also hard-codes the submit method as GET. Presumably the tag’s author had a specific use case in mind, now lost in the mists of time.
Last edited by Bloke (2014-09-30 10:28:25)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
Re: Popup tag
I can change the popup tag code to accept section or category as attribute values, and we can document it as such for consistency. It’s a two-line change. Internally the code can just test the first character of the value to retain backwards compatibility.
Since you mentioned it, Phil, feel free to raise an Issue referencing this thread and assign it to me. Of course, if we want to deprecate the tag and rename it to something more appropriate or alter its behaviour, then we can explore that too.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
Re: Popup tag
OK, issue opened.
Probably needs to be renamed to something more appropriate than ‘popup’ and the documentation improved.
Offline
Pages: 1