The 'txp_img' directory - WTF is that for?

philwareham · 2014-04-23 16:06:39

No a feature request, more a feature removal request…

We have a ‘txp_img’ directory in the Textpattern core – why? What is it there for? Who actually uses it?

I vote it should be removed – unless there is a good reason it’s there.

colak · 2014-04-23 17:25:23

I guess you are suggesting to move the images within it to the images directory?

wet · 2014-04-23 17:40:30

What would you use as an alternative location for the images which currently live there?

bici · 2014-04-23 17:48:53

Odd … But in the 10 years of using TxP I have never ever looked in that directory! Seems to contain system level images used by the core.

Speaking of images. I never use the images directory that lives at the root level with the 1.gif and 2.gif files in it. I put all my images in my assets/images/ directory. I do RESENT having those two images. are they necessary?

colak · 2014-04-23 17:51:24

bici wrote #280370:

I do RESENT having those two images. are they necessary?

I guess they are there as samples for the default page templates.

bici · 2014-04-23 17:57:18

colak wrote #280371:

I guess they are there as samples for the default page templates.

ok. makes sense.

philwareham · 2014-04-23 18:22:57

bici wrote #280372:

I do RESENT having those two images. are they necessary?

Just a heads up, those two images files were removed about two years ago!

As for txp_imgdirectory, in v4.6dev all admin theme images are now actually in their admin theme directory where they should be. That just leaves a logo image and some badges that are not used by core in any way so should be dumped.

I can load the badges into the branding repo, and one day we can provide those from the website. If you are using image files from within /textpattern directory on a public site then you really shouldn’t (and any people that used them previously – if any actually do – will still have them available if they upgrade since that wouldn’t be overwritten by an update).

Gocom · 2014-04-23 20:43:55

philwareham wrote #280374:

will still have them available if they upgrade since that wouldn’t be overwritten by an update

Given the historical quality of those images, it’s pretty safe to assume no one is using them in their professional work. If you are, well, you are probably using red Comic Sans too. The contents of the directory has never been stable either, so removing it doesn’t really matter for backwards compatibility sake.

As the directory itself goes, anything inside textpattern is considered no-zone outside from strictly documented locations which include themes, tmp and config.php.

philwareham · 2014-04-23 20:55:02

I’ve already deleted it :)

Textpattern CMS

Textpattern CMS support forum

#1 2014-04-23 16:06:39