RFC: <txp:if_body> tag

gaekwad · 2014-02-13 10:10:33

Most components of the article have if_ conditionals, but I don’t see one for if_body. The body isn’t mandatory, and while it’s arguable that an article should have body content, that’s not always the case.

I’m thinking out loud; what do you think? Overkill?

Edited title x3 to reflect workarounds/solutions provided/discussion

Last edited by gaekwad (2014-02-14 11:14:49)

colak · 2014-02-13 10:14:17

With the variable tag all if tags could become obsolete.

<txp:variable name="ifbody" value='<txp:body />' />
<txp:if variable name="ifbody" value="">
no body
<txp:else />
<txp:variable name="ifbody" />
</txp:if_variable>

gaekwad · 2014-02-13 10:15:55

Oh, smart!

GugUser · 2014-02-13 11:01:45

Also works:

<txp:if_custom_field name="body">
	(…)
</txp:if_custom_field>

gaekwad · 2014-02-13 11:03:35

Perhaps my idea is overkill after all – thanks, GugUser.

sacripant · 2014-02-13 11:05:02

I use that

<txp:if_custom_field name="body">
Body
<txp:else />
No Body
</txp:if_custom_field>

Edit : Too late !

Last edited by sacripant (2014-02-13 11:06:14)

gaekwad · 2014-02-13 11:07:03

I like the fewer-tags-in-core idea, having thought about it a little longer – especially with <txp:if_custom_field name="body">. Good advice – thanks to you all.

Destry · 2014-02-13 12:23:47

Maybe I’m missing something, but why fake the if at all? Just don’t declare a body.

<txp:article>
   <txp:title />
   <txp:exerpt />
</txp:article>

Want a single instance of output? Point to the ID.

<txp:article_custom id="">
   <txp:exerpt />
</txp:article_custom>

gaekwad · 2014-02-13 12:27:20

Hi Destry – you’re not missing anything at all. The reason for my asking is for a site I’m working on that may have a body or may not, and I wanted to cover all the bases. I’m working on the principle that the more I can bake into the code at this stage, the less stuff I have to remember when I’m making content for the site, hence the idea of if_body.

GugUser · 2014-02-13 14:03:11

Destry wrote #278911:

Maybe I’m missing something, but why fake the if at all? Just don’t declare a body.

It can be helpful in the case when you want some more tags or code if the body has content.

colak · 2014-02-13 14:21:55

I guess the advantage of the variable over the other methods is that it only makes one db query.

philwareham · 2014-02-13 15:01:36

Maybe open an issue for it at the Google Code project

For consistency, there probably should be a core <txp:if_body> tag.

etc · 2014-02-13 16:43:56

colak wrote #278916:

I guess the advantage of the variable over the other methods is that it only makes one db query.

Yiannis, none of these methods queries the DB, all data is already retrieved by <txp:article[_custom] /> tag. Actually, if_custom_field solution is potentially cleaner, since it does not require parsing body field when checking.

etc · 2014-02-13 16:53:02

philwareham wrote #278918:

For consistency, there probably should be a core <txp:if_body> tag.

Please, no! Multiplying similar tags ad infinitum is a bad idea. For consistency, I would rather suggest replacing all these <txp:if_article_something /> by <txp:if_article type="something" />. And the weirdest code-replicating tags are <txp:if_first_something />, but it’s too late now(?).

philwareham · 2014-02-13 19:30:07

Ok then, don’t open an issue! :)

I did put emphasis on ‘probably’. I do agree all these conditionals get a bit confusing when they are nested.

Maybe give an extended example of how this conditionals stuff all could be cleaned up.

Textpattern CMS

Textpattern CMS support forum

#1 2014-02-13 10:10:33