Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Pages: 1
plugin help links are br0ken
Or at least, non-functional: clicking/tapping the link does nothing.
From the Admin > Plugins pane, click a ‘help’ link, expect a help page to appear… Instead the Plugins pane reloads.
The generated link: http://example.com/textpattern/index.php?event=plugin&step=plugin_help&name=plugin_name_here
The URL contains & entity (ampersand), where a real ampersand is expected.
(as copied from Safari’s location bar)
Textpattern 4.6dev @ svn r4846, not sure when this broke.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: plugin help links are br0ken
It’s due to double encoding. These same issues could potentially appear all around the place since there is HTML encoding where there weren’t before. These issue are caused by the mega-functionality changes done in r4833 and r4836.
Lemme go drown in this shallow pool now.
Last edited by Gocom (2012-11-29 02:10:38)
Offline
Re: plugin help links are br0ken
Gocom wrote:
It’s due to double encoding. These same issues could potentially appear all around the place since there is HTML encoding where there weren’t before. These issue are caused by the mega-functionality changes done in r4833 and r4836.
Yeah, after further investigation, the issue now shows up in various places (e.g. Content > Files or Contents > Images, the name column)
Lemme go drown in this shallow pool now.
Don’t… water is cold and wet. Thanks for investigating.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: plugin help links are br0ken
For those playing at home, r4847 fixed the issue in the Plugins pane. Thanks Jukka.
Other panes affected are Images, Files and Links (the links in the name column), Comments (links in the ID column), Sections (name, page and style columns). I think that is all.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: plugin help links are br0ken
I appreciate the efforts on checking links, but, well, more of so you can’t see the errors by looking the output.
Unfortunately, there way more improperly encoded URLs than just those. Basically almost all lines changed in those two commits have broken a link given few rules. The double encoding affects every URL that has any extra attributes (classes, titles). Phil seemingly changed attributes from string presentations to arrays. There just is that little thing that in the array list mode attributes are sanitized automatically which Phil might have overlooked. Since these URLs are already encoded (and encoding weren’t removed), this is basically causing the issue.
Those two commits are quite huge and potentially contain some other changes and of course valid alterations too. As such, I will avoid blatantly reverting, and instead will let Phil and us do manual handpicking and sorting out the changes that need to be removed and those that do not.
Last edited by Gocom (2012-11-29 06:36:29)
Offline
Re: plugin help links are br0ken
Gocom wrote:
Unfortunately, there way more improperly encoded URLs than just those.
Was it? Hadn’t noticed with Sandspaces (from the subsequent checkins – r4850-4851 – I see indeed more affected links).
Those two commits are quite huge and potentially contain some other changes and of course valid alterations too. As such, I will avoid blatantly reverting, and instead will let Phil and us do manual handpicking and sorting out the changes that need to be removed and those that do not.
Right I did’t mean to push you or Phil to hurry hurry to fix this…
Anyway, the issue is fixed now, as far as I can see.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: plugin help links are br0ken
I still see this issue on the Images and Files panes (@rev5005) – afaict only for the ID column on those panes.
Or did something regressed on those two panes ?
Last edited by phiw13 (2012-12-12 05:35:30)
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Offline
Offline
Re: plugin help links are br0ken
It is getting much better now. I couldn’t find any problem links anymore, so far.
As for tooltips, dunno, it is something I’m much less likely to see (I don’t have the patience to wait for the tooltip to pop up…)
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: plugin help links are br0ken
Yay, looks like I broke something again!
I’ve learnt over the last month I should stick to what I actually know, which is not PHP.
Offline
Pages: 1