Textpattern CMS

#1 2012-10-24 03:22:19

gomedia

Plugin Author

Registered: 2008-06-01

Posts: 1,373

Breaking prev/next links

Here’s a simple page:

<txp:article>
	<txp:title />
	<txp:link_to_prev>Prev</txp:link_to_prev>
	<txp:link_to_next>Next</txp:link_to_next>
</txp:article>

Article titles, prev & next links output OK.

But if I add a <txp:article_custom /> into the mix:

<txp:article_custom id="1" />

<txp:article>
	<txp:title />
	<txp:link_to_prev>Prev</txp:link_to_prev>
	<txp:link_to_next>Next</txp:link_to_next>
</txp:article>

The prev/next links no longer appear.

Am I going mad? Please discuss!

#2 2012-10-24 05:43:56

wet

Developer Emeritus

From: Schoerfling, Austria

Registered: 2005-06-06

Posts: 3,340

Website GitHub Mastodon

Re: Breaking prev/next links

Which version of Textpattern do you use?

#3 2012-10-24 05:58:22

gomedia

Plugin Author

Registered: 2008-06-01

Posts: 1,373

Re: Breaking prev/next links

Hi Robert,

Saw the problem on 4.5.0, upgraded to 4.5.2 but still no luck.

#4 2012-10-24 06:34:55

wet

Developer Emeritus

From: Schoerfling, Austria

Registered: 2005-06-06

Posts: 3,340

Website GitHub Mastodon

Re: Breaking prev/next links

I was able to reproduce this issue. Try this as a workaround:

<txp:article pgonly="1" />

<txp:article_custom id="1" />

<txp:article>
	<txp:title />
	<txp:link_to_prev>Prev</txp:link_to_prev>
	<txp:link_to_next>Next</txp:link_to_next>
</txp:article>

#5 2012-10-24 06:44:36

gomedia

Plugin Author

Registered: 2008-06-01

Posts: 1,373

Re: Breaking prev/next links

wet wrote:

I was able to reproduce this issue. Try this as a workaround:

Nope, didn’t do anything for me.

#6 2012-10-24 07:38:11

wet

Developer Emeritus

From: Schoerfling, Austria

Registered: 2005-06-06

Posts: 3,340

Website GitHub Mastodon

Re: Breaking prev/next links

I suspect that it did do something for you in single article view but not on the article list. Please feedback.

#7 2012-10-24 07:59:16

gomedia

Plugin Author

Registered: 2008-06-01

Posts: 1,373

Re: Breaking prev/next links

You suspect right!

#8 2012-10-24 08:44:20

wet

Developer Emeritus

From: Schoerfling, Austria

Registered: 2005-06-06

Posts: 3,340

Website GitHub Mastodon

Re: Breaking prev/next links

Please try r4445.

#9 2012-10-24 22:33:54

gomedia

Plugin Author

Registered: 2008-06-01

Posts: 1,373

Re: Breaking prev/next links

wet wrote:

Please try r4445.

Just pulled down r4457 and your fix has done the job. Thank you very much.

Just as an aside, I used to see the revision number in Diagnostics in my SVN set up, but now I see:

Textpattern version: 4.6-dev (593fe71c83986a003522fb0c88dd8cd2)

What’s the best way of confirming the actual revision now?

#10 2012-10-25 01:35:39

Gocom

Developer Emeritus

From: Helsinki, Finland

Registered: 2006-07-14

Posts: 4,533

Website

Re: Breaking prev/next links

The current value listed with the version number is a checksum of your installation (i.e. your working copy). It can be used to verify your installation integrity.

That revision number in diagnostics didn’t actually confirm anything. That number was extracted from embedded header comments handled by SVN keywords. There was no validation involved of any kind.

If you want to know the revision your working copy is, the best (and honestly, the only) option is to ask SVN. E.g.

$ svnversion

Last edited by Gocom (2012-10-25 01:38:25)

---

Rah | GitHub

#11 2012-10-25 03:41:01

gomedia

Plugin Author

Registered: 2008-06-01

Posts: 1,373

Re: Breaking prev/next links

Gocom wrote:

If you want to know the revision your working copy is, the best (and honestly, the only) option is to ask SVN. E.g. …

Thanks. I had an inkling that the revision number in diagnostics might not have been reliable anyway. I’ll do the SVN thing instead.