Feedback to: Textpattern 4.5.0 released

Gocom · 2012-09-03 12:06:06

Kalon, could you mind opening an issue report on Textile’s issue tracker on GitHub, so this error can get noticed and fixed. Include your PHP version and full error messages in the report too. Thanks.

Edit. …or go by Roberts plan.

Last edited by Gocom (2012-09-03 12:08:37)

hidalgo · 2012-09-03 12:08:15

wet wrote:

hidalgo, please set production status to “debugging” and try again. You should get more verbose error messages then. Post these here.

No worries, here are the results:

Internal error "preg_match() [function.preg-match]: Compilation failed: unrecognized character after (?< at offset 5"
in /var/www/vhosts/domain.com/httpdocs/textpattern/lib/classTextile.php at line 1496.

adminErrorHandler()
textpattern/lib/classTextile.php:1496 preg_match()
textpattern/lib/classTextile.php:1572 Textile->parseURI()
Textile->fLink()
textpattern/lib/classTextile.php:1563 preg_replace_callback()

Internal error "Undefined index: scheme"
in /var/www/vhosts/domain.com/httpdocs/textpattern/lib/classTextile.php at line 1574.

textpattern/lib/classTextile.php:1574 adminErrorHandler()
Textile->fLink()
textpattern/lib/classTextile.php:1563 preg_replace_callback()
textpattern/lib/classTextile.php:1193 Textile->links()
textpattern/lib/classTextile.php:1155 Textile->graf()

Gocom · 2012-09-03 12:10:18

Which PHP version?

hidalgo · 2012-09-03 12:11:24

PHP version: 5.3.3

Last edited by hidalgo (2012-09-03 12:17:44)

wet · 2012-09-03 12:27:14

I cannot reproduce this with this minimal testcase in PHP 5.3.3:

<?php
require 'classTextile.php';
$t = new Textile();
echo $t->TextileThis('"example":http://example.com/');

—

$ php -v
PHP 5.3.3 (cli) (built: Jul 21 2010 20:28:30)
Copyright (c) 1997-2010 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies

Are you experiencing this issue with minimal articles containing just one link like "example":http://example.com/ or just with larger texts and many links? If so, we’d need a sample article text.

hidalgo · 2012-09-03 12:35:52

The problem occurs whenever there’s a Textile link, regardless of article length or number of links from my tests. The default ‘Welcome to your site!’ article fails, as does a single link with no other text like your example above.

Last edited by hidalgo (2012-09-03 12:41:25)

Shomari · 2012-09-03 21:04:45

I posted to an issue in the support forum that I now think may possibly have been appropriate for this section. I’m quite unsure. It’s about unexpected behavior causing random code to be generated and appended after editing pages/articles/forms in the 4.5 admin area. The issue was present in 4.4.1 as well, but it seems to have been missed and is now in 4.5.

Please pardon me if linking this here as well is inappropriate for this forum. http://forum.textpattern.com/viewtopic.php?pid=265274#p265274

uli · 2012-09-03 22:20:50

Shomari wrote:

It’s about unexpected behavior causing random code

Have you tried whether plugins yet to be updated are part of your problem? Try deactivating your plugins and see whether the random code is still there or is still caused by editing + saving respectively. If plugins don’t cause the issue please post the random code. Are there any error messages?

Shomari · 2012-09-03 23:29:32

No error messages, and yes I’ve disabled all plug-ins back when I first noticed the issue in 4.4.1. The random code still appeared.

I don’t know if posting the random code would help, it’s always different according to what’s already saved in the form/page/article being edited. Also, if not deleted, the code will continue appending random strings pulled from the already saved text – (clarification: random code string builds with each subsequent save/refresh.)

I know where to look for it and how to remedy it when it happens, but what I don’t know is how to prevent new instances from occurring.

EDIT: …clicked on an article and found this bit of superfluous code as an example

</fb:comments>
third party /fb:like href=

That’s certainly typical of what generally happens with this behavior. This particular code was found in the article edit text area in the admin side, but wasn’t present on the front end. That’s part of what bothers me the most with this; apart from the fact that it’s randomly generating and appending code, it’s confusing because it sometimes does and sometimes doesn’t alter the front end output.

Last edited by Shomari (2012-09-03 23:44:33)

wet · 2012-09-04 04:55:33

hidalgo, please…

download this patched copy of classTextile.php
unzip it
replace the the existing file on your webserver with the extracted classTextile.php file. It is located in the /textpattern/lib directory.

Please report back if this patch fixes your issue.

Diff:

Index: textpattern/lib/classTextile.php

--- textpattern/lib/classTextile.php	(revision 4091)
+++ textpattern/lib/classTextile.php	(revision )
@@ -1484,7 +1484,7 @@
 	 **/
 	function parseURI( $uri, &$m )
 	{
-		$r = "@^((?<scheme>[^:/?#]+):)?(//(?<authority>[^/?#]*))?(?<path>[^?#]*)(\?(?<query>[^#]*))?(#(?<fragment>.*))?@";
+		$r = "@^((?P<scheme>[^:/?#]+):)?(//(?P<authority>[^/?#]*))?(?P<path>[^?#]*)(\?(?P<query>[^#]*))?(#(?P<fragment>.*))?@";
 		#       12                     3  4                      5              6  7                8 9
 		#
 		#	scheme    = $2

Last edited by wet (2012-09-04 04:57:53)

Textpattern CMS

Textpattern CMS support forum

#81 2012-09-03 12:06:06

Re: Feedback to: Textpattern 4.5.0 released

#82 2012-09-03 12:08:15

Re: Feedback to: Textpattern 4.5.0 released

#83 2012-09-03 12:10:18

Re: Feedback to: Textpattern 4.5.0 released

#84 2012-09-03 12:11:24

Re: Feedback to: Textpattern 4.5.0 released

#85 2012-09-03 12:27:14

Re: Feedback to: Textpattern 4.5.0 released

#86 2012-09-03 12:35:52

Re: Feedback to: Textpattern 4.5.0 released

#87 2012-09-03 21:04:45

Re: Feedback to: Textpattern 4.5.0 released

#88 2012-09-03 22:20:50

Re: Feedback to: Textpattern 4.5.0 released

#89 2012-09-03 23:29:32

Re: Feedback to: Textpattern 4.5.0 released

#90 2012-09-04 04:55:33

Re: Feedback to: Textpattern 4.5.0 released

Board footer