Feedback to: Textpattern 4.5.0 released

maniqui · 2012-08-27 18:17:14

I’ve reported issue 250.

Quick summary: sites/site1/public/index.php and sites/site1/public/css.php are missing some new lines introduced in the corresponding files at the root folder. Have yet to test if this missing lines affect multi-site install in any way.

zero · 2012-08-27 18:59:05

Corfitz Ulfeldt wrote:

One thing though: For unknown reasons the ‘search’ field is displayed twice in my completely fresh installation.

Same for me on clean install. (After basic installation only, nothing else) I just clicked Update in the language page, viewed the site and there were 2 search boxes in Home and About but only 1 in Articles

On another point, txp:search_input still does not work with match="all" or match="any" and a new user might feel confident that search is working as expected when it is actually only doing exact searches. They will be very disappointed when they find out, so at least could someone change the information in Textbook / Docs?

Last edited by zero (2012-08-27 19:00:39)

Corfitz Ulfeldt · 2012-08-27 19:42:47

@ Phil: Yes i believe so, although I could have not notices as i made the backups quite quickly after installing. I did also change the time format in the preferences but thats it i think.

@Zero (and Phil) Same for me, 2 search forms in home and about but only 1 in articles

philwareham · 2012-08-27 20:08:08

OK, I’ve done a clean install and found what the problem is…

In the default page, line 142 there is some code which shouldn’t be there:

<txp:search_input form="" button="<txp:text item="go" />" label="" />

That needs to be deleted, then you’ll only have one search field. I’m not sure how that got there as it’s not in my GitHub repo code at all. I’ll fix the offending line in txpsql.php and get Robert to rebundle.

moon blake · 2012-08-27 20:13:05

Regarding glz_custom_fields: any chance for an update?
Somewhere I read that Phil contacted Gerhard concerning this matter. Does anybody knows about any results?

Gocom · 2012-08-27 20:14:41

philwareham wrote:

rebundle.

Rebundle? As in modifying the release source? I’m not sure if it’s exactly good idea to do unannounced changes to an already tagged release. To release any changes at this point would need (or justify) a .1 patch.

Last edited by Gocom (2012-08-27 20:17:30)

philwareham · 2012-08-27 20:22:11

I’ve committed the change to SVN (r4081) and emailed Robert to let him know – it’s now up to him how he wants to deal with this revise.

philwareham · 2012-08-27 20:24:13

@moon blake

Yeah, I’ve got access to Gerhard’s GitHub repo for glz_custom_fields but only so I can advise on layout – nothing more. You’ll have to contact him direct if there’s some underlying problem with how it interacts with the 4.5 database.

Corfitz Ulfeldt · 2012-08-27 20:25:06

Thanks for the quick response Phil and again great job with the new themes!

Nichod · 2012-08-27 20:28:59

One small issue I did come across is that the sidebar (complementary) has double search inputs. At least the install I downloaded today did.

I just edited the default page like so (commenting out the reference to the search form):

<div role="complementary">
<txp:search_input /> 
        <!-- links by default to form: 'search_input.misc.txp' unless you specify a different form 
<txp:search_input form="" button="<txp:text item="go" />" label="" /> -->

moon blake · 2012-08-27 20:34:58

Yes thanks from me, too, for quick response, Phil. I will try to get in touch with Gehard. Hopefully others will do so, too. This plugin is obviously widely used.

Nichod · 2012-08-27 20:39:44

I see others found the search issue as well. I’m thinking that it was originally intended to illustrate how to link to a specific search form.

I’m really liking the new admin theme, HTML5 site theme, mobile access, etc. All the hard work is appreciated.

mlsmith · 2012-08-27 22:36:23

Loving the new version! I ran into a couple of issues and submitted them in the issue tracker (251, 252)

The first one relates to the duplicate search field but it looks like Phil already fixed that.

The second has to do with duplicate comment sections in the articles. Screenshot attached to issue 252.

mlsmith · 2012-08-27 23:11:49

Sorry…one more thing that I noticed. In Chrome, the installation progress arrows are a bit off. Sorry, I’m picky! ;-)

Screenshot

Last edited by mlsmith (2012-08-27 23:12:42)

philwareham · 2012-08-28 07:12:04

@mlsmith

Can you confirm, is that Chrome on Windows, and which version of browser? Looks fine on Chrome v22 on my Mac here.

Textpattern CMS

Textpattern CMS support forum

#16 2012-08-27 18:17:14

Re: Feedback to: Textpattern 4.5.0 released

#17 2012-08-27 18:59:05

Re: Feedback to: Textpattern 4.5.0 released

#18 2012-08-27 19:42:47

Re: Feedback to: Textpattern 4.5.0 released

#19 2012-08-27 20:08:08

Re: Feedback to: Textpattern 4.5.0 released

#20 2012-08-27 20:13:05

Re: Feedback to: Textpattern 4.5.0 released

#21 2012-08-27 20:14:41

Re: Feedback to: Textpattern 4.5.0 released

#22 2012-08-27 20:22:11

Re: Feedback to: Textpattern 4.5.0 released

#23 2012-08-27 20:24:13

Re: Feedback to: Textpattern 4.5.0 released

#24 2012-08-27 20:25:06

Re: Feedback to: Textpattern 4.5.0 released

#25 2012-08-27 20:28:59

Re: Feedback to: Textpattern 4.5.0 released

#26 2012-08-27 20:34:58

Re: Feedback to: Textpattern 4.5.0 released

#27 2012-08-27 20:39:44

Re: Feedback to: Textpattern 4.5.0 released

#28 2012-08-27 22:36:23

Re: Feedback to: Textpattern 4.5.0 released

#29 2012-08-27 23:11:49

Re: Feedback to: Textpattern 4.5.0 released

#30 2012-08-28 07:12:04

Re: Feedback to: Textpattern 4.5.0 released

Board footer