Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Pages: 1
r3747 structure wrong
The structure introduced in r3747 is actually incorrect. Need to remove the fieldset and legend tags within the comments_group.
Currently it is:
<div id="comments_group">
<h3 class="plain lever expanded"><a href="#comments">Comments</a></h3>
<div id="comments" class="toggle">
<fieldset id="write-comments">
<legend>Comments</legend>
<p class="comment-annotate">
<input type="radio" id="Annotate-0" name="Annotate" value="0" class="radio active" checked="checked" /><label for="Annotate-0">Off</label>
<input type="radio" id="Annotate-1" name="Annotate" value="1" class="radio" /><label for="Annotate-1">On</label>
</p>
<p class="comment-invite">
<label for="comment-invite">Invitation</label><br />
<input type="text" value="Comment" name="AnnotateInvite" class="edit" id="comment-invite" />
</p>
</fieldset>
</div>
</div>When it should like so:
<div id="comments_group">
<h3 class="plain lever expanded"><a href="#comments">Comments</a></h3>
<div id="comments" class="toggle">
<p class="comment-annotate">
<input type="radio" id="Annotate-0" name="Annotate" value="0" class="radio active" checked="checked" /><label for="Annotate-0">Off</label>
<input type="radio" id="Annotate-1" name="Annotate" value="1" class="radio" /><label for="Annotate-1">On</label>
</p>
<p class="comment-invite">
<label for="comment-invite">Invitation</label><br />
<input type="text" value="Comment" name="AnnotateInvite" class="edit" id="comment-invite" />
</p>
</div>
</div>Last edited by philwareham (2012-04-19 09:35:20)
Offline
Re: r3747 structure wrong
I’m curious, why do you think it is wrong ? A <fieldset> is perfectly justified in my book.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: r3747 structure wrong
@phiw13
Because it’s inconsistent structure compared with the toggle boxes used in the #configuration_content column, and also it’s unnecessary to have an inner fieldset in this instance since it’s the only fields within the #comments_group toggle box anyway.
Currently we have a h3 on the #comments_group toggle box and then a legend on the inner fieldset fulfilling exactly the same role.
It makes more sense like this IMHO
Last edited by philwareham (2012-04-19 14:45:13)
Offline
Re: r3747 structure wrong
FYI: I introduced a container element around the comment status inputs in r3808.
Offline
Re: r3747 structure wrong
Hi Wet, what’s the reasoning for that – it was already being contained by div#comments? None of the other collapsible areas (in the left hand side) have an inner container like that.
Offline
Re: r3747 structure wrong
I need a container which:
- can completely be replaced through AJAX
- gather its content from plugins through
pluggable_ui()
The outer div#comments serves as the hook for the expand/collapse lever functionality. We do not assume that plugins handle the toggle functionality for the core thus we’d have to separate this part of the UI from the inner HTML, now contained in div#write-comments, p#write-comments.
It is also (a bit more) compatible with the extinct fieldset#write-comments from v4.4.1.
None of the other collapsible areas (in the left hand side) have an inner container like that.
We sort of have, e.g. with ul.recent.
Last edited by wet (2012-06-10 09:17:40)
Offline
Re: r3747 structure wrong
Ok thanks. All makes sense.
Offline
Pages: 1