Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#13 2012-03-04 06:23:23

maruchan
Member
From: Ukiah, California
Registered: 2010-06-12
Posts: 595
Website

Re: Tag error is displayed for tag in html comment tags, intended?

a snare and a delusion

:-D

Last edited by maruchan (2012-03-04 06:23:35)

Offline

#14 2012-03-04 08:38:59

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,330
Website Mastodon

Re: Tag error is displayed for tag in html comment tags, intended?

MixedContent wrote:

why issue a message about a configuration problem if the misconfigurator will almost certainly have no clue how to make use of it?

Thanks for the report. This issue has been fixed in r3673. In the next release, the error message will show the probable offending form and page names.

Offline

#15 2012-03-04 09:11:11

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: Tag error is displayed for tag in html comment tags, intended?

wet wrote:

Thanks for the report. This issue has been fixed in r3673. In the next release, the error message will show the probable offending form and page names.

If I’m not reading that wrong, there is no longer a line number. Please, can you bring it back? For, you know, the actual developing of code and tags? An message handled by tagErrorHandler() isn’t necessarily always even from a tag. At least add all available information to the tag trace, please and the line number at the end of the message.

Last edited by Gocom (2012-03-04 09:25:47)

Offline

#16 2012-03-04 09:26:49

Gocom
Developer Emeritus
From: Helsinki, Finland
Registered: 2006-07-14
Posts: 4,533
Website

Re: Tag error is displayed for tag in html comment tags, intended?

Oh, yeah, the page and the form are escaped twice (with htmlspecialchars()), added to tag trace probably shouldn’t be escaped at all. Tag trace can and should take raw output, shouldn’t it?

Last edited by Gocom (2012-03-04 09:31:16)

Offline

#17 2012-03-04 13:14:08

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,306

Re: Tag error is displayed for tag in html comment tags, intended?

MixedContent wrote:

Is there a central place where tips like this can be found (or should be found)?

The “central place” is TXP Tips. Not each of the hints and tricks in this forum finds its way there, though.
If you find something you discover valuable and it’s mature/tested you can always post it over there, I guess Jonathan (siteowner of TXP Tips, jstubbs here in the forum) is grateful for contributions.


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#18 2012-03-04 15:18:20

jstubbs
Member
From: Hong Kong
Registered: 2004-12-13
Posts: 2,395
Website

Re: Tag error is displayed for tag in html comment tags, intended?

That’s right @uli – always happy to see more contributions for the benefit of the community..!

Offline

Board footer

Powered by FluxBB