Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
r3638: Txp's definition of 'row' is wonky
Some inconsistencies in r3638 detected:
1) Image edit step: table rows are highlighted. Should this table be id="edit" instead of list?
2) File edit step: ditto
3) Admin->Diagnostics tab: ditto
4) Admin->Preferences: all rows, including fake 3rd tier nav and Save buttons, are highglighted on account of it all being a table. Options:
a) Lay it out slightly differently
b) Make the CSS hover rule slightly more explicit
c) Live with it
5) Forms tab: form names in sidebar aren’t highlighted on hover (Pages and Styles are). Reason: this is not a table. Proposal: change CSS rule to something like:
table#list tbody tr:hover,
.list li:hover {
background-color: #ffc;
}I can fix 1, 2, and 3 easily enough (my fault in the first place) but I’m not sure what to do about 4, and I’m not sure if 5’s proposed fix has other side-effects (or there’s a better way to do it).
Anyone care to weigh in?
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
Re: r3638: Txp's definition of 'row' is wonky
I’ll weigh in with the whole tr hover thing being pointless IMHO. We have hover states on clickable items for accessibility and the occasional special effect rollover (though that practice should be discouraged too), not for table rows.
Offline
Re: r3638: Txp's definition of 'row' is wonky
Why not limit that hover effect to those tables that are real data tables (e.g. articles subtab, or images subtab) – that is, select on the class .list. The IDs on those tables should never be used for any styling purposes as they are used without any logic on a wide diversity of elements – we’ve had discussions about this in the past, and Bloke added those classes for the styling purpose
table.list tbody tr:hover {
background-color: #ffc;
}(I’m not a big fan of highlighting table-rows on hover, but I can see it may help some people reading through those rows)
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: r3638: Txp's definition of 'row' is wonky
I reverted this change set until something better has come up.
Offline
Re: r3638: Txp's definition of 'row' is wonky
Before adding a special class attribute to taget the lists, try this:
#page-list table#list tbody tr:hover,
#page-file table.list tbody tr:hover,
#page-link table.list tbody tr:hover,
#page-discuss table.list tbody tr:hover{
background-color:#ffc
}
#page-file table.edit-pane tbody tr:hover{
background-color:none
}
Patrick.
Github | CodePen | Codier | Simplr theme | Wait Me: a maintenance theme | [\a mi.ni.ma]: a “Low Tech” simple Blog theme.
Offline
Re: r3638: Txp's definition of 'row' is wonky
Please don’t use hover on tables. Really no need. The cascade is already complicated enough without introducing more nested ID selectors into the mix. Think of the themers.
Offline