Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2012-02-08 20:07:55

maruchan
Member
From: Ukiah, California
Registered: 2010-06-12
Posts: 595
Website

[textile] Textile 2.3 bug?

Question was raised over here. I looked at Mary’s sticky but didn’t see a way to file a bug, so maybe it’s already been filed. Thanks.

Offline

#2 2012-02-08 20:17:02

maniqui
Member
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 3,070
Website

Re: [textile] Textile 2.3 bug?

Marc, could you report it here?

github.com/netcarver/textile/issues


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#3 2012-02-08 20:48:12

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,448
Website GitHub

Re: [textile] Textile 2.3 bug?

Interesting, it’s the last thing on the line that gets missed:

* -strikethrough- *bold* _italics_

Renders:

<ul>
	<li><del>strikethrough</del> <strong>bold</strong> _italics_</li>
</ul>

While:

* -strikethrough- *bold* _italics_ %span%

Renders:

<ul>
	<li><del>strikethrough</del> <strong>bold</strong> <em>italics</em> %span%</li>
</ul>

Same inside numbered lists and def-lists.

Last edited by Bloke (2012-02-08 20:48:48)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#4 2012-02-10 01:10:28

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,448
Website GitHub

Re: [textile] Textile 2.3 bug?

Heck, it gets worse, although this is actually more of the same issue. Since it doesn’t Textile the last thing on the line in lists, when you only have one item in the list it doesn’t convert it, by virtue of it being the last item :-(

viz.:

; %(cls)Textpattern%
: The *best* CMS for _designers_

Renders:

<dl>
    <dt>%(cls)Textpattern%</dt>
    <dd>The <strong>best</strong> <span class="caps">CMS</span> for _designers_</dd>
</dl>

Expected:

<dl>
    <dt><span class="cls">Textpattern</span></dt>
    <dd>The <strong>best</strong> <span class="caps">CMS</span> for <em>designers</em></dd>
</dl>

Marc, did you raise this as an issue on Github? It’s a regression and needs attention sharpish before the next Txp release. I could look into patching it myself but I’m swamped with the mag redesign, though if netcarver needs a hand I’ll try and slot it in.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#5 2012-02-10 07:28:09

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,330
Website Mastodon

Re: [textile] Textile 2.3 bug?

It fails with any inline markup trailed by an angle bracket.

Try this for instance:

<p>*foo*</p>

Explainer:

Lists are parsed in two intermediate steps. The first one renders the list (ul, ol, dl) and item (li) tags and passes the intermediate result on to the span parsing stage which in turn cares for em, strong, span tags.

At this intermediate stage a list looks like so:

<ul>
  <li>_italics_ *bold*</li>
  <li>*bold*</li>
</ul>

In this case *bold*< is a sequence with a trailing angle bracket and therefore fails.

I think I’ve found the culprit and gave Steve a nudge.

Offline

#6 2012-02-10 17:47:56

maruchan
Member
From: Ukiah, California
Registered: 2010-06-12
Posts: 595
Website

Re: [textile] Textile 2.3 bug?

Thanks to everyone here for looking into it—and Robert for filing the bug more accurately than I could have. :-)

Offline

#7 2012-02-10 20:38:08

net-carver
Archived Plugin Author
Registered: 2006-03-08
Posts: 1,648

Re: [textile] Textile 2.3 bug?

wet wrote:

I think I’ve found the culprit and gave Steve a nudge.

Ker-ching!


Steve

Offline

#8 2012-02-11 05:26:11

wet
Developer Emeritus
From: Schoerfling, Austria
Registered: 2005-06-06
Posts: 3,330
Website Mastodon

Re: [textile] Textile 2.3 bug?

This issue has been fixed in r3631.

Offline

Board footer

Powered by FluxBB