r3621: "Sections" tab AJAXified

wet · 2012-02-01 17:34:33

Those of you who live a life less ordinary and run a development version may have noticed that we switched to AJAX for “save” operations on the Sections tab as per change set 3621.

This means from an end-user perspective: No more reloads after each “save” operation, no more lost changes to one section as you happend to save just the other one.

Please clear your browser’s cache, then kick the tires and report any quirks you might encounter. Browser make and model might help diagnose any bugs you encounter so be verbose.

ruud · 2012-02-01 18:00:44

The “save” button turns grey when I click it… but it stays grey. However, if you make other changes and press “save” again, the changes are saved. This is confusing, because grey (to me) means an inactive button.

wet · 2012-02-01 18:04:38

It should turn light grey while the request is processed and return to its normal colour once the response arrives at the client. This may take a while (even up to a few seconds).

Last edited by wet (2012-02-01 18:16:26)

ruud · 2012-02-01 18:21:36

It does turn light grey. It does not return to its normal color (not even after a minute).
I’ve tried Firefox and Chrome, both up-to-date.

wet · 2012-02-01 18:26:17

Which browser make/model?
Does clearing the browser cache and getting it a definitely fresh copy of http://example.com/textpattern/textpattern.js [r3618] from your web server help? Some clients are rather aggressive with JS caching.

ruud · 2012-02-01 18:56:39

Forget it. Problem found. I have sed_section_fields 0.5.3 installed. Disabling that solved the problem.
I’ll go hide in shame now ;)

net-carver · 2012-02-01 20:32:37

ruud wrote:

Forget it. Problem found. I have sed_section_fields 0.5.3 installed. Disabling that solved the problem. I’ll go hide in shame now ;)

Sounds like I should be the one hiding in shame :)

wet · 2012-02-02 05:14:54

Steve, have you ever tried to make use of the 'section_ui', 'extend_detail_form' pluggable UI in sed_section_fields? This callback is intended to be helpful for this kind of plugins, and if it isn’t, we should strive to improve it.

To illustrate, here’s a snippet I use elsewhere:

if (txpinterface == 'admin') {
	register_callback('wet_mytxp_section_ui', 'section_ui', 'extend_detail_form');
}

function wet_mytxp_section_ui($event, $step, $dummy, $data)
{
	$mydata = safe_row('wet_shorttitle', 'txp_section', "name = '".doSlash($data['name'])."'");
	return
	tr(
		fLabelCell(gTxt('section_shorttitle').':').
		fInputCell('shorttitle', $mydata['wet_shorttitle'], 1, 20)
	);
}

tom1 · 2012-02-02 10:12:14

Sorry to intrude this thread with no testing of r3621 at all..
I just noticed updated thread here and after reading this, i remembered solution my customer found clear to non-programmer.
We made theirs ajax powered forms so, that when you edit text in input field, background color changes ( adds class ‘edited’ ).
When save happens, and ajax returns success, background color of all posted fields are changed back (removeClass(‘edited’) ).

With this its easy to see unsaved fields at quick glance. Graying out button is also a good choice, but maybe less visible to user.

Textpattern CMS

Textpattern CMS support forum

#1 2012-02-01 17:34:33

r3621: "Sections" tab AJAXified

#2 2012-02-01 18:00:44

Re: r3621: "Sections" tab AJAXified

#3 2012-02-01 18:04:38

Re: r3621: "Sections" tab AJAXified

#4 2012-02-01 18:21:36

Re: r3621: "Sections" tab AJAXified

#5 2012-02-01 18:26:17

Re: r3621: "Sections" tab AJAXified

#6 2012-02-01 18:56:39

Re: r3621: "Sections" tab AJAXified

#7 2012-02-01 20:32:37

Re: r3621: "Sections" tab AJAXified

#8 2012-02-02 05:14:54

Re: r3621: "Sections" tab AJAXified

#9 2012-02-02 10:12:14

Re: r3621: "Sections" tab AJAXified

Board footer