Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#31 2011-07-20 17:58:51

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,565
Website GitHub Mastodon

Re: New Default Theme

@[Axel]

I used the HTML5 outliner which looks OK, but I’ll look into your comments and see if those suggested improvements should be made – looks pretty straightforward. I put the header h2 in so it placed less semantic importance on that than the article h1, but maybe you’re right.

Thanks, Phil

Offline

#32 2011-07-21 15:21:15

[Axel]
Member
From: Switzerland/Denmark
Registered: 2007-07-26
Posts: 65
Website

Re: New Default Theme

I use the old fashioned webdeveloper tools in firefox and chrome, which renders the document outline as in this pic

you can get it here

it is still a useful tool, even though I mostly relay on firebug.


Greetz [Axel]

Offline

#33 2011-07-21 15:26:42

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,565
Website GitHub Mastodon

Re: New Default Theme

Hmmm, not sure I agree with that outline though. I think I need to read some more articles on the topic first before I commit a change. I’ll keep you posted.

Offline

#34 2011-07-21 23:55:59

phiw13
Plugin Author
From: South-Western Japan
Registered: 2004-02-27
Posts: 3,636
Website

Re: New Default Theme

The outline as shown by [Axel] is based on html4 (which has a requirement to have h1 -> h2 -> h3 -> …). HTML5 doesn’t have that requirement, strictly speaking (you can build a whole doc with only h1, structured through header, section, article and nested section or/and article and other sectioning elements).

I actually like the way HTML5 builds this up, but note that at present, support for this way of document outlining is spotty (think AT). No penalty as far as SEO goes, afaik. And note that html5 doesn’t preclude the use of h2, etc.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
phiw13 on Codeberg

Offline

#35 2011-07-22 09:51:03

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,565
Website GitHub Mastodon

Re: New Default Theme

Thanks for the clarification Philippe. I’ve had a good scour through these two documents regarding outlines in HTML5…

http://html5doctor.com/outlines/

http://diveintohtml5.org/semantics.html

I think there are a couple of improvements I can make to the outline of the theme, I’ve already made the headings in the <header> tag a <hgroup> (though I’ll keep an eye on hgroup as its future seems in some doubt) and I think I should also make headings in things such as the <nav> to be <h1> instead of the current <h2> (even though they are hidden with CSS and just there for the outline).

Offline

#36 2011-07-30 15:56:22

zero
Member
From: Lancashire
Registered: 2004-04-19
Posts: 1,475
Website

Re: New Default Theme

I’ve been playing with this very nice new default theme, Phil. Great work! So far I have a couple of points –

Click the Articles link, there is a heading ‘Articles’ which is H1 but the articles listed are H4, so should probly be h2?
Do a search, there is a heading ‘Search Results’ which is H1, but ‘results found’ heading is H3 and articles listed are H1, so last two should be H2 and H3 respectively?

In the placeholder for search ‘Search My Site’ would be better as ‘Search My Site?’ I read this on an accessibility website but now can’t find it, but apparently the question mark helps with accessibility.


Dozy P My attempt at music

Offline

#37 2011-07-30 17:24:09

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,565
Website GitHub Mastodon

Re: New Default Theme

Hi zero, since this is html5 the document outline is slightly different than previous XHTML or HTML. For example you can safely have multiple h1 tags on the page as they are semantic to their parent tag, not the whole page itself. For example you can have a h1 in the header tag and a h1 in every article on that page and a modern search engine will know how to interpret that. Likewise you could only have a h3 in your article title and it would give the exact same result as above.

I will have another look over the outline though and see if any improvements are needed.

Regarding the ‘?’ I’m not sure if I can add it in, I agree this may help in English but since this theme is going to need to be multiple language I don’t know whether I can add it.

Cheers, Phil.

Last edited by philwareham (2011-07-30 17:27:51)

Offline

#38 2011-07-30 18:16:03

zero
Member
From: Lancashire
Registered: 2004-04-19
Posts: 1,475
Website

Re: New Default Theme

Thanks Phil, I’m sure you will come up with the best way.

Another small one: from the PHP strftime site “Warning Mac OS X only: The %P modifier is not supported in the Mac OS X implementation of this function.” On my OS X the time is showing as ‘6:48P’ whereas on your demo site it is showing the ‘pm’ even when viewed from my mac browser.


Dozy P My attempt at music

Offline

#39 2011-07-31 13:26:54

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,565
Website GitHub Mastodon

Re: New Default Theme

@zero

Thanks for the warning, I’ve changed the time with %P in it to just be 24 hour time now – bit of a shame, but it does fix the OS X limitation.

Offline

#40 2011-08-31 12:16:44

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,565
Website GitHub Mastodon

Re: New Default Theme

Robert has just updated the Textpattern language server with a handful of new strings for this theme, which now makes the project totally language-free.

If you are using the Github version on any upcoming projects remember to make sure your language pack is up to date (go to admin -> preferences -> languages and then click ‘update’ next to any installed languages if available).

It would be nice if translations of the new strings can be made by willing contributors in the normal fashion – there’s only 14 extra strings so not too much translating to do.

Offline

#41 2011-08-31 22:46:27

hcgtv
Archived Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: New Default Theme

Great theme Phil, I really enjoy playing with it on my Android phone.

The only critique that I have is the use of PHP in the theme, I know it’s very little, but the biggest selling point of Textpattern is it’s use of tags. By using template tags, the user is shielded from shooting themselves in the foot with PHP.

Our biggest competitor, the capital P dangit people, probably wish they had such an elegant template tag system in place before their software went viral. Just read about the whole timthumb fiasco and you’ll come to appreciate the zen simplicity of Textpattern.

Other than that, I’ve learned quite a bit from your theme, thanks for your effort.

Offline

#42 2011-09-01 07:10:47

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,565
Website GitHub Mastodon

Re: New Default Theme

Hi Bert,

I’ve tried to use as many Textpattern tags as possible (within reason) in the theme to demonstrate their uses, including the single use of a <txp:php> which shows how you can extend functionality past the tags if none presently exist to do the job you want (in this case recognising when the comment author is also the article author).

I’d like to keep that in there personally, unless a core tag I’ve not thought of can do the same thing. But if the devs or community en masse decide that it’s wrong to have any raw PHP then of course I’ll look at stripping it out.

Offline

#43 2011-09-01 10:53:29

wet
Developer Emeritus
From: Vöcklabruck, Austria
Registered: 2005-06-06
Posts: 3,416
Website GitHub Mastodon

Re: New Default Theme

philwareham wrote:

unless a core tag I’ve not thought of can do the same thing.

Fixed (kind of).

I’ll make use of this new tag in the new default theme for performance reasons and to shelter newbies from PHP, but I support your inclination to keep it in your extended version for educational purposes et cetera.

Offline

#44 2011-09-01 11:37:28

philwareham
Core designer
From: Haslemere, Surrey, UK
Registered: 2009-06-11
Posts: 3,565
Website GitHub Mastodon

Re: New Default Theme

Wow, that’s speedy service for you!

I think I’ll replace the PHP code in Github once this new tag makes it into an official TXP release – seems the best course of action.

Offline

#45 2011-09-01 13:46:43

hcgtv
Archived Plugin Author
From: Key Largo, Florida
Registered: 2005-11-29
Posts: 2,722
Website

Re: New Default Theme

wet wrote:

I’ll make use of this new tag in the new default theme for performance reasons and to shelter newbies from PHP, but I support your inclination to keep it in your extended version for educational purposes et cetera.

New tag for a new theme, very nice of you Robert.

As for educational purposes, the footer in the archive, default and error_default pages contains:

<txp:php>echo date('Y');</txp:php>

Maybe this would suffice to show new users how they can use PHP?

Offline

Board footer

Powered by FluxBB