Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2011-02-28 02:34:37

redbot
Plugin Author
Registered: 2006-02-14
Posts: 1,410

A spare multi-edit row in 'users' tab

I think I found a (minor) bug.
If login with “managing editor” privileges and point to the “users” tab I can’t see the last table column, the one with class “.multi-edit”.
This is right because this role can only view users, not manage them.
The problem is I can still see the lower row which, again, has a class of “.multi-edit” and this is probably wrong.

Offline

#2 2011-02-28 09:18:54

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,446
Website GitHub

Re: A spare multi-edit row in 'users' tab

redbot wrote:

The problem is I can still see the lower row which, again, has a class of “.multi-edit” and this is probably wrong.

Good catch. It’s actually the same deal in other tabs too, like the Articles list if you’re logged in as a Designer. The good news is that the multi-edit does nothing, it’s just visual clutter. But yes it should only be displayed if you have privs.

Would you mind raising an issue ticket for this behaviour please? Thanks.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#3 2011-02-28 09:47:14

redbot
Plugin Author
Registered: 2006-02-14
Posts: 1,410

Re: A spare multi-edit row in 'users' tab

Bloke wrote:

…Would you mind raising an issue ticket for this behaviour please? Thanks.

Done.

…The good news is that the multi-edit does nothing, it’s just visual clutter

I agree this is absolutely nothing serious, just visual clutter.
BTW in this case, if you are an usability purist, you can use my last microplugin bot_admin_body_class to hide the extra row only for some users.

Offline

#4 2011-03-24 22:54:40

redbot
Plugin Author
Registered: 2006-02-14
Posts: 1,410

Re: A spare multi-edit row in 'users' tab

I have a little doubt: this issue was fixed with rev 3487 (thanks Bloke).
The log message states:

Remove multi-edit tools for non-privileged accounts on Users tab. Remove multi-
edit checkboxes for non-owners on Images tab. Fixes Issue 103

The doubt arises because Bloke says two posts above:

… It’s actually the same deal in other tabs too, like the Articles list if you’re logged in as a Designer.

The question is: was the articles list fixed too?

Offline

#5 2011-03-24 23:02:31

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,446
Website GitHub

Re: A spare multi-edit row in 'users' tab

redbot wrote:

The question is: was the articles list fixed too?

No. I realised it wasn’t a bug at all. Every author has Edit.Own.Articles privs so potentially they all need access to multi-edit.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#6 2011-03-24 23:04:48

redbot
Plugin Author
Registered: 2006-02-14
Posts: 1,410

Re: A spare multi-edit row in 'users' tab

Bloke wrote:

No. I realised it wasn’t a bug at all. Every author has Edit.Own.Articles privs so potentially they all need access to multi-edit.

Ok, thank you Bloke and sorry for the hassle.

Offline

Board footer

Powered by FluxBB