Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2010-09-30 07:30:17

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,189
Website

inconsistencies in usage of 'publish' classname

Some last minute minor thingie / bug I just noticed.

in image > edit image the ‘save button’ has a class of ‘publish’ (and Link > edit link, Comments > edit comment)
in file > edit file the ‘save button’ has no such class.

Can that be added (for 4.3.0) ?

And then, under Preferences – Basic and Preferences – Advanced, under the headline ‘Publish’, the h3 and the rows have the same ‘publish’ class. Make it .publish-prefs maybe ?

Oh and in Preferences > Basic, the input button in ‘check for updates’ at the bottom of the pane probably want a different class… It is not a ‘save’ action here. (semantic nitpick :-))

Last edited by phiw13 (2010-09-30 07:31:43)


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

#2 2010-10-04 22:09:57

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,446
Website GitHub

Re: inconsistencies in usage of 'publish' classname

Fixed in 3416. Many thanks for pointing these out.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#3 2010-10-05 12:18:58

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 3,189
Website

Re: inconsistencies in usage of 'publish' classname

Thanks Stef.


Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern

Offline

Board footer

Powered by FluxBB