[textile] Textile 2.2

net-carver · 2010-09-26 20:24:18

GugUser

Did the suggested fix work for you?

GugUser · 2010-09-26 20:42:45

net-carver

Yes. Thank you for your tips.

Why can affect a commented line the parsing process?

net-carver · 2010-09-26 20:47:51

GugUser

I don’t know why — but the PHP parser seems to pick up the ?> from the commented-out regex. If the regex isn’t commented out the parser correctly recognizes it as part of a string.

I don’t know if this is part of the PHP Parser’s defined behaviour.

wet · 2010-09-26 21:01:32

net-carver wrote:

Your use of German quotation marks does raise some interesting localisation issues that will need some thought.

NB: We’ve been there at least once.

GugUser · 2010-09-26 21:18:31

net-carver, an additional comment:

Five weeks ago I mentioned in the german forum that I would like a different replacement with either <abbr> or <span class="caps">, but not the two together. Because the <span> within the <abbr> together with a CSS rule, for example, abbr, .caps { font-size: .929em; } has a double effect.

Moreover, the dual element (with my abbr instead of acronym) <abbr title="Content Management System"><span class="caps">CMS</span></abbr> is not necessary in HTML.

I hope I can explain it with my poor English … ;-)

typeshige · 2010-09-27 07:16:52

Thanks for the feedback about the tests. I can imagine a set of tests being released that specify the version as well.

I don’t think this would hinder the development of new features if people felt there could be several versions floating around with tests that exercise each of them..e

Oh and on line 423:

‘/[([]3\/4[])]/’, // 3/2

It should be:

‘/[([]3\/4[])]/’, // 3/4

My worthless contribution… :)

net-carver · 2010-09-27 10:44:14

typeshige wrote:

Oh and on line 423:

‘/[([]3\/4[])]/’, // 3/2

It should be:

‘/[([]3\/4[])]/’, // 3/4

Done in my repository.

net-carver · 2010-09-27 10:56:40

wet wrote:

NB: We’ve been there at least once.

Thanks for the pointer — lots of interesting discussion in that thread.

Bloke · 2010-09-27 11:08:22

net-carver wrote:

lots of interesting discussion in that thread.

Seconded, thanks wet.

Although l10n has been partially fixed in Textile 2.2 with regards using the right quotes in the right places when using English quote systems and apostrophes it does need a bit more thought to make it better. This is doubly true given that it depends on the language in which the article itself is delivered, which may be distinct from the language in use on the admin side at save time (which is when Textile does its stuff).

Hmmm. Luckily the guy who dreamed up MLP is here to help :-)

philwareham · 2010-09-27 12:36:12

Great work. Any chance of changing <acronym> tag to <abbr> soon? Or is it straightforward for me to edit myself?

Bloke · 2010-09-27 12:40:57

philwareham wrote:

Any chance of changing <acronym> tag to <abbr> soon?

See this issue. And yes it’s pretty straightforward to edit. Just change line 435(ish) of lib/classTextile.php from ‘acronym’ to:

'<abbr title="$2">$1</abbr>',     // 3+ uppercase abbreviation

and I think that’ll do it. Untested.

net-carver · 2010-09-27 14:23:55

Bloke wrote:

Hmmm. Luckily the guy who dreamed up MLP is here to help :-)

Humbug!

Textpattern CMS

Textpattern CMS support forum

#25 2010-09-26 20:24:18

Re: [textile] Textile 2.2

#26 2010-09-26 20:42:45

Re: [textile] Textile 2.2

#27 2010-09-26 20:47:51

Re: [textile] Textile 2.2

#28 2010-09-26 21:01:32

Re: [textile] Textile 2.2

#29 2010-09-26 21:18:31

Re: [textile] Textile 2.2

#30 2010-09-27 07:16:52

Re: [textile] Textile 2.2

#31 2010-09-27 10:44:14

Re: [textile] Textile 2.2

#32 2010-09-27 10:56:40

Re: [textile] Textile 2.2

#33 2010-09-27 11:08:22

Re: [textile] Textile 2.2

#34 2010-09-27 12:36:12

Re: [textile] Textile 2.2

#35 2010-09-27 12:40:57

Re: [textile] Textile 2.2

#36 2010-09-27 14:23:55

Re: [textile] Textile 2.2

Board footer