Include footer in login page

radneck · 2010-09-11 04:48:33

I’ve been playing around with producing admin themes lately and noticed that one limitation is that you cannot open a wrapper (e.g. <div>) in the header() section and then close it in the footer() section, as the login page does not show the footer (well you can, but the login page won’t validate due to the missing </div>).

While this is obviously a very specific case, it does make sense for there to be some site-wide consistency. Can any devs tell my why the footer is not shown on the login page? My first guess would be something to do with security (perhaps it’s a risk blatantly showing would-be hackers what version of TXP you are running).

Edit: Added Issue 78.

Some thoughts on this would be great.

Last edited by radneck (2015-11-04 07:48:10)

Bloke · 2010-09-11 06:21:26

cain-mi wrote:

Can any devs tell my why the footer is not shown on the login page?

I think your guess about security is the best match. Although in theory not showing the version is simply ‘security through obscurity’ which is not really a good argument! The reason for the lack of page end is probably lost in the mists of time. I wasn’t around at the start so I don’t really know. Perhaps one of the early commits in SVN gives some insight…

radneck · 2010-09-11 06:34:35

Bloke wrote:

security through obscurity […] is not really a good argument

I agree. If it is an issue though, if ($txp_user) { could be wrapped around where txp_version is echoed, and we’d be fine. This would obviously be on a per-theme basis, but if it were done this way in the classic theme, I’m sure most theme developers would follow suit. Possibly something for TXP 4.3.0 or 5?

Last edited by radneck (2010-09-11 06:42:21)

Gocom · 2010-09-11 13:22:05

cain-mi wrote:

Possibly something for TXP 4.3.0 or 5?

Would be pretty great if it did ;-)

Last edited by Gocom (2010-09-11 13:22:15)

radneck · 2010-09-11 13:40:26

Gocom wrote:

Would be pretty great if it did ;-)

Well that’s a +1 from a couple of plugin devs, so once I get a login for the wiki I might put it on the feature request page.

Bloke · 2010-09-11 14:14:29

cain-mi wrote:

put it on the feature request page

Hehe, I didn’t even know we had a feature requests page on Tetxbook! Learn something new every day…

fwiw, I tend to check just the forum and the Google code project issue tracker for stuff like this. That wiki page seems rather out of date to me. With the best will in the world you might be better off putting any wiki energy you have into other pages. There’s going to be a lot of stuff that’ll need documenting/updating when 4.3.0 is released. Thanks in advance.

radneck · 2010-09-11 14:20:51

Bloke wrote:

I tend to check just the forum and the Google code project issue tracker for stuff like this.

Yeah I just found the issue tracker, might give that a shot. Cheers.

That wiki page seems rather out of date to me. With the best will in the world you might be better off putting any wiki energy you have into other pages.

I think you’re right, there is definitely some stuff that needs updating. I’ve asked for a wiki account, hopefully it’ll get activated in the next week or so.

Last edited by radneck (2010-09-11 14:21:55)

Textpattern CMS

Textpattern CMS support forum

#1 2010-09-11 04:48:33

Include footer in login page

#2 2010-09-11 06:21:26

Re: Include footer in login page

#3 2010-09-11 06:34:35

Re: Include footer in login page

#4 2010-09-11 13:22:05

Re: Include footer in login page

#5 2010-09-11 13:40:26

Re: Include footer in login page

#6 2010-09-11 14:14:29

Re: Include footer in login page

#7 2010-09-11 14:20:51

Re: Include footer in login page

Board footer