Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#526 2009-10-09 12:28:38

gerhard
Plugin Author
From: London, UK
Registered: 2005-06-29
Posts: 409
Website

Re: glz_custom_fields

mrdale wrote:

gerhard, can we twist your arm while we have your attention-ish to do another rev of glz with some of the simpler feature requests and bug squashies?

Hi Dale, I was planning a release this week, might need to wait until the next one though.

I have taken note of all the bugs that you’ve mentioned here and have addressed most of them, the most serious one has to do with deleting sequential custom sets. I’ve just sent an e-mail to Robert with a proposed solution, this is the gist of it.

In glz_custom_fields v1.2.2 I am no longer making a difference between 1-10 custom sets and the ones above that (e.g. custom_11_set, custom_12_set etc.). Since a user can adjust a custom set positioning, it makes no relevance whether that’s custom_5_set or custom_50_set. If custom_6_set is deleted, there will be an error because we’re using max_custom_fields to iterate over custom sets, when $i = 6, custom_6_set won’t be found . With my suggested changes, we could simply iterate over $prefs['custom']. This is what I’m proposing

This is an important change because this will open the floodgates for custom fields for other data types which I would like to see in the plugin before the end of this year : ).

Offline

#527 2009-10-09 13:35:29

redbot
Plugin Author
Registered: 2006-02-14
Posts: 1,410

Re: glz_custom_fields

gerhard wrote:

…I was planning a release this week, might need to wait until the next one though.

…This is an important change because this will open the floodgates for custom fields for other data types which I would like to see in the plugin before the end of this year : )

Thanks Gerhard for all your efforts! IMHO it is ok to wait a little more to have a more stable and cooler plugin. All in all the issue with sequential custom sets can be somehow managed untill the next version is out.

Offline

#528 2009-10-09 14:02:30

gerhard
Plugin Author
From: London, UK
Registered: 2005-06-29
Posts: 409
Website

Re: glz_custom_fields

I am starting to think that I might have rushed into removing the separation between 1-10 custom sets and the ones above. If I had kept the reset button rather than changing them all to delete/edit, you wouldn’t have had this issue in the first place. I might re-introduce the separation until we figure the $prefs namespacing with Robert.

Last edited by gerhard (2009-10-09 14:02:56)

Offline

#529 2009-10-09 14:41:00

mrdale
Member
From: Walla Walla
Registered: 2004-11-19
Posts: 2,215
Website

Re: glz_custom_fields

go go gadget gerhard. ;)

Offline

#530 2009-10-13 08:40:53

Zanza
Plugin Author
Registered: 2005-08-18
Posts: 699
Website

Re: glz_custom_fields

Sorry, I have a problem with glz_custom_field latest version (1.2.2) and other plugins in txp 4.2.0. Especially:

  • bot_show_image is broken (the image is put below the table instead of its proper place above article image field)
  • jmd_image_selector is not showing the insert image link works with most recent jmd plugin version!

They both look as jquery problems. Am I doing something wrong?

Last edited by Zanza (2009-10-13 10:43:14)

Offline

#531 2009-10-13 09:01:43

gerhard
Plugin Author
From: London, UK
Registered: 2005-06-29
Posts: 409
Website

Re: glz_custom_fields

Hi zanza,

there have been some jQuery issues in v1.2.2, I have fixed them, will be pushing the updated revision later on this week.

On another note, I’ve agreed with Robert about the $prefs approach, I’ll be sending a patch to the core this week, it’s going to be really helpful for other plugin authors. It won’t be available until the next TXP release (hopefully the minor one), so fingers crossed it will become available soon.

The next glz_custom_fields version due out this week is going to focus on bug fixes and improving the stability of the plugin before I will turn my attention into sed_section_fields integration.

Last edited by gerhard (2009-10-13 09:03:32)

Offline

#532 2009-10-13 10:42:26

Zanza
Plugin Author
Registered: 2005-08-18
Posts: 699
Website

Re: glz_custom_fields

thanks Gerhard. I have to say that the issue is with bot_show_image only, at the moment, because the jmd image selector I was using was outdated. Waiting for the fix+patch, anyway. Thanks.

Last edited by Zanza (2009-10-13 10:49:32)

Offline

#533 2009-10-15 06:11:57

tye
Member
From: Pottsville, NSW
Registered: 2005-07-06
Posts: 859
Website

Re: glz_custom_fields

Thanks Gerhard – a very timely release for my next project:)

Offline

#534 2009-10-16 15:09:33

Zanza
Plugin Author
Registered: 2005-08-18
Posts: 699
Website

Re: glz_custom_fields

Hi Gerhard. I found that also the recent wet_quick_open is not working when your plugin is installed. Just to give some other hint to check. Thanks.

Offline

#535 2009-10-16 19:49:00

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,316

Re: glz_custom_fields

I found that also the recent wet_quick_open is not working when your plugin is installed.

Zanza, Gerhard, I’ve these two installed and working.


In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#536 2009-10-19 07:10:48

FireFusion
Member
Registered: 2005-05-10
Posts: 698

Re: glz_custom_fields

Hi Gerhard,

any news on the patch?

Thanks.

Offline

#537 2009-10-21 10:16:58

jens31
Plugin Author
From: munich / dtschermani
Registered: 2008-08-25
Posts: 183
Website

Re: glz_custom_fields

hi

i have a little issue, but maybe im handling it wrong:
i use a custom field (type select) and provide a default value using brackets.
when putting out my custom_field value on the website, the brackets will also appear.

thanks for the help
jens

Offline

#538 2009-10-21 11:12:38

uli
Moderator
From: Cologne
Registered: 2006-08-15
Posts: 4,316

Re: glz_custom_fields

Jens, you can put another “bracket” around your custom field with rah_replace like that:

<txp:rah_replace from="{,}" to="">
	<txp:custom_field name="bracketed_cf_select" />
</txp:rah_replace>

In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links

Offline

#539 2009-10-21 11:54:48

jens31
Plugin Author
From: munich / dtschermani
Registered: 2008-08-25
Posts: 183
Website

Re: glz_custom_fields

all right, will check this out.
danke sehr.

Edit:
thanks for the hint with that rah_replace plug-in. its the shiiiiiiiiiiiiiiiiit.

Last edited by jens31 (2009-10-21 15:08:35)

Offline

#540 2009-10-22 11:02:29

redbot
Plugin Author
Registered: 2006-02-14
Posts: 1,410

Re: glz_custom_fields

Hi Gerhard,
I need urgently to finish a project I’m working on but I’m stuck with the jquery problems you mentioned here which interfere with other jquery plugins. Is there a possibility you post here the necessary amendments to the code? I’m sorry to bother but I would really appreciate it (if you can of course).

Offline

Board footer

Powered by FluxBB