Textpattern CMS

#1 2009-09-30 01:46:10

jsoo

Plugin Author

From: NC, USA

Registered: 2004-11-15

Posts: 1,793

Website

4.2.0 bug: no page_top() on first-ever login

Bloke wrote, here :

Yeah, wish I knew why you see an unstyled page with just the footer in the top left corner. Investigation continues. Any assistance from anybody at tracking it down greatly appreciated.

/textpattern/index.php, the if block beginning on line 120, is the problem. The bug goes away by making this an elseif block. If the comment on line 119 is correct, then I believe this is a proper fix. However I have only tested the first couple of logins on a new install, and one login on an existing 4.2.0 install.

Before:

		// plugins may have altered privilege settings
		if (!gps('event') && !empty($default_event) && has_privs($default_event))
		{
			 $event = $default_event;
		}

after:

		// plugins may have altered privilege settings
		elseif (!gps('event') && !empty($default_event) && has_privs($default_event))
		{
			 $event = $default_event;
		}

---

Code is topiary

#2 2009-09-30 07:24:23

Bloke

Developer

From: Leeds, UK

Registered: 2006-01-29

Posts: 11,446

Website GitHub

Re: 4.2.0 bug: no page_top() on first-ever login

I spoke out of turn, sorry. Didn’t realise issue 42 was the one and the same problem and the recent commits by wet fixed it.

Note to self: grok first, then speak.

---

The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

#3 2009-09-30 09:00:02

jsoo

Plugin Author

From: NC, USA

Registered: 2004-11-15

Posts: 1,793

Website

Re: 4.2.0 bug: no page_top() on first-ever login

Fixed is good. When’s the next release?

---

Code is topiary