mem_postmaster - Postmaster Revamp

mrdale · 2009-09-10 18:54:44

colak > I’ll sponsor the paging fix. Don’t worry.

Manfre · 2009-09-11 01:30:50

v1.0.3 is posted

ZCR zemScubscriberLists works again. <txp:zem_contact_secret name=“zemSubscriberLists” value=“List1,List2,List3” />
subscriber list search results now page.

colak · 2009-09-11 05:50:50

Manfre wrote:

ZCR zemScubscriberLists works again. <txp:zem_contact_secret name=“zemSubscriberLists” value=“List1,List2,List3” />

! works beautifully !

subscriber list search results now page.

So does this!

Michael this community does want you back:)

Manfre · 2009-09-11 13:14:42

v1.0.4 posted

Closed a few more of the inherited security holes. This one relates to an XSS hole (thanks wet) and a few more SQL injection holes I noticed. This plugin still has many security holes that still need to be plugged. I will gradually clean up the code when I have free time.

Thanks colak.

mrdale · 2009-09-11 17:15:50

upm_savenew compatability

Just a quick reminder that if you’re using upm_savenew and don’t want extra “Save New” buttons in the postmaster area of the write screen, apply the following fix

At about line 45 replace a line that looks similar to this: $('#page-article input[name="save"]').eq(0).

candyman · 2009-09-15 07:05:02

It seems that the latest version of mem_postmaster causes conflicts with some others plugins option menu in the Extensions panel.

After activating the plugin (not the library), in my case (TXP 4.0.8), the

rss_admin_db_manager (DB backup menu)
rss_live archive
tru_tags
msd_google_map
msd_colorpicker

options page stopped working.
Hope this may help the author to find the problem.

Last edited by candyman (2009-09-15 07:09:34)

colak · 2009-09-15 07:48:34

candyman wrote:

It seems that the latest version of mem_postmaster causes conflicts with some others plugins option menu in the Extensions panel.

After activating the plugin (not the library), in my case (TXP 4.0.8), the

rss_admin_db_manager (DB backup menu)

confirmed.

Error in the page:

Fatal error: Cannot redeclare pref_func() (previously declared in /users/home/xxx/web/public/textpattern/lib/txplib_misc.php(594) : eval()'d code:901) in /users/home/xxx/web/public/textpattern/include/txp_prefs.php on line 244

Manfre · 2009-09-15 14:04:56

@candyman, change the plugin load order so that mem_postmaster is after all of those other plugins.

colak · 2009-09-15 15:01:41

Hi Michael
I have changed the plugin’s load order to ‘9’ using plugin composer but the error does not go away.

Manfre · 2009-09-15 15:32:31

v1.0.5

Renamed pref_func().

The problem was caused by many plugins needing to redefine a core function and the other plugins did not properly guard with a function_exists() check. You should contact the plugin authors to get them to properly guard their code.

truist · 2009-09-15 22:35:21

Manfre, someone (colak?) alerted me to this problem (with tru_tags), and per your comment, it looks like I should be protecting a redefine of pref_func() somehow. But tru_tags doesn’t redefine, or even call, pref_func() so I’m not sure what the issue is, or how to fix it. Can you clarify?

Gocom · 2009-09-16 00:00:14

truist wrote:

Manfre, someone (colak?) alerted me to this problem (with tru_tags), and per your comment, it looks like I should be protecting a redefine of pref_func() somehow. But tru_tags doesn’t redefine, or even call, pref_func() so I’m not sure what the issue is, or how to fix it. Can you clarify?

You are redeclaring pref_func(). Pref_func() is a core function, defined in txp_prefs.php. But, in your plugin you have a line:

include(txpath . '/include/txp_prefs.php');

Which will cause conflicts with any plugin which includes the same file on same page load. To fix this, you can possibly, either use function check, class or include_once.

truist · 2009-09-16 00:08:08

Ah, that makes sense. I will fix this in the next version of tru_tags. Thank you!

Manfre · 2009-09-16 00:29:47

You also don’t want to include it when $event == ‘prefs’, since for some reason the core didn’t feel like using the *_once functions in ./textpattern/index.php.

colak · 2009-09-16 05:08:00

michael, The update seemed to have worked and the error disappeared.

Textpattern CMS

Textpattern CMS support forum

#31 2009-09-10 18:54:44

Re: mem_postmaster - Postmaster Revamp

#32 2009-09-11 01:30:50

Re: mem_postmaster - Postmaster Revamp

#33 2009-09-11 05:50:50

Re: mem_postmaster - Postmaster Revamp

#34 2009-09-11 13:14:42

Re: mem_postmaster - Postmaster Revamp

#35 2009-09-11 17:15:50

Re: mem_postmaster - Postmaster Revamp

upm_savenew compatability

#36 2009-09-15 07:05:02

Re: mem_postmaster - Postmaster Revamp

#37 2009-09-15 07:48:34

Re: mem_postmaster - Postmaster Revamp

#38 2009-09-15 14:04:56

Re: mem_postmaster - Postmaster Revamp

#39 2009-09-15 15:01:41

Re: mem_postmaster - Postmaster Revamp

#40 2009-09-15 15:32:31

Re: mem_postmaster - Postmaster Revamp

#41 2009-09-15 22:35:21

Re: mem_postmaster - Postmaster Revamp

#42 2009-09-16 00:00:14

Re: mem_postmaster - Postmaster Revamp

#43 2009-09-16 00:08:08

Re: mem_postmaster - Postmaster Revamp

#44 2009-09-16 00:29:47

Re: mem_postmaster - Postmaster Revamp

#45 2009-09-16 05:08:00

Re: mem_postmaster - Postmaster Revamp

Board footer