Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Admin Side Theming! (r3149)
Wet> does an install of yours display error messages correctly?
Offline
Re: Admin Side Theming! (r3149)
I have no problems with the display of messages in TXP (default theme or my own theme(s)).
No js errors of any type anywhere.
Where is that emoji for a solar powered submarine when you need it ?
Sand space – admin theme for Textpattern
Offline
Re: Admin Side Theming! (r3149)
Wet> I’m still not seeing alert messages on any of the themes. I’m using firefox mac.
Offline
#100 2009-05-14 16:52:36
Re: Admin Side Theming! (r3149)
Dale, on an unrelated note: Are you currently building yet another winery site? :P
On topic: I might need a login to help you.
Offline
#101 2009-05-14 23:27:01
Re: Admin Side Theming! (r3149)
wet wrote:
Dale, on an unrelated note: Are you currently building yet another winery site? :P
On topic: I might need a login to help you.
You’ve got mail.
Yep I’ve built about 10 or 12… Next one’s a YMCA tho.
Offline
#102 2009-05-15 19:08:58
Re: Admin Side Theming! (r3149)
OK Guys…
{solved} My apologies to wet. The messages are now appearing just fine. I think that my browser was caching an old version of jQuery.
Offline
#103 2009-05-27 08:56:29
Re: Admin Side Theming! (r3149)
Just a, probably naive, question regarding the theme ‘URL’. For compatibility, should txplib_theme.php use:
$this->url = THEME.sanitizeForFile($name).DS;or are all ‘weird’ characters valid in filenames?
Last edited by Bloke (2009-05-27 08:56:45)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
#104 2009-05-27 09:06:22
Re: Admin Side Theming! (r3149)
Not all weird characters are valid in file names but I think it’s a fair assumption that a theme’s author chooses them within the constraints that are imposed by the goal. But you’re quite right, rawurlencode would eventually seem fit for those borderline coders who use blanks etc. in their directory names ;-)
Offline
#105 2009-05-28 01:43:29
Re: Admin Side Theming! (r3149)
wet wrote:
rawurlencodewould eventually seem fit for those borderline coders who use blanks etc. in their directory names ;-)
… or those that, for example, use a 3rd party plugin to extend and create their own themes ;-)
Thanks for the pointer. rawurlencode is likely better than sanitizeForFile, so I’ll poke that in the plugin.
Oh, one minor thing missing from classic.php is the screenshot entry in the manifest. The theme has a screenshot.png pic but no reference to it. Is it not used on purpose?
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
#106 2009-05-28 05:02:59
Re: Admin Side Theming! (r3149)
Bloke wrote:
… or those that, for example, use a 3rd party plugin to extend and create their own themes ;-)
On second thought, said third-party plugin should encourage its users to limit theme names to adhere to the PHP variable naming restrictions, as the theme name will also be used for the class name of the theme object, therefore any “creative” naming won’t work anyway.
Oh, one minor thing missing from
classic.phpis thescreenshotentry in the manifest. The theme has a screenshot.png pic but no reference to it. Is it not used on purpose?
Thanks for the heads-up, this was an oversight from an earlier attempt to define the manifest’s contnet. Using the “convention over configuration” mantra, we expect theme screenshots to sit in the theme directory as ‘screenshot.png’ , a 260×150 pixels sized image.
Offline
#107 2009-05-28 12:21:26
Re: Admin Side Theming! (r3149)
wet wrote:
the theme name will also be used for the class name of the theme object, therefore any “creative” naming won’t work anyway.
Good call. Had forgotten about the class name being identical to the theme name, thanks for the reminder. I’ll enforce the rule.
expect theme screenshots to sit in the theme directory as ‘screenshot.png’ , a 260×150 pixels sized image.
Righty-o. Consider it expected :-)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
#108 2009-06-02 23:10:28
Re: Admin Side Theming! (r3149)
Another minor point. The admin theme guide states all user themes should begin with a 3-letter prefix. In that case, should the dropdown in the Advanced Prefs tab refrain from upper-casing the first letter of the theme name? Or should the theme manifest expose an optional friendly ‘title’ property which may be slightly different to the actual theme name; perhaps without the prefix, e.g. stu_abitblue could be titled A Bit Blue.
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline