Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#271 2009-04-03 08:12:15
Offline
#272 2009-04-03 15:00:55
Re: glz_custom_fields
Thanks for the responses, Gerard and AZW. If you’d like to reproduce the issue, you should set up a group of about twenty or so custom fields for a site (I set up 32 in my case), fill them up with text, and then try to enter text containing an apostrophe into one of them, such as: I’m Title One. In my client’s case, all fields numbered 11 and above disappeared from the write tab, but they remained present in the database and displayed on the site. Then try to use the HTML entity for an apostrophe instead. It works with the entity. At my suggestion, he also tried using a backslash before the apostrophe, but both the backslash and apostrophe displayed on the web page. Funny.
Yes. The sooner 1.2 can get out the door, the better. This is an indispensable plug-in, so I do look forward to the next update.
Offline
#273 2009-04-15 08:04:44
- mlarino
- Member
- Registered: 2007-06-29
- Posts: 367
Re: glz_custom_fields
Looking forward to the next update also, defenetly will need to use it in any website I create.
Specially because the one out now only works for txp 4.0.6 :(
Offline
#274 2009-04-15 15:50:32
Re: glz_custom_fields
gerhard> I’m still not clear on what hacks to a vanilla TXP install the latest version of glz will require.
Offline
#275 2009-04-15 16:05:52
- redbot
- Plugin Author
- Registered: 2006-02-14
- Posts: 1,410
Re: glz_custom_fields
mrdale wrote:
gerhard> I’m still not clear on what hacks to a vanilla TXP install the latest version of glz will require.
Happy to hear I’m not the only one.
Offline
#276 2009-04-16 08:50:07
Re: glz_custom_fields
Hey guys, I had an e-mail exchange with one of the glz_custom_fields contributors, I’m pasting it here since I think it’s going to be useful:
I don’t think they will merge it [my TXP changes] back into the main TXP distribution. This is going to happen sooner than seeing my patches in TXP. Maybe the core developers are so reluctant to merge the changes because some of them are very specific to my plugin. They would basically have to tweak TXP so that my plugin works with article, article_custom etc. I don’t remember them doing this for any other plugin, no reason to start with mine.
The original approach was to duplicate all the article functions such as article(), article_custom(), doArticle(), doArticles() etc. This proved so difficult to maintain that it wasn’t worth it. Whenever something changes in those functions, it’s like finding needles (because it’s not only one) in a haystack. Even a diff isn’t too helpful. Also, there is the glz_custom_fields_search_form which also needs changes to buildCustomSql() and extra tweaks to doArticles().
And, if this wasn’t enough, with v1.2, all those changes made the plugin go past the 64k limit that a SQL TEXT column supports. If I would have duplicated all the functions required for glz_custom_fields, people would have to change the db column type to LONGTEXT, or otherwise the plugin couldn’t be loaded. The other alternative was to separate the plugin in a glz_custom_fields and glz_custom_fields_lib, but that seemed more hassle. I mean, people still need to apply a patch (even in my original version of the plugin), so why jump through all those hoops when that extra step of patching was there since the very beginning?
This is the most recent diff between TXP v4.0.8 & txp-gerhard. There are a few more differences, but they have to do with indentation (editor has replaced some tabs for hard spaces). There will be a few more by the time I finish implementing the search functionality which is currently proving a bit tricky. Most of the issues have to do with how MySQL parser escapes characters (e.g. double escape in LIKE functions) & processing POST arrays when searching for custom fields.
Offline
#277 2009-04-16 09:27:29
Re: glz_custom_fields
gerhard wrote:
all those changes made the plugin go past the 64k limit
Yeah, I’m looking forward to the 16Mb codespace in TXP 4.0.9
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Hire Txp Builders – finely-crafted code, design and Txp
Offline
#278 2009-04-16 10:58:35
Offline
#279 2009-04-16 11:29:53
- mlarino
- Member
- Registered: 2007-06-29
- Posts: 367
Re: glz_custom_fields
Hi!
I hope someone can help me with this,
I am wondering what kind of change does this plugin make to the custom fields ID, I am trying to use msd_google_map v3.0a (for txp 4.0.6) but when the custom fields plugin is active is not working, because it doesnt find the fields to place the Latitude and Longitud from the google map.
Is there a way for this plugin to leave the IDs untouched? or what are the ID like now for example for a “custom-1” after this plugin is installed?
Thanks!
Offline
#280 2009-04-20 10:55:03
Re: glz_custom_fields
In msd_google_map_v0.4 you can specify in the plugin code which are the ids of the custom fields that you want to use for lat & long. If, for example, you have custom_6_set and custom_7_set in glz_custom_fields set as the Latitude and Longitude, in msd_google_map you must specify custom_6 and custom_7 to be the ids for the custom fields used for lat & long. Both custom fields used for lat & long must be of type “Text Input”. Hope that helps!
Offline
#281 2009-04-20 10:59:02
- mlarino
- Member
- Registered: 2007-06-29
- Posts: 367
Re: glz_custom_fields
Thanks Gerhard,
The thing is, thats exacly what I am doing, and only works if your plugin is not active.
I am using 4.0.6 because I need to use sed_section_fields
msd_google_map v0.3a (One that Matt just created to use in 4.0.6)
and glz_custom_fields 1.1.3
Offline
#282 2009-04-20 11:04:52
Offline
#283 2009-04-20 11:25:08
- redbot
- Plugin Author
- Registered: 2006-02-14
- Posts: 1,410
Offline
#284 2009-04-20 11:34:29
Offline
#285 2009-04-20 11:35:48
- jelle
- Member
- Registered: 2006-06-07
- Posts: 165
Re: glz_custom_fields
Uh…wait!….what?….. is 1.2 released already?
Offline