Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#25 2009-01-05 22:31:45
- els
- Moderator
- From: The Netherlands
- Registered: 2004-06-06
- Posts: 7,458
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
Does this influence the further workings of the install, or can I go on testing without waiting for your fix?
Offline
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
wet wrote:
Oops. From a quick test,
realpath(null)returns the cwd(). Will fix it.
‘null’ should not occur there. tempnam is supposed to return false if it fails. Either way, it doesn’t harm anything, because the setup dir is not empty and unlink cannot remove directories. I’d leave this for 4.0.9.
Offline
Offline
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
Els wrote:
Does this influence the further workings of the install, or can I go on testing without waiting for your fix?
If your temp directory isn’t mentioned in the diag tab any more, the “Temporary directory” prefs is set properly and e.g. file uploads work as expected then please continue testing as usual.
Offline
#29 2009-01-06 14:21:42
- els
- Moderator
- From: The Netherlands
- Registered: 2004-06-06
- Posts: 7,458
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
Thanks Robert. I haven’t found any other problems except with MLP. As usual… ;)
Offline
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
Off topic but perhaps relevant – is MLP ever going to be anything except a hack? Els’ problems above is why I don’t play with MLP – yet.
Offline
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
Just done a fresh install with r3066 in XAMPP and on a “live” server and saw no errors or notices. All seemed to go very well. :)
Just a minor point which would be aimed more at 4.0.9. What about adding Textgarden to the list of links?
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
thebombsite wrote:
What about adding Textgarden to the list of links?
A fair proposal.
Offline
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
Lookin’ good.
One thing, and I’m not sure if this is new behaviour or intentional, but on 404 pages, $pretext['s'] is not populated if using clean URLs. Adding a ?s to the URL causes $pretext['s'] to be populated but the error_404 is not called.
viz, on both the archive Page and on an error_404 Page I have:
<txp:php>
global $pretext;
echo "CUSTOM404"; // This reads echo "REAL PAGE"; on the 'archive' Page
dmp($pretext);
</txp:php>
<txp:if_section name="mySection">
YES
<txp:else />
NO
</txp:if_section>Results using permlink mode /section/title:
Test URL | echo | $pretext['s'] | <txp:if_section name="mySection">
-------------------------------------------|-------------|----------------|-----------------------------------
site.com/mySection/real-article | REAL PAGE | mySection | YES
site.com/mySection/this-does-not-exist | CUSTOM404 | NULL^ | NO^
site.com/real-article?s=mySection | REAL PAGE | mySection | YES
site.com/this-does-not-exist?s=mySection | REAL PAGE^^ | mySection | YES^ = expected mySection | YES
^^ = expected CUSTOM404
The category (or rather ?c) is still honoured and present on any Page (error or otherwise).
Is this intentional? If so, why? How can I determine the section that triggered the 404 since <txp:section /> returns empty and <txp:if_section> is false? Do I have to parse_url() or split up the REQUEST_URI myself in PHP?
Or maybe my logic is skewed and I should rethink the design…
EDIT: <txp:if_status /> goes part way to helping, but I’d still like to redirect people/offer a link to the same_section they were in when the 404 was generated
Last edited by Bloke (2009-01-07 15:08:11)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
site.com/mySection/this-does-not-existThat is a permalink URL, not a section URL. If the permalinked article isn’t found then processing stops. This isn’t something that changed in 4.0.8 (or 4.0.7), but we should check if this is the desired behaviour for 4.0.9.
site.com/real-article?s=mySection
site.com/this-does-not-exist?s=mySectionThis is a mix of clean and messy URL schemes, in which case the messy URL scheme takes precedence. I’d expect that to behave similar to site.com/?s=mySection
Offline
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
ruud wrote:
That is a permalink URL, not a section URL.
OK, thanks for clarifying the distinction. I’ll find another way to do it for now.
Last edited by Bloke (2009-01-07 16:27:05)
The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.
Txp Builders – finely-crafted code, design and Txp
Offline
#36 2009-01-08 13:16:39
- Leonick
- Member
- Registered: 2007-07-30
- Posts: 16
Re: Help us test release candidate 2 (!) for the upcoming 4.0.8 release
I’ve upgrade textpattern v4.0.6 to 4.0.7 and yesterday to 4.0.8
No problem to install it, just modified config.php
I’m tracking all error in log file and several problems appeared
Undefined index: fr-fr on line 791 on file /textpattern/lib/txplib_misc.php file i18n-ascii.txt modified line 607 replace [fr] by [fr-fr]
Undefined index: Section on line 330 on file /textpattern/publish.php replace by $out[‘s’] = (isset($rs[‘Section’])?$rs[‘Section’]:”“);
Undefined index: ID on line 329 on file /textpattern/publish.php replace by $out[‘id’] = (isset($rs[‘ID’])?$rs[‘ID’]:”“);
Undefined index: page on line 436 on file /textpattern/publish.php replace by $out[‘page’] = (isset($rs[‘page’])?$rs[‘page’]:”“);
Undefined index: css on line 437 on file /textpattern/publish.php replace by $out[‘css’] = (isset($rs[‘css’])?$rs[‘css’]:”“);
Offline