Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Re: Trouble with 4.0.7 during pre-flight check
If you upload the TXP files, set your FTP client to use BINARY encoding for the transfer instead of ASCII. This will ensure that the files get transferred without modification. See the WinSCP documentation for more information on how to change this.
Offline
Re: Trouble with 4.0.7 during pre-flight check
ruud wrote:
If you upload the TXP files, set your FTP client to use BINARY encoding for the transfer instead of ASCII. This will ensure that the files get transferred without modification. See the WinSCP documentation for more information on how to change this.
Fixed perfectly. As always, you saved me hours of trial-and-error and head-scratching.
Many thanks.
“Well, I, uh, don’t think it’s quite fair to condemn a whole program because of a single slip-up, sir.” General ‘Buck’ Turgidson
Offline
Re: Trouble with 4.0.7 during pre-flight check
I get all those file mod errors too, and I updated using command-line svn from google source (path noted in TextBook)…
http://textpattern.googlecode.com/svn/releases/4.0.7/source
Here’s the total list:
Some Textpattern files have been modified:
/css.php,
/include/txp_admin.php,
/include/txp_article.php,
/include/txp_auth.php,
/include/txp_category.php,
/include/txp_css.php,
/include/txp_diag.php,
/include/txp_discuss.php,
/include/txp_file.php,
/include/txp_form.php,
/include/txp_image.php,
/include/txp_import.php,
/include/txp_link.php,
/include/txp_list.php,
/include/txp_log.php,
/include/txp_page.php,
/include/txp_plugin.php,
/include/txp_prefs.php,
/include/txp_preview.php,
/include/txp_section.php,
/include/txp_tag.php,
/index.php,
/lib/IXRClass.php,
/lib/admin_config.php,
/lib/class.thumb.php,
/lib/classTextile.php,
/lib/constants.php,
/lib/taglib.php,
/lib/txplib_db.php,
/lib/txplib_forms.php,
/lib/txplib_head.php,
/lib/txplib_html.php,
/lib/txplib_misc.php,
/lib/txplib_update.php,
/lib/txplib_wrapper.php,
/publish.php,
/publish/atom.php,
/publish/comment.php,
/publish/log.php,
/publish/rss.php,
/publish/search.php,
/publish/taghandlers.php,
/../rpc/index.php,
/../rpc/TXP_RPCServer.php,
/update/_to_4.0.5.php,
/update/_to_4.0.7.php,
/update/_update.phpI also get this one:
Some Textpattern files are out of date:
/../index.php ?That’s probably my fault when putting the site under svn, but I don’t know what index.php file it’s referring too, exactly.
Last edited by Destry (2008-12-06 23:44:22)
Offline
Re: Trouble with 4.0.7 during pre-flight check
Destry, just upload files as binary, just that they don’t get wrong line endings. Plus remember to replace your sites ../textpattern/index.php file too (note: .. means dir above).
But, there is nothing to worry about, so you can leave those files and errors as they are.
Last edited by Gocom (2008-12-07 03:06:48)
Offline
Re: Trouble with 4.0.7 during pre-flight check
Gocom wrote:
Destry, just upload files as binary, just that they don’t get wrong line endings.
Well, it was more like a download from google.source via svn using Terminal. Is what you’re saying still relevant? If so, where do I set binary in my Terminal?
Offline
Re: Trouble with 4.0.7 during pre-flight check
The ‘binary’ thing applies to using FTP for transferring the files. I may be called differently if you use SVN to fetch TXP. Basically, what it translates to is “don’t mess with the line endings”/
Offline
Re: Trouble with 4.0.7 during pre-flight check
ruud wrote:
The ‘binary’ thing applies to using FTP for transferring the files. … Basically, what it translates to is “don’t mess with the line endings”/
That’s what I had gathered from this thread. Funny thing is, I haven’t even opened those files before. I guess I’ll try manually changing the line endings of the files indicated as changed, because frankly, I don’t like seeing 47 red error messages in my diagnostics, whether they mean anything or not.
Thanks for the insights.
Offline
#23 2008-12-10 23:20:34
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: Trouble with 4.0.7 during pre-flight check
Ruud, Robert
just a wild thought, and as I’m not familiar with FTP RFCs, this could be way off base; but could 4.0.8 add additional md5 checksums for FTP-munged transfers of the files?
If the ASCII mode transfers are just changing line endings this should produce a very limited set of possible md5 sums to check each file against. And if that’s all the changes that ASCII mode makes to transfered files, then you’ll be saving yourselves support posts on each release. :)
Many thanks for all the hard work regardless,
— Steve
Offline
Re: Trouble with 4.0.7 during pre-flight check
Just to follow up with my situation. I scrapped the svn files. I’m sure I bungled that process somewhere and couldn’t recover. For one thing, my diagnostics were saying I had 4.0.7 r3033 installed but when I did a svn info in Terminal it said I had r3039 so clearly there was something wrong there. (Someone should check the google.source links in TxB and make sure they’re not going to a dev branch, because that’s where I got the link from.)
Anyway, I made sure Transmit3 is using binary and replaced everything with a zip package from .com and all the errors went away except one: Some Textpattern files are out of date:
/../index.php. I’m assuming it means textpattern/index.php?
I’d like to go back under svn, but not if it’s going to be an error nightmare every time.
Repeating Steve — thanks to ruud and wet for all the hard work. Sorry for what seems like a lot of belly-aching, but there’s nothing nicer than doing an update and just seeing “All checks pass!”
Offline
Re: Trouble with 4.0.7 during pre-flight check
Destry wrote:
/../index.php. I’m assuming it meanstextpattern/index.php?
Precisely, no. This means textpattern/../index.php, i.e. the index.php in your site root.
Offline
Re: Trouble with 4.0.7 during pre-flight check
Shouldn’t the error message use ./../index.php?
Offline
Re: Trouble with 4.0.7 during pre-flight check
I thought /index.php meant site root ?!
So what’s the difference, because they both showed up?
Last edited by Destry (2008-12-12 20:26:06)
Offline
Re: Trouble with 4.0.7 during pre-flight check
The /textpattern dir is taken as the base directory. So if your have TXP installed in your root dir:
/../index.php = http://example.com/index.php
/index.php = http://example.com/textpattern/index.php
The checks for files outside the /textpattern dir were added later on, which is why it looks a bit strange now.
Offline
Re: Trouble with 4.0.7 during pre-flight check
Thanks, ruud. Never realized that context before (never had to). No wonder I couldn’t get rid of that last error message. :)
Offline
Re: Trouble with 4.0.7 during pre-flight check
net-carver wrote:
just a wild thought, and as I’m not familiar with FTP RFCs, this could be way off base; but could 4.0.8 add additional md5 checksums for FTP-munged transfers of the files?
That’s one way to solve it. Another way is to simply convert Windows line endings into Unix line endings during the “modified files” check on the diagnostics tab, which is now done in changeset 3043. This should fix any ‘modified file’ warning caused by the use of CRLF (windows) line endings instead of LF (unix) line endings. Even if the file contains both types of line endings, it doesn’t trigger a warning.
You’ll still get a warning if you use CR (mac classic) line endings or if you do a double conversion to windows line endings (CRCRLF), but neither is likely to happen.
jm wrote:
Shouldn’t the error message use
./../index.php?
That would’ve been more correct. Instead changeset 3043 now shows the full path for those files, to make it 100% clear which file is meant.
Last edited by ruud (2008-12-14 18:13:58)
Offline