Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
Trouble with 4.0.7 during pre-flight check
Hello.
I upgraded from 4.0.6 to 4.0.7 this morning and everything seems to have gone smoothly. However, when I run diagnostics I get the following message during pre-flight check:
Some Textpattern files have been modified:
/include/txp_article.php,
/include/txp_list.php,
/lib/classTextile.php,
/lib/constants.php,
/lib/txplib_db.php,
/lib/txplib_forms.php,
/publish.php,
/publish/atom.php,
/publish/rss.php,
/publish/taghandlers.php
I admit to having modified classTextile.php, but I haven’t touched any of the others. All the files mentioned have been updated to the 4.0.7 release, when I check them.
Also, when I run the site in debug mode I get the following message when viewing individual article pages:
Notice: Undefined variable: uLastMod in /home/hertze/public_html/textpattern/publish.php on line 906
Notice: Undefined variable: uExpires in /home/hertze/public_html/textpattern/publish.php on line 929
I don’t know if the two are connected.
Any thought?
/Joakim
Offline
Re: Trouble with 4.0.7 during pre-flight check
Did you update to the final version of TXP 4.0.7? Some of these notices were fixed since the release candidate.
Offline
Re: Trouble with 4.0.7 during pre-flight check
Yes, I downloaded and installed the version linked from the download-section of textpattern.com. It reports itself as 4.0.7. No release candidate as far as I know.
/Joakim
Offline
#4 2008-11-29 14:02:10
- michaelb
- Member
- From: London, UK
- Registered: 2008-04-02
- Posts: 21
Re: Trouble with 4.0.7 during pre-flight check
Hi, I am getting these same 2 errors with an upgrade I just made from 4.0.6 to the final version of 4.0.7 I just downloaded.
Offline
#5 2008-11-29 14:05:45
- michaelb
- Member
- From: London, UK
- Registered: 2008-04-02
- Posts: 21
Re: Trouble with 4.0.7 during pre-flight check
Forgot to say… I haven’t modified any of the files at all.
Offline
Re: Trouble with 4.0.7 during pre-flight check
The modified files warning stems from an inconsistent use of line endings in some of the TXP files (Unix line endings should be used everywhere) combined with uploading those files as type ASCII instead of Binary in your FTP client.
Offline
Re: Trouble with 4.0.7 during pre-flight check
That solved the pre-flight check for me, but not the second trouble (the warning messages).
/Joakim
Offline
Re: Trouble with 4.0.7 during pre-flight check
I suspect the warning messages are due to a plugin that needs to be updated for TXP 4.0.7. Specifically a plugin that fetches articles from the database.
Offline
#9 2008-11-29 15:43:56
- michaelb
- Member
- From: London, UK
- Registered: 2008-04-02
- Posts: 21
Re: Trouble with 4.0.7 during pre-flight check
Thank you very much Ruud. I uploaded the listed files as binary instead of ascii, and the first error went away.
Re the second error, luckily the only plugins I have installed are zem_event and zem_paginate.
In debug mode, I get this output from the zem_event_list tag:
Tag error: <txp:zem_event_list wraptag=“ul” break=“li” class=“tiger-stripe”> -> Notice: Undefined variable: uLastMod on line 906
textpattern/publish.php:906 populatearticledata()
textpattern/lib/txplib_misc.php(574) : eval()’d code:708 populatearticledata()
textpattern/publish.php:1090 zem_event_list()
textpattern/publish.php:1025 processtags()
textpattern/lib/txplib_misc.php:1548 parse()
textpattern/publish/taghandlers.php:246 parse_form()
textpattern/publish.php:1090 output_form()
textpattern/publish.php:1012 processtags()
textpattern/publish/taghandlers.php:3030 parse()
textpattern/publish.php:1090 if_section()
Tag error: <txp:zem_event_list wraptag=“ul” break=“li” class=“tiger-stripe”> -> Notice: Undefined variable: uExpires on line 929
textpattern/publish.php:929 populatearticledata()
textpattern/lib/txplib_misc.php(574) : eval()’d code:708 populatearticledata()
textpattern/publish.php:1090 zem_event_list()
textpattern/publish.php:1025 processtags()
textpattern/lib/txplib_misc.php:1548 parse()
textpattern/publish/taghandlers.php:246 parse_form()
textpattern/publish.php:1090 output_form()
textpattern/publish.php:1012 processtags()
textpattern/publish/taghandlers.php:3030 parse()
textpattern/publish.php:1090 if_section()
…etc
Could you give me an idea of any change I can make to the plugin to fix this? Or should I ask in the zem_event thread?
Last edited by michaelb (2008-11-29 15:44:23)
Offline
Re: Trouble with 4.0.7 during pre-flight check
I think these are the required changes for zem_event to fix those PHP Notice messages:
--- zem_event-0.3.5.orig 2008-11-29 16:50:00.000000000 +0100
+++ zem_event-0.3.5.new 2008-11-29 16:50:00.000000000 +0100
@@ -690,16 +690,16 @@
if (!$cats_id)
$cats_id = array(0);
$where = "zem_event_calendar.id=zem_event_category.k1 and zem_event_category.k2 IN (".join(',', quote_list($cats_id)).") and ".$where;
$grand_total = safe_count('zem_event_calendar, zem_event_date, textpattern, zem_event_category', $where.' group by zem_event_calendar.id order by '.$sort, $debug);
$lim = zem_event_paginate($limit, $grand_total);
- $rs = safe_rows_start('zem_event_calendar.*, zem_event_date.*, textpattern.*, unix_timestamp(Posted) as uPosted', 'zem_event_calendar, zem_event_date, textpattern, zem_event_category', $where.' group by zem_event_calendar.id order by '.$sort.$lim, $debug);
+ $rs = safe_rows_start('zem_event_calendar.*, zem_event_date.*, textpattern.*, unix_timestamp(Posted) as uPosted, unix_timestamp(Expires) as uExpires, unix_timestamp(LastMod) as uLastMod', 'zem_event_calendar, zem_event_date, textpattern, zem_event_category', $where.' group by zem_event_calendar.id order by '.$sort.$lim, $debug);
}
else {
$grand_total = safe_count('zem_event_calendar, zem_event_date, textpattern', $where.' order by '.$sort, $debug);
$lim = zem_event_paginate($limit, $grand_total);
- $rs = safe_rows_start('*, unix_timestamp(Posted) as uPosted', 'zem_event_calendar, zem_event_date, textpattern', $where.' order by '.$sort.$lim, $debug);
+ $rs = safe_rows_start('*, unix_timestamp(Posted) as uPosted, unix_timestamp(Expires) as uExpires, unix_timestamp(LastMod) as uLastMod', 'zem_event_calendar, zem_event_date, textpattern', $where.' order by '.$sort.$lim, $debug);
}
$out = array();
while ($row = nextRow($rs)) {
article_push();Please confirm if this solves the problem
confirmed
Last edited by ruud (2008-11-29 16:22:53)
Offline
Re: Trouble with 4.0.7 during pre-flight check
In my case it was the plugin gbp_permanent_links.
/Joakim
Offline
#12 2008-11-29 16:16:20
- michaelb
- Member
- From: London, UK
- Registered: 2008-04-02
- Posts: 21
Re: Trouble with 4.0.7 during pre-flight check
Thank you Ruud – that’s brilliant, and fixed the problem.
You just need 2 small changes to the 2 new lines of code you posted:
You have put an extra single quote mark after uPosted on each of the lines. So I removed those 2 quotes and then the fix worked.
Thanks again – and thank you for all the work on 4.0.7 – it’s great!
Michael
Offline