Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2008-11-11 09:58:25

the_ghost
Plugin Author
From: Minsk, The Republic of Belarus
Registered: 2007-07-26
Posts: 907
Website

Rename txp:custom_field's attr "val" to "value" or just add "value"

I think the equal attributes should have equal spelling. I fairly often write <txp:custom_filed value="" /> instead of using val. Such renaming can do Textpattern more logical, can’t it?


Providing help in hacking ATM! Come to courses and don’t forget to bring us notebook and hammer! What for notebook? What a kind of hacker you are without notebok?

Offline

#2 2008-11-11 10:08:29

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 11,448
Website GitHub

Re: Rename txp:custom_field's attr "val" to "value" or just add "value"

You’re advocating more typing? That’s gotta be a first ;-)

(but I must admit, I’ve erroneously used value instead of val before as well in if_custom_field)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Online

#3 2008-11-11 10:45:13

the_ghost
Plugin Author
From: Minsk, The Republic of Belarus
Registered: 2007-07-26
Posts: 907
Website

Re: Rename txp:custom_field's attr "val" to "value" or just add "value"

You’re advocating more typing? That’s gotta be a first ;-)

I’m advocating to less think where wich attribute is used :) That’s why, I think, in smd_if there is operator attr but not op or oprtr or somthing else – less remember for newbies

Last edited by the_ghost (2008-11-11 10:46:01)


Providing help in hacking ATM! Come to courses and don’t forget to bring us notebook and hammer! What for notebook? What a kind of hacker you are without notebok?

Offline

#4 2008-11-17 13:05:09

ruud
Developer Emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 5,068
Website

Re: Rename txp:custom_field's attr "val" to "value" or just add "value"

If this were a new tag, I’d agree, but how would you handle upgrades from older TXP versions?

Offline

#5 2008-11-17 17:18:44

mrdale
Member
From: Walla Walla
Registered: 2004-11-19
Posts: 2,215
Website

Re: Rename txp:custom_field's attr "val" to "value" or just add "value"

ruud wrote:

If this were a new tag, I’d agree, but how would you handle upgrades from older TXP versions?

Allow both and depricate. I don’t really care, but this one has tripped me up more than once and it took me a while to learn my lesson…

Offline

#6 2008-11-17 17:33:30

the_ghost
Plugin Author
From: Minsk, The Republic of Belarus
Registered: 2007-07-26
Posts: 907
Website

Re: Rename txp:custom_field's attr "val" to "value" or just add "value"

ruud wrote:

If this were a new tag, I’d agree, but how would you handle upgrades from older TXP versions?

I remember that exist messages, about appearing in test\debug mode about derpicated tags. Isn’t it possible to make this?


Providing help in hacking ATM! Come to courses and don’t forget to bring us notebook and hammer! What for notebook? What a kind of hacker you are without notebok?

Offline

Board footer

Powered by FluxBB