Textpattern CMS

#1 2008-09-25 20:04:23

jstubbs

Member

From: Hong Kong

Registered: 2004-12-13

Posts: 2,395

Website

Validation error with txp:comments_help

Not sure if this has been reported – developing a site and using <txp:comments_help /> in the comment_form.

After checking the site for validation errors (doctype XHTML 1.0 Strict) I noticed that the tag produces validation errors due to the use of the ‘&’ instead of ‘&’

FYI.

---

Textpattern Tips

#2 2008-09-25 20:14:59

ruud

Developer Emeritus

From: a galaxy far far away

Registered: 2006-06-04

Posts: 5,068

Website

Re: Validation error with txp:comments_help

This is the comments_help function:

function comments_help()
{
  return ('<a id="txpCommentHelpLink" href="http://rpc.textpattern.com/help/index.php?item=textile_comments&amp;language='.LANG.'" onclick="window.open(this.href, \'popupwindow\', \'width=300,height=400,scrollbars,resizable\'); return false;">'.gTxt('textile_help').'</a>');
}

I only see one ampersand there and it’s escaped. Are you referring to a different ampersand that isn’t escaped and if so, which one?

#3 2008-09-25 20:47:20

jstubbs

Member

From: Hong Kong

Registered: 2004-12-13

Posts: 2,395

Website

Re: Validation error with txp:comments_help

From the Total Validator service:

<li>Found '&' within 'href'. You should use '&amp;' instead:
     The default scripting language must be specified for an intrinsic event:
                       <a id="txpCommentHelpLink"
                       href="http://rpc.textpattern.com/help/index.php?item=textile_comments&language=en-gb"
                       onclick="window.open(this.href, 'popupwindow', 'width=300,height=400,scrollbars,resizable'); return
                       false;">
 132                     Textile Help
 132                   </a>
 132                   to style your comments. Show who you are with a
 132                   <a href="http://gravatar.com">
 132                     Gravatar
 132                   </a>
 132                   .
 132                 </li>

---

Textpattern Tips

#4 2008-09-25 21:08:31

ruud

Developer Emeritus

From: a galaxy far far away

Registered: 2006-06-04

Posts: 5,068

Website

Re: Validation error with txp:comments_help

Fixed just after the TXP 4.0.6 release in SVN changeset 2816

#5 2008-09-25 21:15:45

jstubbs

Member

From: Hong Kong

Registered: 2004-12-13

Posts: 2,395

Website

Re: Validation error with txp:comments_help

OK. I am using 4.06 so that’s why. Thanks Ruud.

---

Textpattern Tips