Proposed new public-side event: pretext_end

net-carver · 2008-06-23 02:04:49

Hello,

I’d like to suggest the introduction of a new public interface event: pretext_end in publish.php (following the introduction of textpattern_end).

My reasoning (at present) is to allow for writing comment plugins that get a chance to…

…override the variables setup by textpattern’s pretext() routine before the saveComment() function is called. Just hooking the comments.save event is too late for overriding the vars (similarly for hooking the textpattern event.)
…override some of the already extracted $prefs based on values set by textpattern’s pretext() function.

Something like this…

	$pretext = !isset($pretext) ? array() : $pretext;
	$pretext = array_merge($pretext, pretext($s,$prefs));
	extract($pretext);
	callback_event('pretext_end'); # New event

…would do the job nicely.

Last edited by net-carver (2008-06-23 04:52:53)

Gocom · 2008-06-23 04:26:40

Yes, this sounds nice indeed and would be really helpful :)

thebombsite · 2008-06-23 14:54:50

And it would save me from hacking the file. :)

Bloke · 2008-06-23 15:07:38

And adds a gratifying symmetry to proceedings :-)

wet · 2008-06-23 18:19:42

r2917. I’ve amended your proposal it wee bit to give a plugin the chance to modify $pretext.

Bloke · 2008-06-23 18:26:30

Oh now that’s a cool place for it!

Thank you fine sirs for a well proposed and executed modification, that’s going to help enormously.

wet · 2008-06-23 18:29:42

I generally think public event hooks are undervalued. From a gut feeling, I’d think we could fuel a lot of new plugin approaches with an extended clever set of event broadcasts. Open for well-formed suggestions…

ruud · 2008-06-23 18:35:16

To keep naming consistent, I’d vote for pretext_end instead of pretext_set (similar to textpattern_end).

Is there any other use for this, except for comments?
Because if it’s just for comments it’s more efficient to just trigger a callback before a comment is saved.

net-carver · 2008-06-24 01:46:32

Wet

Fantastic! Yes, better to trigger the event before $pretext is extracted; much neater.

Thank you!

Last edited by net-carver (2008-06-24 01:47:29)

thebombsite · 2008-06-24 13:06:27

That was quick. Thank you. I can remove the hack now. :)

net-carver · 2008-06-24 13:18:29

Stuart

be careful of the name change there. If you are running the dev version then make sure you and change pretext_end to pretext_set in your plugin and all should be well.

thebombsite · 2008-06-24 16:29:15

Yep. Done that bit Steve. I spotted from Robert’s and Ruud’s comments that there was a slight difference to what you had asked for so I was forewarned. All is well. :)

Textpattern CMS

Textpattern CMS support forum

#1 2008-06-23 02:04:49

Proposed new public-side event: pretext_end

#2 2008-06-23 04:26:40

Re: Proposed new public-side event: pretext_end

#3 2008-06-23 14:54:50

Re: Proposed new public-side event: pretext_end

#4 2008-06-23 15:07:38

Re: Proposed new public-side event: pretext_end

#5 2008-06-23 18:19:42

Re: Proposed new public-side event: pretext_end

#6 2008-06-23 18:26:30

Re: Proposed new public-side event: pretext_end

#7 2008-06-23 18:29:42

Re: Proposed new public-side event: pretext_end

#8 2008-06-23 18:35:16

Re: Proposed new public-side event: pretext_end

#9 2008-06-24 01:46:32

Re: Proposed new public-side event: pretext_end

#10 2008-06-24 13:06:27

Re: Proposed new public-side event: pretext_end

#11 2008-06-24 13:18:29

Re: Proposed new public-side event: pretext_end

#12 2008-06-24 16:29:15

Re: Proposed new public-side event: pretext_end

Board footer