Textpattern CMS support forum
You are not logged in. Register | Login | Help
- Topics: Active | Unanswered
#205 2008-06-14 20:27:29
Re: [plugin] [ORPHAN] sed_section_fields
Steve, you did a great job!
The only thing, which might be a bit confusing is the case-sensitive live filter…
Offline
#206 2008-06-15 00:08:27
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,306
Re: [plugin] [ORPHAN] sed_section_fields
I go along with chriloi in complimenting you on that piece, Steve!
Just one micrological wish: “cursor: default” for the Show all / Hide all switches on FF2 Mac and SAF2, both display the insertion tool.
Edit: I changed
'0' => gTxt('Show'),
to
'0' => $mlp->gTxt('show'),
in order to create a user definable text in the “Strings for internationalisation…” via 'show' => 'user_value',
Last edited by uli (2008-06-15 01:25:15)
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
#207 2008-06-15 06:19:35
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: [plugin] [ORPHAN] sed_section_fields
Christian
Hello — and thank you!
I’m using a simple jQuery selector with an attribute filter for that and I don’t know how to force it to be case insensitive at the moment. As I get time, I’ll look into it.
Uli
Just one micrological wish: “cursor: default” for the Show all / Hide all switches on FF2 Mac and SAF2, both display the insertion tool.
Ah! I see it now. Will be changed in the final release.
Regarding your change to the strings. Yes, I could do that but then folks would have two identical strings to change — the textpattern one and the plugin one. If I do it like this, the string is already automatically localized by Textpattern.
— Steve
Offline
#208 2008-06-15 10:44:12
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,306
Re: [plugin] [ORPHAN] sed_section_fields
Sorry that I made myself not clear enough, Steve, the edit wasn’t meant as criticism. The German translation uses the imperative form, which in this case looks like an ugly typo.
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
#209 2008-06-15 12:29:26
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: [plugin] [ORPHAN] sed_section_fields
Uli
no problem, didn’t take it as criticism :)
Hey, how do you handle the imperative if you use the German translation? Do you just edit it in the txp_lang table — or is it ok to use the imperative in its normal context?
I guess I’m asking if your reason is a good enough one for me to adopt that change into the plugin itself in order to give the installer the option of translating the two strings differently based on context.
Thank you in advance!
— Steve
Offline
#210 2008-06-15 13:42:28
- uli
- Moderator
- From: Cologne
- Registered: 2006-08-15
- Posts: 4,306
Re: [plugin] [ORPHAN] sed_section_fields
Hm, feel like not fully comprehending what you’re asking me. I try, anyway.
There are no distinctions between both verb forms in the German translation file, nor for “show” neither for any other verb. But as the imperative sounded odd I changed the plugin code.
Last edited by uli (2008-06-15 13:42:42)
In bad weather I never leave home without wet_plugout, smd_where_used and adi_form_links
Offline
#211 2008-06-18 15:37:02
Re: [plugin] [ORPHAN] sed_section_fields
Following up on my other post, would it be possible to add “disable comments after” and allow/disallow comments on a “per section” basis on the Sections tab with this plug-in?
Last edited by thebombsite (2008-06-18 15:37:41)
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
#212 2008-06-18 16:15:27
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: [plugin] [ORPHAN] sed_section_fields
Stuart
Added to my to-do list for this plugin. I don’t expect it will be a problem but there might be something I’ve overlooked on the moderation mechanism as I’ve not looked at it in a long time.
FWIW, I’ve another potential comments based plugin coming up so that’ll give me a refresher course!
— Steve
Offline
#213 2008-06-18 20:19:18
Re: [plugin] [ORPHAN] sed_section_fields
Cheers Steve. :)
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
#214 2008-06-21 15:37:57
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: [plugin] [ORPHAN] sed_section_fields
Stuart
As your request involves mainly public side code — and sed_section_fields is exclusively admin-only — I’ve decided to give this a shot using my comment pack as the wrapper.
Anyway to cut a long story short…
- the good news: I have a working demonstrator of this.
- the bad news: I either have to duplicate tons of code from the
pretext()routine or make a 1 line hack to a Textpattern file to do it.
Would you like to try it out?
— Steve
Offline
#215 2008-06-21 21:46:19
Re: [plugin] [ORPHAN] sed_section_fields
I’ll try anything once Steve but you’ve confused me with “involves mainly public side code”. How did that happen when what I want would be in the “Sections” tab in admin?
Stuart
In a Time of Universal Deceit
Telling the Truth is Revolutionary.
Offline
#216 2008-06-22 06:58:19
- net-carver
- Archived Plugin Author
- Registered: 2006-03-08
- Posts: 1,648
Re: [plugin] [ORPHAN] sed_section_fields
Stuart
That’s just because I haven’t tacked on an admin interface yet. I wanted to do a proof-of-concept for you. However, I guess my main point is that I don’t want (at present) to put the public code that implements your feature into an admin-only plugin. It just seems a better fit to me put the feature in the comment pack as it already implements per-article comment moderation.
Will email you the plugin soon.
— Steve
Offline