[archived] sdr_guestbook

roelof · 2008-03-22 13:34:06

Hoi Els,

I changed the article name to the right name and the form to this :
<fieldset>
<legend>Geschreven op <txp:comment_time /> door <txp:comment_name /> <legend />
<txp:comment_message />
<fieldset />

But no there is a border around the whole guestbook but it must be on every message.

Roelof

Gocom · 2008-03-22 13:56:16

Fieldsets are basically form elements and so is legend. You should use divs etc. instead.
Also you should close your fieldset, as it’s open – also your legend is open.

<fieldset>
	<legend>Geschreven op <txp:comment_time /> door <txp:comment_name /></legend>
	<txp:comment_message />
</fieldset>

Even better is something like:

<div>
	<h3>Geschreven op <txp:comment_time /> door <txp:comment_name /></h3>
	<txp:comment_message />
</div>

Last edited by Gocom (2008-03-22 13:57:25)

roelof · 2008-03-22 14:24:21

Hello Gocom,

Very wierd,

Both forms are only once used without the comment_message and after that the comments form is being used.
Can there be problem in this rule :

<txp:if_section name=“gastenboek”>
<txp:sdr_guestbook section=“gastenboek” form=“guestbook_comments_form” articletitle=“vragen of opmerkingen” />
</ txp:if_section>

regards,

Roelof

els · 2008-03-22 17:01:04

Roelof, I think the attribute needs to be commentform! form is meant to be your article form. So:

<txp:if_section name="gastenboek">
<txp:sdr_guestbook section="gastenboek" form="your_article_form" commentform="guestbook_comments_form" articletitle="Vragen of opmerkingen" />
</txp:if_section>

(There also were a couple of spaces in your tags that shouldn’t be there, so if you copy this code it should be all right.)

Last edited by els (2008-03-22 17:03:20)

roelof · 2008-03-22 18:10:51

It works,

But it seems that this plugin doesn’t make messy url’s like i have in the rest of the site.

Roelof

roelof · 2008-03-24 09:48:39

Sorry,

Found a problem.
Guestbook is working but i get allways a empty comment on the page on the day and time when you look at the guestbook.
Who knows why that happens.

Roelof

els · 2008-03-24 12:54:39

Can you post the exact content of your ‘guestbook_comments_form’ form?

roelof · 2008-03-24 13:50:58

Hoi Els,

The content od my form is :

<fieldset> <legend>Geschreven op <txp:comment_time /> door <txp:comment_name /></legend> <txp:comment_message />
</fieldset>

els · 2008-03-24 13:59:11

Hi Roelof,

First, like Gocom said earlier, you should remove the <fieldset> and <legend> tags, they are not meant to be used in this context. So better change it to

<h3>Geschreven op <txp:comment_time /> door <txp:comment_name /></h3>
<txp:comment_message />

But it’s not likely that this is causing your problem. It looks as if the same code that is your comments form, is also somewhere else. What is in your article form that you use for the guestbook article?

roelof · 2008-03-24 14:08:10

Hello Els,

That was the problem, i had typed form=guestbook_comments_form’ instead of form=default.
Learn process is a hard way for textpatttern.

But i have still the problem that the rest of my site works with messy url’s and this plugin seems to work with clean url’s

Roelof

Last edited by roelof (2008-03-24 14:20:27)

els · 2008-03-24 15:21:40

Hmm… I assume that is in the plugin code for the pagination. I have a plugin version myself but I don’t know if the version you are using is the same. Can you post the part of the plugin code that is between

// previous link

and

// end comments paging

(I’m not promising anything, I’m not much of a coder…)

roelof · 2008-03-24 15:39:49

hello Els,

I use the 4.0 sed version.
I think you mean this part :

$com_count = safe_count(‘txp_discuss’,“parentid=$ID and visible=1”); $pagenums = ceil ($com_count/$pagelimit); // if no value for page, page = 1 if ($page==”“){ $page=‘1’; } // create a start value $totalrows=$com_count; $start = ($page-1) * $pagelimit; // Showing Results 1 to 1 (or if you’re page limit were 5) 1 to 5, etc. $starting_no = $start + 1;

if ($totalrows – $start < $pagelimit) { $end_count = $totalrows; } elseif ($totalrows – $start >= $pagelimit) { $end_count = $start + $pagelimit; }

// create dynamic next, previous, and page links

Roelof

els · 2008-03-24 17:23:19

It’s not that part (we need the code that generates the URLs), but never mind because I’ve got the same version. I will have a look at it and let you know if I can figure out how to change it.

Edit: you can post code here by using bc. (or bc.. if there are blank lines in it). Like this:

bc. <here your code>
<here some more code>

or

bc.. <here some code>

<here some more code>

(Using bc.. you need to start the first paragraph after it with p. )

Last edited by els (2008-03-24 17:30:10)

roelof · 2008-03-24 20:13:21

oke,

Thank you for the explanation and i will wait for your answer.
You are a very good person.

Roelof

els · 2008-03-24 22:31:17

roelof wrote:

You are a very good person.

Not at all, I just like puzzles and to mess with plugin code :)

And I think I managed to solve this one, though it’s really risky to let me poke around in code… ;) I hope I didn’t mess up the quotes again… And I’m sure there is a better way to do it *), but this seemed to work for me. If it doesn’t work, just re-install the original plugin. And note that messy URLs are now hard-coded, if you ever want to switch to clean URLs you’ll have to revert to the original plugin.

Also, this plugin is not supported anymore, so there is always a chance that after a future TXP upgrade it will just stop working. But you can do almost the same with the core TXP comments now, except for the pagination. And that will probably be possible in the future as well.

OK, if you want to take the risk, find this line in the plugin code (under // previous link)

$pagestring .= '<li><a href="'.hu.$s.'/?page='.($page-1)."\">$previous</a></li>".n;

and replace it with

$pagestring .= '<li><a href="<txp:site_url />index.php?id=<txp:page_url type="id" />&page='.($page-1)."\">$previous</a></li>".n;

Under // dynamic page number links find

$pagestring .= '<li><a href="'.hu.$s.'/?page='.$i.'"'.">$i</a></li>".n;

and replace it with

$pagestring .= '<li><a href="<txp:site_url />index.php?id=<txp:page_url type="id" />&page='.$i.'"'.">$i</a></li>".n;

Under // next link find

$pagestring .= '<li><a href="'.hu.$s.'/?page='.($page+1)."\">$next</a></li>".n;

and replace it with

$pagestring .= '<li><a href="<txp:site_url />index.php?id=<txp:page_url type="id" />&page='.($page+1)."\">$next</a></li>".n;

*) As you can see, I don’t know PHP at all, I just put in some TXP tags ;)

Textpattern CMS

Textpattern CMS support forum

#136 2008-03-22 13:34:06

Re: [archived] sdr_guestbook

#137 2008-03-22 13:56:16

Re: [archived] sdr_guestbook

#138 2008-03-22 14:24:21

Re: [archived] sdr_guestbook

#139 2008-03-22 17:01:04

Re: [archived] sdr_guestbook

#140 2008-03-22 18:10:51

Re: [archived] sdr_guestbook

#141 2008-03-24 09:48:39

Re: [archived] sdr_guestbook

#142 2008-03-24 12:54:39

Re: [archived] sdr_guestbook

#143 2008-03-24 13:50:58

Re: [archived] sdr_guestbook

#144 2008-03-24 13:59:11

Re: [archived] sdr_guestbook

#145 2008-03-24 14:08:10

Re: [archived] sdr_guestbook

#146 2008-03-24 15:21:40

Re: [archived] sdr_guestbook

#147 2008-03-24 15:39:49

Re: [archived] sdr_guestbook

#148 2008-03-24 17:23:19

Re: [archived] sdr_guestbook

#149 2008-03-24 20:13:21

Re: [archived] sdr_guestbook

#150 2008-03-24 22:31:17

Re: [archived] sdr_guestbook

Board footer