Go to main content

Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2008-02-05 07:10:46

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

stm_javascript and 4.0.6

I wanted to post this in the author support forum but there seems to be no thread for stm_javascript

Bloke wrote

stm_javascript doesn’t show the Javascript tab under Presentation, and already has an add_privs line (mind you, the chances of it clashing with the core due to its violation of the “don’t pollute global namespace” rule is likely)

Can someone find a solution for the 4.0.6 release?

Last edited by colak (2008-02-05 07:54:40)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#2 2008-02-05 08:07:36

iblastoff
Plugin Author
From: Toronto
Registered: 2006-06-11
Posts: 1,197
Website

Re: stm_javascript and 4.0.6

add this as well:

add_privs('handle_backend_javascript', '1,2');

Offline

#3 2008-02-05 11:19:10

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

Re: stm_javascript and 4.0.6

Hi steve. Many thanks…
Where do I add it?

The plugin code starts with

if (@txpinterface == 'admin') {	
	add_privs('javascript', '1,2');
	register_tab("presentation", "js", "Javascript");
	register_callback("handle_backend_javascript", "js");
}else{
	if(gps('js')){
		return_js(gps('js'));	
	}
}

should I change that to the one below?

if (@txpinterface == 'admin') {	
	add_privs('handle_backend_javascript', '1,2');
	register_tab("presentation", "js", "Javascript");
	register_callback("handle_backend_javascript", "js");
}else{
	if(gps('js')){
		return_js(gps('js'));	
	}
}

Last edited by colak (2008-02-05 11:19:42)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#4 2008-02-06 15:46:38

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

Re: stm_javascript and 4.0.6

Found some time and upgraded 3 installs to 406.

neme.org went fine -and so did neme-imca.org but for neme.org/main/ stm_javascript just disappeared from the presentation tab in spite of the fact that I have committed the amendment above.

Any help on this would be appreciated.

> correction the javascript tab is not visible in any installs

Last edited by colak (2008-02-06 15:56:08)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#5 2008-02-06 15:53:03

iblastoff
Plugin Author
From: Toronto
Registered: 2006-06-11
Posts: 1,197
Website

Re: stm_javascript and 4.0.6

hmm maybe that handle_backend_javascript isn’t needed.

try this:

if (txpinterface == 'admin') {	
	add_privs('javascript', '1,2');
	add_privs('js', '1,2');
	register_tab("presentation", "js", "Javascript");
	register_callback("handle_backend_javascript", "js");
}else{
	if(gps('js')){
		return_js(gps('js'));	
	}
}

Offline

#6 2008-02-06 16:08:06

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

Re: stm_javascript and 4.0.6

Steve I have to say that you were much faster posting the solution than I expected. I was editing my previous post just to find your reply after submitting it.

Your solution worked! the link is not visible in the pull down menu but no worries. An extra click never hurt anyone. Thanks so much for your help.


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#7 2008-02-06 16:11:31

iblastoff
Plugin Author
From: Toronto
Registered: 2006-06-11
Posts: 1,197
Website

Re: stm_javascript and 4.0.6

np!

while you’re in the plugin tab, it shouldn’t be available in the pulldowns. but while you’re in any other tab, it should be there (at least on my test 4.0.6 installation)

Offline

#8 2008-02-06 16:23:44

colak
Admin
From: Cyprus
Registered: 2004-11-20
Posts: 9,090
Website GitHub Mastodon Twitter

Re: stm_javascript and 4.0.6

iblastoff wrote:

np!
while you’re in the plugin tab, it shouldn’t be available in the pulldowns. but while you’re in any other tab, it should be there (at least on my test 4.0.6 installation)

You are right. I am now in the write tab and it is there.

>Edit: Here is the amended plugin code for anyone who might need it.

a:9:{s:4:"name";s:14:"stm_javascript";s:6:"author";s:17:"Stanislav Müller";s:10:"author_uri";s:19:"http://dhonishow.de";s:7:"version";s:3:"0.1";s:11:"description";s:82:"Stores JavaScript files within the database and handles them similar to CSS files.";s:4:"help";s:950:"In admin section, go to tab "presentation > javascript" and create one ore more javascript files that you want to embed within your page templates. This is similiar to the "styles" tab - the JavaScript files get stored in the database and you can embed them with a new Textpattern tag:

<code>
&lt;txp:js /&gt; (embeds default JavaScript file)
</code>
<code>
<txp:js n="myDomScript" /> (embeds JavaScript file named &quot;myDomScript&quot;)
</code>

<p>This plugin has been slightly modified by <a href="http://www.neme.org">colak</a> for compatibility with the 4.0.6 release. <br />
Credit for the amended code goes to <a href="http://www.stevelam.ca/">iblastoff's</a> whose suggestions in the <a href="http://forum.textpattern.com/viewtopic.php?pid=171200#p171200">textpattern forum</a> prolongued the life of this script.</p>


Output:
<code>
<script type="text/javascript" src="http://mysite.com/?js=myDomScript"></script>
</code>";s:4:"code";s:6360:"if (txpinterface == 'admin') {	
	add_privs('javascript', '1,2');
	add_privs('js', '1,2');
	register_tab("presentation", "js", "Javascript");
	register_callback("handle_backend_javascript", "js");
}else{
	if(gps('js')){
		return_js(gps('js'));	
	}
}

function js($array=''){
	extract($array);	
	if(!$n){
		$n = "default";
	}
	return sprintf('<script type="text/javascript" src="http://%s/?js=%s"></script>', $GLOBALS['prefs']['siteurl'], $n);
}

function return_js($name){
	ob_start();
	ob_end_clean();		
	global $js_prefix;
	
	if(strlen($GLOBALS['txpcfg']['table_prefix']) != 0){
		$js_prefix = $GLOBALS['txpcfg']['table_prefix']."js";
	}else{
		$js_prefix = "txp_js";
	}
	
	$js = fetch("js",$GLOBALS['js_prefix'],'name',$name);
	
	if ($js) {
		$js_decoded =  base64_decode($js);
	}else{
		$js_decoded = "alert('Javascript File could not be found!')";
	}	
	header('Content-type: application/x-javascript');
	header(sprintf('Content-Length: %d', strlen($js_decoded)));
	echo $js_decoded;
	exit;
}

function handle_backend_javascript(){
	global $js_prefix;
	
	if(strlen($GLOBALS['txpcfg']['table_prefix']) != 0){
		$js_prefix = $GLOBALS['txpcfg']['table_prefix']."js";
	}else{
		$js_prefix = "txp_js";
	}
	
	safe_query(sprintf("CREATE TABLE IF NOT EXISTS %s ( 
						  name varchar(255) NOT NULL default '',
						  js longtext NOT NULL,
						  PRIMARY KEY  (name));", $js_prefix));
	if(safe_count($js_prefix, "name='default'") == "0"){
		safe_insert($js_prefix, "name='default', js='Ly8gUGxlYXNlIGluc2VydCB5b3VyIEphdmFTY3JpcHQgaGVyZTo='");
	}
	
	
	
	if (!defined('txpinterface')) die('txpinterface is undefined.');
		if (gps('event') == 'js') {
			$step = gps('step');
			require_privs('js');
			switch ($step) {
				case '': js_edit(); 											break;
				case 'js_edit_raw': js_edit();           	break;
				case 'js_edit_form': js_edit();          	break;
				case 'pour': js_edit();	               		break;
				case 'js_save': js_save();              	break;
				case 'js_save_as': js_save_as();         	break;
				case 'js_save_posted': js_save_posted(); 	break;
				case 'js_delete': js_delete();           	break;
				case 'js_edit': js_edit();               	break;
				case 'del_dec': js_edit();               	break;
				case 'add_dec': js_edit();                break;
				case 'add_sel': js_edit();
			}
	}
}

// ------------------------------

//-------------------------------------------------------------
	function js_list($name){	
		$out[] = startTable('list','left');
		$rs = safe_rows_start("name as jsname", $GLOBALS['js_prefix'],"1=1");
		if ($rs) {
			while ($a = nextRow($rs)) {
				extract($a);
				$namelink = ($name!=$jsname)
				?	eLink('js','','name',$jsname,$jsname)
				:	$jsname;
				$deletelink = ($jsname!='default') ? 
					dLink('js','js_delete','name',$jsname) : '';
				$out[] = tr(td($namelink).td($deletelink));
			}
			$out[] =  endTable();
			return join('',$out);
		}
	}

//-------------------------------------------------------------
	function js_edit($message=''){
		pagetop(gTxt("edit_js"),$message);
		global $step,$prefs;
		if (!$step or $step == 'js_save'){
			js_edit_raw();
		} else {
			if ($step=='js_edit_raw' or $step=='pour' or $step=='js_delete') {
				js_edit_raw();
			}
		}
	}


//-------------------------------------------------------------
	function js_edit_raw(){
		global $step;
		$name = (!gps('name') or $step=='js_delete') ? 'default' : gps('name');
		if (gps('copy') && trim(preg_replace('/[<>&"\']/', '', gps('newname'))) )
			$name = gps('newname');

		if ($step=='pour'){
			$buttons = 
			gTxt('Name of JavaScript file').': '
			.fInput('text','newname','','edit','','',20).
			hInput('savenew','savenew');
			$thejs = '';
		} else {
			$buttons = '';
			$thejs = base64_decode(fetch("js",$GLOBALS['js_prefix'],'name',$name));
		}
	
		if ($step!='pour') {
			$left = graf(gTxt('You are editing:').br.strong($name)).
				graf(sLink('js', 'pour', gTxt('Create new JavaScript file')));
		} else {
			$left = '&nbsp;';
		}

		$right = 
		hed(gTxt('All JavaScript files'),2).
		js_list($name);

		echo 
		startTable('edit').
		tr(
			tdtl(
				$left
			).
			td(
				form(
					graf($buttons).
					'<textarea id="js" class="code" name="js" cols="78" rows="32">'.$thejs.'</textarea>'.br.
					fInput('submit','',gTxt('save'),'publish').
					eInput('js').sInput('js_save').
					hInput('name',$name)
				)
			).
			tdtl(
				$right
			)
		).
		endTable();
		
	}

// -------------------------------------------------------------

	function js_save_posted(){
		$name = gps('name');
		#$js  = parsePostedjs();
		$js  = doSlash(base64_encode(js_format($js)));

		safe_update($GLOBALS['js_prefix'], "js = '$js'", "name = '".doSlash($name)."'");

		$message = gTxt('js_updated', array('{name}' => $name));

		js_edit($message);
	}

//-------------------------------------------------------------

	function js_save(){
		extract(gpsa(array('name','js','savenew','newname','copy')));
		$js = doSlash(base64_encode($js));

		if ($savenew or $copy)
		{
			$newname = doSlash(trim(preg_replace('/[<>&"\']/', '', gps('newname'))));

			if ($newname and safe_field('name', $GLOBALS['js_prefix'], "name = '$newname'"))
			{
				$message = gTxt('js_already_exists', array('{name}' => $newname));
			}
			elseif ($newname) 
			{
				safe_insert($GLOBALS['js_prefix'], "name = '".$newname."', js = '$js'");

				$message = gTxt('js_created', array('{name}' => $newname));
			}
			else
			{
				$message = gTxt('js_name_required');
			}

			js_edit($message);
		}

		else
		{
			safe_update($GLOBALS['js_prefix'], "js = '$js'", "name = '".doSlash($name)."'");

			$message = gTxt('js_updated', array('{name}' => $name));

			js_edit($message);
		}
	}

// -------------------------------------------------------------

//-------------------------------------------------------------
	function js_delete(){
		$name = ps('name');

		if ($name != 'default')
		{
			safe_delete($GLOBALS['js_prefix'], "name = '".doSlash($name)."'");

			js_edit(
				gTxt('js_deleted', array('{name}' => $name))
			);
		}

		else
		{
			echo gTxt('cannot_delete_default_js').'.';
		}
	}
";s:4:"type";s:1:"1";s:3:"md5";s:32:"933032a841b3977a035aaf1030ba3f06";}

Last edited by colak (2008-02-07 16:35:01)


Yiannis
——————————
NeMe | hblack.art | EMAP | A Sea change | Toolkit of Care
I do my best editing after I click on the submit button.

Offline

#9 2008-03-14 10:31:14

candyman
Member
From: Italy
Registered: 2006-08-08
Posts: 684

Re: stm_javascript and 4.0.6

I noticed that in Steve’s code the “@” before “txpinterface” disappeared. I’m not a coder: is the same?

Offline

#10 2008-03-14 11:24:47

FireFusion
Member
Registered: 2005-05-10
Posts: 698

Re: stm_javascript and 4.0.6

This plugin should be like rvm_css as currently slows pages loads on the public side considerably.

Offline

#11 2008-03-14 11:50:13

ruud
Developer Emeritus
From: a galaxy far far away
Registered: 2006-06-04
Posts: 5,068
Website

Re: stm_javascript and 4.0.6

candyman, the @ suppresses a PHP warning if txpinterface is not defined, but since it always is in situations where this plugin is used, there’s no need for it.

Robin, I agree. Not just that, but it should be rewritten to avoid name space pollution.

Offline

Board footer

Powered by FluxBB