[plugin] [ORPHAN] zem_redirect

Sencer · 2004-07-08 10:16:59

I am still getting circular redirects, however this may be due to my blog having imported entries from b2. I guess this won’t happen if you only have entries made with textpattern.

An example can be seen here:

http://www.sencer.de/article/50/openbook----freie-b%EF%BF%BDcher

There are some “funny characters” in the url, anyway I have test-mode activated and I always get this:

<code>requested URL: http://www.sencer.de/article/50/openbook----freie-b%EF%BF%BDcher redirect to: http://www.sencer.de/article/50/openbook----freie-b�cher</code>

Last edited by Sencer (2004-07-08 10:19:12)

zem · 2004-07-09 04:18:50

Thanks for the report, Sencer – it’s a bug in the plugin’s handling of non-ascii characters. Nothing to do with b2. I’ll fix this and the other outstanding issues soon.

ThrokFeroth · 2004-07-09 06:18:04

Funny thing really. When I put in the test attribute this is what comes out:

requested URL: http://www.relativemind.net/
redirect to: http://relativemind.net/

when I requested for http://relativemind.net.

zem · 2004-07-09 07:08:25

Hmm, strange.

The domain name in the “requested URL:” output comes from the SERVER_NAME variable. That’s supposed to be the current vhost name, but it’s not necessarily clear whether that’s always the case – for example after a 302 redirect, which is what you’re using in addition to the plugin.

I’ll add an option to the next version to ignore the domain name portion of the URL. Hopefully that’ll solve the problem for you.

zem · 2004-07-10 02:38:49

There’s a new version up:

http://vigilant.tv/documents/tp/zem_redirect-0.5.txt

Changes:

Adds a new attribute “ignoredomain”, to help eliminate circular redirects on www/no www domains
Adds a new attribute “errorid”, which specifies an article ID to display as a 404 message
Now checks that the URL section matches the article section, and redirects if necessary – useful if you’ve moved an article from one section to another
Should fix the non-ASCII URL bug (untested)

Sencer · 2004-07-10 07:54:04

> zem wrote:
> Should fix the non-ASCII URL bug (untested)

Confirmed. For me it works as expected now. Thank you, zem! :)

ThrokFeroth · 2004-07-10 13:12:17

Ok, it works well on my site now with the ignoredomain attribute. The /default problem isn’t there either.

Thanks alot, zem.

Andrew · 2004-09-28 22:38:13

I have a weird behavior from this plugin. I’ve set up a new section & page type for errors. If you request a non-existent article id the plugin behaves fine & throws a 404 invisibly. But it you just put in nonsense after the domain (a non-existent section) then the plugin redirects you straight to the error page, not invisibly as an ErrorDocument should.

Edit: this isn’t referring to my personal site; it’s an internal site unfortunately not accessible from outside my work

Last edited by compooter (2004-09-28 22:42:06)

hafnius · 2004-10-13 03:01:20

Hi Zem

Great plugin!

Any chance that you could include the option of providing an acticle id for Authorization Required, 401?
/Hafnius

zem · 2004-10-13 05:40:27

Hafnius,

You can (and should) handle that with a regular .htaccess ErrorDocument.

The plugin can’t do it because it has no way to intercept errors – it can only handle those generated by the plugin itself. (Which I think explains Compooter’s query above – the plugin can’t act as an ErrorDoc handler for things that occur outside of Texpattern, such as a missing section file)

hafnius · 2004-10-13 14:01:57

Aahhh I see – thanks for the clarification.

misterk · 2004-10-31 04:00:28

zem – I think this plugin is redirecting http://station11.net/log/234/#comment to http://station11.net/log/234/photos-from-france. Has anyone else noticed this? I could just be misinterpreting the comments_invite function and passing it the wrong variables.

<code>[kjell@imac:~] % curl -I http://station11.net/log/234/#comment
HTTP/1.1 301 Moved Permanently
Date: Sun, 31 Oct 2004 03:54:04 GMT
Server: Apache
X-Powered-By: PHP/4.3.8, The blood, sweat and tears of the fine, fine TextDrive staff
Location: http://station11.net/log/234/photos-from-france
Vary: Accept-Encoding
Served-By: TextDrive
Connection: close
Content-Type: text/html; charset=UTF-8</code>

There’s the pages information, and here is how the part of my plugin which generates the comments link looks like: $comments = comments_invite($AnnotateInvite,$Section,$ID);. My fault or the plugins?

Last edited by misterk (2004-10-31 04:01:14)

zem · 2004-10-31 09:58:06

A web browser shouldn’t send the ‘#comment’ part in the GET request, though some might under certain circumstances. Have you seen this happen with a browser?

misterk · 2004-10-31 17:12:34

I don’t think it is… it’s in the url, as an identifier. A 301 is returned, and php redirects the page to /title. I don’t see where anything is in a get, but when you load it in a browser you just get redirected just like curl says.

zem · 2004-10-31 21:49:51

Oh, right, I misread the URL. The web browser requests ‘http://station11.net/log/234/’, and the plugin redirects it to ‘http://station11.net/log/234/photos-from-france’. Firefox handles this correctly, and tacks ‘#comment’ on the end of the new URL; IE doesn’t.

The ‘#comment’ part normally isn’t sent to the server, so the plugin doesn’t have an opportunity to do anything about it.

As of 1999, only about one third of Web browsers re-applies the fragment identifier to the redirected URL.

A quick google suggests this is an open problem.

Textpattern CMS

Textpattern CMS support forum

#16 2004-07-08 10:16:59

Re: [plugin] [ORPHAN] zem_redirect

#17 2004-07-09 04:18:50

Re: [plugin] [ORPHAN] zem_redirect

#18 2004-07-09 06:18:04

Re: [plugin] [ORPHAN] zem_redirect

#19 2004-07-09 07:08:25

Re: [plugin] [ORPHAN] zem_redirect

#20 2004-07-10 02:38:49

Re: [plugin] [ORPHAN] zem_redirect

#21 2004-07-10 07:54:04

Re: [plugin] [ORPHAN] zem_redirect

#22 2004-07-10 13:12:17

Re: [plugin] [ORPHAN] zem_redirect

#23 2004-09-28 22:38:13

Re: [plugin] [ORPHAN] zem_redirect

#24 2004-10-13 03:01:20

Re: [plugin] [ORPHAN] zem_redirect

#25 2004-10-13 05:40:27

Re: [plugin] [ORPHAN] zem_redirect

#26 2004-10-13 14:01:57

Re: [plugin] [ORPHAN] zem_redirect

#27 2004-10-31 04:00:28

Re: [plugin] [ORPHAN] zem_redirect

#28 2004-10-31 09:58:06

Re: [plugin] [ORPHAN] zem_redirect

#29 2004-10-31 17:12:34

Re: [plugin] [ORPHAN] zem_redirect

#30 2004-10-31 21:49:51

Re: [plugin] [ORPHAN] zem_redirect

Board footer